fix(historian): address code review on Raw HistoryRead paging

C1 (critical): a boundary tie cluster larger than NumValuesPerNode could
silently truncate a resumed read to GoodNoData, permanently dropping the
un-emitted ties — the (timestamp, skip) cursor cannot advance past a single
timestamp the fixed-(start,end,cap) backend keeps re-returning. Now detected
and failed LOUDLY per node with BadHistoryOperationUnsupported + a log naming
the tag/timestamp/cap; documented in Historian.md with the larger-cap remedy.
Regression test Raw_tie_cluster_larger_than_page_fails_loudly_not_silently.

I3: build HistoryData before Save() so a projection failure can never orphan a
stored continuation cursor.

N1 (YAGNI): drop the never-produced HistoryReadKind enum + Processed-only
Aggregate/IntervalTicks fields from HistoryContinuationState — only Raw pages.

N3: ComputeResumeCursor guards its documented non-empty precondition.

I1: document InMemoryHistoryContinuationStore's eventual-consistency (test double).

Build clean, 182/182 OpcUaServer tests pass.
This commit is contained in:
Joseph Doherty
2026-06-15 05:15:07 -04:00
parent 94c3ca60fc
commit bea0b482d4
6 changed files with 101 additions and 36 deletions
@@ -105,7 +105,11 @@ internal sealed class InMemoryHistoryContinuationStore(int capacity = 100) : IHi
{
private readonly object _gate = new();
private readonly Dictionary<Guid, HistoryContinuationState> _states = new();
// Insertion order, so we can evict the OLDEST when over capacity (matches the SDK store).
// Insertion order, so we can evict the OLDEST when over capacity (matches the SDK store). Eventually
// consistent: a Guid taken/released stays in _order until the eviction loop reaches it and finds it
// already gone from _states (a harmless no-op dequeue). _states is the source of truth for liveness;
// _order only ever over-approximates it, so eviction never drops a LIVE entry early. Fine for a
// bounded test double — production uses the SDK's own per-session store, not this class.
private readonly Queue<Guid> _order = new();
private readonly int _capacity = capacity < 1 ? 1 : capacity;