docs(archreview): R2-01 S7 fault-path hardening complete — STAB-14/15 fixed, STAB-8 seam documented (task 12)
v2-ci / build (pull_request) Successful in 3m28s
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (pull_request) Failing after 3m34s
v2-ci / unit-tests (pull_request) Failing after 9m12s
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (pull_request) Failing after 1m46s

This commit is contained in:
Joseph Doherty
2026-07-13 10:09:03 -04:00
parent a1b22f979d
commit bdb7ed412d
3 changed files with 42 additions and 2 deletions
+18
View File
@@ -150,3 +150,21 @@ surface), 03/S2/S3 block-bridging, 03/P1 surgical adds (guard prerequisite in pl
per-plan task counts, effort, and suggested execution order: [`00-INDEX.md`](00-INDEX.md) §"Round 2
plans". 193 bite-sized TDD tasks total, ~1824 dev-days end-to-end; R2-01/02/03 (the re-review's
new-and-sharp items) are ~2 days combined.
**Round-2 execution progress:**
- **R2-01 (05/STAB-14 + 05/STAB-15) — DONE.** S7 fault-path hardening implemented via 13 TDD tasks
on branch `r2/01-s7-fault-hardening` (all in `src/Drivers/.../S7Driver.cs` + `S7DriverReconnectTests.cs`).
STAB-14: connect-timeout now surfaces as `TimeoutException` (not an escaping OCE) at the
`EnsureConnectedAsync`/`InitializeAsync` source, plus `when (token.IsCancellationRequested)` filters on
the read/write ensure-wrappers + all three poll-loop OCE catches — subscription poll loops survive an
unreachable-host outage and recover. STAB-15: `IsS7ConnectionFatal` broadened to the ISO-on-TCP framing
surface (`TPKTInvalidException`/`TPDUInvalidException`/`WrongNumberOfBytesException` +
`PlcException{WrongNumberReceivedBytes}`; deliberately NOT `InvalidDataException`); cancellation observed
mid-PDU on read/write marks the handle dead before propagating; the probe restructured to classify + mark
dead under the gate so the next tick reopens. STAB-8 (S7 part): documented `EnsureConnectedAsync` as the
R2-09 connect-throttle seam (note-only, no throttle here). S7 unit suite 246/246 green (T1T9 + pinning +
negative controls). **Live gate (task 11) `deferred-live`:** `S7_1500ConnectTimeoutOutageTests` authored +
skips cleanly offline; run it with env vars `S7_TIMEOUT_OUTAGE_START_CMD` / `S7_TIMEOUT_OUTAGE_STOP_CMD`
(SYN-blackhole start/stop, e.g. `docker pause`/`unpause` or `iptables … -j DROP`) on the 10.100.0.35
s7_1500 fixture — the connect-*timeout* class the `docker restart` bounce test structurally cannot produce.