docs(code): honest rationales — Akka restart semantics, per-key shards, EF literal inlining; retire or annotate orphaned members

2026-08-16 05:33:33 -04:00
parent dbc9223206
commit b9e9df4081
11 changed files with 133 additions and 58 deletions
@@ -316,6 +316,14 @@ public sealed class OtOpcUaNodeManager : CustomNodeManager2
    /// <summary>
    ///     Re-authorizes live subscriptions when a deployment installs a new authorization generation.
    /// </summary>
+    /// <remarks>
+    ///     ⚠️ <b>This is the only trigger, and the pass's memo depends on that.</b>
+    ///     <see cref="IsSubscriptionStillPermitted"/> memoizes key revocation and expiry for the span of one
+    ///     pass — safe only while revalidation is deploy-triggered, because a pass is then a momentary
+    ///     event whose verdicts cannot go stale within it. A future periodic trigger must give each tick a
+    ///     fresh memo (it already does — the dictionary is pass-local) and must not be tempted to reuse one
+    ///     across ticks, or an expiry landing between ticks would be served the previous tick's allow.
+    /// </remarks>
    /// <param name="snapshot">The newly published snapshot; unused — the current state is re-read per item.</param>
    private void OnAuthorityChanged(DataPlaneAuthoritySnapshot snapshot) => RevalidateMonitoredItems();