dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs(comments): correct 7 stale 'later task/milestone' comments (stillpending §9)

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-15 09:47:08 -04:00
parent 68a0f759f0
commit b4af9e7f37
8 changed files with 31 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Galaxy/Browse/GalaxyDiscoverer.cs
+3 -3
View File
@@ -17,9 +17,9 @@ namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Browse;
/// <item>Folder per gobject; variables placed inside their owner folder.</item>
/// <item>Variable's full reference = <c>tag_name.attribute_name</c> — the format MXAccess
/// expects for read/write addressing (translated from the contained-name browse path).</item>
/// <item>Hierarchy is rendered flat (one folder per gobject under the driver root) for
/// this PR. PR 4.W's address-space wiring revisits whether to nest under
/// <c>parent_gobject_id</c> for a true tree shape.</item>
/// <item>Hierarchy is rendered flat (one folder per gobject under the driver root).
/// Nesting under <c>parent_gobject_id</c> for a true tree shape is not implemented;
/// the flat layout is the current shipping behaviour.</item>
/// </list>
/// </remarks>
public sealed class GalaxyDiscoverer
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Galaxy/GalaxyDriver.cs
+6 -6
View File
@@ -863,12 +863,12 @@ public sealed class GalaxyDriver
if (_dataWriter is null)
{
// Mirror the IReadable fallback: production write path runs on top of
// GalaxyMxSession (PR 4.2 skeleton; PR 4.4 wires the live session). Until
// that lands, deployments selecting Galaxy:Backend=mxgateway can't write.
// GatewayGalaxyDataWriter, which is wired by InitializeAsync when the gRPC session
// connects. This guard fires only if the driver is called before initialization completes.
throw new NotSupportedException(
"GalaxyDriver.WriteAsync requires GatewayGalaxyDataWriter wired against a connected " +
"GalaxyMxSession (PR 4.4). Until that lands, route writes through the legacy-host " +
"backend (Galaxy:Backend=legacy-host).");
"GalaxyMxSession. Call InitializeAsync and wait for a successful connection before " +
"issuing writes.");
}
return _dataWriter.WriteAsync(writes, ResolveSecurity, cancellationToken);
@@ -887,7 +887,7 @@ public sealed class GalaxyDriver
{
throw new NotSupportedException(
"GalaxyDriver.SubscribeAsync requires a connected GalaxyMxSession + GatewayGalaxySubscriber. " +
"PR 4.W wires the production session; until then route subscriptions through the legacy-host backend.");
"Call InitializeAsync and wait for a successful connection before subscribing.");
}
var pump = EnsureEventPumpStarted();
@@ -1103,7 +1103,7 @@ public sealed class GalaxyDriver
{
throw new NotSupportedException(
"GalaxyDriver.AcknowledgeAsync requires GatewayGalaxyAlarmAcknowledger wired against a connected " +
"GalaxyMxSession (PR B.2). InitializeAsync must run before alarm acknowledgements can flow.");
"GalaxyMxSession. InitializeAsync must complete successfully before alarm acknowledgements can flow.");
}
// Acks are issued one-by-one — the gateway RPC accepts a single alarm