fix(adminui): preserve un-edited Modbus tag fields across edit (review)

Capture the original ModbusTagDefinition as _source in ModbusTagRow and rewrite ToDefinition() to use 'with {}', so StringByteOrder, ArrayCount, Deadband, UnitId, and CoalesceProhibited survive a load→edit→save cycle.
2026-05-29 09:18:36 -04:00
parent f655efc570
commit b351a81c8f
2 changed files with 41 additions and 6 deletions
@@ -151,4 +151,23 @@ public sealed class ModbusDriverPageFormSerializationTests
        ModbusDriverPage.ModbusTagRow.ValidateRow(new() { Name = "A" }, rows, null)
            .ShouldNotBeNull();
    }
+
+    [Fact]
+    public void ToDefinition_preserves_unedited_fields()
+    {
+        var original = new ModbusTagDefinition(
+            "T", ModbusRegion.HoldingRegisters, 5, ModbusDataType.Int16,
+            StringByteOrder: ModbusStringByteOrder.LowByteFirst,
+            ArrayCount: 10, Deadband: 0.5, UnitId: 3, CoalesceProhibited: true);
+        var row = ModbusDriverPage.ModbusTagRow.FromDefinition(original);
+        row.Name = "Renamed";
+
+        var back = row.ToDefinition();
+        back.Name.ShouldBe("Renamed");
+        back.UnitId.ShouldBe((byte)3);
+        back.ArrayCount.ShouldBe(10);
+        back.Deadband.ShouldBe(0.5);
+        back.StringByteOrder.ShouldBe(ModbusStringByteOrder.LowByteFirst);
+        back.CoalesceProhibited.ShouldBeTrue();
+    }
 }