dohertj2/lmxopcua
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

v3 batch1 gate: fix stale collision-error-code assertions (EquipmentSignalNameCollision -> UnsEffectiveNameCollision) in Configuration.Tests

Browse Source 
WP1 wrote these against its interim VirtualTag-only collision rule; WP4a replaced it
with the broader UnsEffectiveNameCollision rule. Neither test-sweep scope covered these
two Configuration.Tests files, so the assertions went stale. Configuration.Tests 107/107.
This commit is contained in:
Joseph Doherty
2026-07-15 21:56:36 -04:00
parent 991a3dd70a
commit b14a7cb847
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Core/ZB.MOM.WW.OtOpcUa.Configuration.Tests/DraftSnapshotFactoryTests.cs
+2 -2
View File
@@ -45,7 +45,7 @@ public sealed class DraftSnapshotFactoryTests : IDisposable
snapshot.Tags.Count.ShouldBe(1); snapshot.Tags.Count.ShouldBe(1);
snapshot.VirtualTags.Count.ShouldBe(2); snapshot.VirtualTags.Count.ShouldBe(2);
DraftValidator.Validate(snapshot).ShouldContain(e => e.Code == "EquipmentSignalNameCollision"); DraftValidator.Validate(snapshot).ShouldContain(e => e.Code == "UnsEffectiveNameCollision");
} }
/// <summary>Distinct VirtualTag names under the same equipment do not collide, so the snapshot /// <summary>Distinct VirtualTag names under the same equipment do not collide, so the snapshot
@@ -62,7 +62,7 @@ public sealed class DraftSnapshotFactoryTests : IDisposable
snapshot.Tags.Count.ShouldBe(1); snapshot.Tags.Count.ShouldBe(1);
snapshot.VirtualTags.Count.ShouldBe(1); snapshot.VirtualTags.Count.ShouldBe(1);
DraftValidator.Validate(snapshot).ShouldNotContain(e => e.Code == "EquipmentSignalNameCollision"); DraftValidator.Validate(snapshot).ShouldNotContain(e => e.Code == "UnsEffectiveNameCollision");
} }
/// <summary>Seeds one active and one released reservation for the same equipment context; /// <summary>Seeds one active and one released reservation for the same equipment context;
tests/Core/ZB.MOM.WW.OtOpcUa.Configuration.Tests/DraftValidatorTests.cs
+3 -3
View File
@@ -168,7 +168,7 @@ public sealed class DraftValidatorTests
} }
// ------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------
// ValidateNoEquipmentSignalNameCollision — v3: VirtualTag name uniqueness within equipment // ValidateNoUnsEffectiveNameCollision — v3: VirtualTag name uniqueness within equipment
// ------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------
/// <summary>Two VirtualTags sharing (EquipmentId, Name) collide on a single OPC UA NodeId.</summary> /// <summary>Two VirtualTags sharing (EquipmentId, Name) collide on a single OPC UA NodeId.</summary>
@@ -185,7 +185,7 @@ public sealed class DraftValidatorTests
], ],
}; };
DraftValidator.Validate(draft).ShouldContain(e => e.Code == "EquipmentSignalNameCollision"); DraftValidator.Validate(draft).ShouldContain(e => e.Code == "UnsEffectiveNameCollision");
} }
/// <summary>VirtualTags with the same name under DIFFERENT equipment do not collide.</summary> /// <summary>VirtualTags with the same name under DIFFERENT equipment do not collide.</summary>
@@ -202,7 +202,7 @@ public sealed class DraftValidatorTests
], ],
}; };
DraftValidator.Validate(draft).ShouldNotContain(e => e.Code == "EquipmentSignalNameCollision"); DraftValidator.Validate(draft).ShouldNotContain(e => e.Code == "UnsEffectiveNameCollision");
} }
private static VirtualTag BuildVirtualTag(string equipmentId, string name, string suffix = "") => new() private static VirtualTag BuildVirtualTag(string equipmentId, string name, string suffix = "") => new()