fix(historian): #691.3 review — a ceiling-bound per-sample read names the gateway ceiling, not the cap

2026-10-12 16:47:57 -04:00
parent 0e47e887de
commit ab5030174a
2 changed files with 43 additions and 3 deletions
@@ -182,4 +182,23 @@ public sealed class GatewayStrictCeilingTests
        await Should.ThrowAsync<HistoryReadLimitExceededException>(() => Source(fake, maxRawRows: 0).ReadProcessedAsync("T",
            At(0), At(100), TimeSpan.FromSeconds(10), HistoryAggregateType.Count, Ct));
    }
+
+    [Theory] // review: the message names the limit that actually bound the read — the gateway's ceiling, not the cap
+    [InlineData(0)]          // unbounded cap: used to say "more than 0 raw samples (MaxTimeWeightedRawRows)"
+    [InlineData(1_000_000)]  // default cap: used to cite 1,000,000
+    public async Task A_ceiling_bound_per_sample_read_names_the_gateway_ceiling(int maxRawRows)
+    {
+        var ex = await Should.ThrowAsync<HistoryReadLimitExceededException>(() => Source(Store(100, ceiling: 50), maxRawRows)
+            .ReadProcessedAsync("T", At(0), At(100), TimeSpan.FromSeconds(10), HistoryAggregateType.Count, Ct));
+        ex.Message.ShouldContain("row ceiling (50,");
+        ex.Message.ShouldNotContain("MaxTimeWeightedRawRows); the Gateway");
+    }
+
+    [Fact]
+    public async Task A_cap_bound_per_sample_read_still_names_the_cap()
+    {
+        var ex = await Should.ThrowAsync<HistoryReadLimitExceededException>(() => Source(Store(100, ceiling: null), 20)
+            .ReadProcessedAsync("T", At(0), At(100), TimeSpan.FromSeconds(10), HistoryAggregateType.Count, Ct));
+        ex.Message.ShouldContain("more than 20 raw samples");
+    }
 }