fix(redundancy): always publish first ServiceLevel (even 0) + log SafeSelfStatus failures (code-review)

2026-06-15 13:00:25 -04:00
parent 3e609a2b19
commit a9ff1a64b2
2 changed files with 33 additions and 2 deletions
@@ -113,6 +113,31 @@ public sealed class OpcUaPublishActorTests : RuntimeActorTestBase
            duration: TimeSpan.FromMilliseconds(500));
    }

+    /// <summary>Verifies that the very first computed ServiceLevel is always published even when it is
+    /// 0 — a node starting Detached (or role-less) must publish 0 rather than let the SDK default
+    /// (255 = full service) stand. The dedup against the <c>byte</c>-default <c>0</c> must not swallow
+    /// the first publish. Drives a Detached local entry (first computed level = 0) with no DB-health
+    /// probe and asserts the publisher saw exactly [0].</summary>
+    [Fact]
+    public void First_service_level_zero_is_published_not_deduped()
+    {
+        var publisher = new RecordingPublisher();
+        var local = NodeId.Parse("detached-node");
+        var actor = Sys.ActorOf(OpcUaPublishActor.PropsForTests(
+            serviceLevel: publisher, localNode: local));
+
+        actor.Tell(new RedundancyStateChanged(
+            Nodes: new[]
+            {
+                new NodeRedundancyState(local, RedundancyRole.Detached,
+                    IsClusterLeader: false, IsRoleLeaderForDriver: false, DateTime.UtcNow),
+            },
+            CorrelationId.NewId()));
+
+        AwaitAssert(() => publisher.Levels.ShouldBe(new byte[] { 0 }),
+            duration: TimeSpan.FromMilliseconds(500));
+    }
+
    /// <summary>Verifies that RedundancyStateChanged drives local ServiceLevel publish for primary leader.</summary>
    [Fact]
    public void RedundancyStateChanged_drives_local_ServiceLevel_publish_for_primary_leader()