review(Driver.AbCip.Contracts): first review; document IsArray/Writable contract

First review at 7286d320. 6 findings (doc fixes -005/-006 resolved; -001 writable-hardcode, -002 Dt-units doc, -003 dead [Display] attrs, -004 parser test gap left Open). Surfaced cross-module: AbCipTagDto/AbCipMemberDto in the factory drop ElementCount/IsArray.
2026-06-19 12:22:53 -04:00
parent a19b0f8612
commit a4d24b5cf5
3 changed files with 234 additions and 1 deletions
@@ -142,7 +142,8 @@ public sealed record AbCipDeviceOptions(
 ///     had <c>isArray:true</c> (with <c>arrayLength &gt;= 1</c>); the tag discovers as an OPC UA
 ///     array node (<c>IsArray</c> + <c>ArrayDim</c>) and reads as a typed CLR array — even when
 ///     <paramref name="ElementCount"/> is 1 (a valid 1-element array). <c>ElementCount</c> alone
-///     cannot carry this because a scalar and a 1-element array both have a count of 1.</param>
+///     cannot carry this because a scalar and a 1-element array both have a count of 1.
+///     Ignored for <see cref="AbCipDataType.Structure"/>.</param>
 public sealed record AbCipTagDefinition(
    string Name,
    string DeviceHostAddress,