From 9d91c418472491fbe2788cfaee11e8a6855209da Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Wed, 11 Nov 2026 01:54:01 -0500 Subject: [PATCH] docs: MIN_EXECUTED raise is 448 after the #816 review tests; fixture-label note reflects reality --- .github/workflows/v2-integration.yml | 2 +- CLAUDE.md | 2 +- scripts/ci/README.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/v2-integration.yml b/.github/workflows/v2-integration.yml index aa0af29eb..039480404 100644 --- a/.github/workflows/v2-integration.yml +++ b/.github/workflows/v2-integration.yml @@ -74,7 +74,7 @@ jobs: - name: assert not-all-skipped if: always() env: - # #816/#818 added 6 executing OpcUaClient tests; raise to 446 once a hosted run confirms them + # #816/#818 added 8 executing OpcUaClient tests; raise to 448 once a hosted run confirms them # (scripts/ci/README.md §"Fixture-backed integration"). MIN_EXECUTED: "440" run: bash scripts/ci/assert-not-all-skipped.sh artifacts/trx/*.trx diff --git a/CLAUDE.md b/CLAUDE.md index 8d6e834a9..89375e172 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -276,7 +276,7 @@ central SQL Server. > **Migrated 2026-04-28**: Docker config + host moved off this dev VM (DESKTOP-6JL3KKO) onto the shared Linux Docker host (`DOCKER`, 10.100.0.35) so the dev VM could shed WSL2/Hyper-V and have its GPU re-attached via ESXi passthrough. Docker Desktop is no longer installed here. All checked-in `appsettings.json` defaults, fixture-class default endpoints, and `e2e-config.sample.json` were rewritten to target `10.100.0.35`. See `docs/v2/dev-environment.md` for the full rewrite (header dated 2026-04-28). -> ⚠️ **The `project: lmxopcua` label is aspirational, not universal.** This note used to claim every fixture compose file carries it. As of 2026-07-24 only the **MQTT** fixture actually does (joined 2026-11-10 by the OpcUaClient port-NAT fixture, `Docker/nat/`, #813) — `grep -rn "labels:" tests --include=*.yml` matches `Driver.Mqtt.IntegrationTests/Docker/docker-compose.yml` and nothing else. So `docker ps --filter label=project=lmxopcua` returns the MQTT fixture alone, not the fleet. Add the label when you touch an older fixture; until then enumerate by container name. +> ⚠️ **The `project: lmxopcua` label is not universal.** As of 2026-11-11 it is carried by the MQTT, Modbus, FOCAS, MTConnect, Sql (SQL Server/Postgres/MySQL/Oracle), QuestDB historian and OpcUaClient port-NAT fixtures (`grep -rln lmxopcua tests --include=docker-compose.yml`); older stacks (e.g. AB CIP, S7, the plain opc-plc) do not, so `docker ps --filter label=project=lmxopcua` is not the whole fleet. Add the label when you touch an older fixture; until then enumerate by container name. Docker workloads run on a shared Linux host at **`10.100.0.35`** — not on this VM. Stacks live at `/opt/otopcua-/` on the host and carry the `project=lmxopcua` label so they're discoverable via `docker ps --filter label=project=lmxopcua`. diff --git a/scripts/ci/README.md b/scripts/ci/README.md index a1393437b..567fb2ff4 100644 --- a/scripts/ci/README.md +++ b/scripts/ci/README.md @@ -80,7 +80,7 @@ Neither touches `v2-ci.yml`; each has its own concurrency group (`lmxopcua-v2-in now exports the NAT container's public certificate as `OPCUA_NAT_SERVER_CERT`). Locally (2026-11-11, shared host) the two OpcUaClient projects went 13 → 19 executed with 0 skipped, and `assert-not-all-skipped.sh` counted them. Once a hosted run's TRX shows `Driver.OpcUaClient.trx` executed=8 and `Driver.OpcUaClient.Browser.trx` executed=11, - raise `MIN_EXECUTED` in `v2-integration.yml` **440 → 446**. If the NAT three show as skipped there, the certificate + raise `MIN_EXECUTED` in `v2-integration.yml` **440 → 448** (and `v2-e2e.yml` 35 → 39). If the NAT three show as skipped there, the certificate hand-off (`docker exec … /app/pki/own/certs/*.der`) did not work on the runner — fix that, do not lower the bump. - **`v2-e2e.yml`** (manual + weekly cron only; `timeout-minutes: 90`). `probe-e2e-fixtures.sh` TCP-probes 10.100.0.35 ports 5020/1102/50000; if any is closed every later step is skipped and the run is green with a