From 9c94d51bf4c1afe0799bf92f3e3434a62a4f67ec Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Mon, 13 Jul 2026 10:51:19 -0400 Subject: [PATCH] =?UTF-8?q?test(opcuaserver):=20retire=20ExtractTag*=20tes?= =?UTF-8?q?ts=20=E2=80=94=20byte-parity=20authority=20is=20Commons=20TagCo?= =?UTF-8?q?nfigIntentTests=20(R2-11)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Verification: grep 'MUST parse identically' src/ → 0 hits. Deletions co-located into T5/T6 for green builds; recorded under Execution deviations. --- .../R2-11-tagconfig-consolidation-plan.md | 18 ++++++++++++++++++ ...-tagconfig-consolidation-plan.md.tasks.json | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/archreview/plans/R2-11-tagconfig-consolidation-plan.md b/archreview/plans/R2-11-tagconfig-consolidation-plan.md index 1e14a347..85c50f0a 100644 --- a/archreview/plans/R2-11-tagconfig-consolidation-plan.md +++ b/archreview/plans/R2-11-tagconfig-consolidation-plan.md @@ -494,3 +494,21 @@ T9 ← T2 + T3 T21 ← T20 T10 ← T3 + T5 T22 ← independent (models only) T23 ← T17 + T21 T24 ← everything ``` + +--- + +## Execution deviations (R2-11) + +- **T5 / T10 — ExtractTag* test deletion co-located into T5.** Deleting the composer's + `ExtractTagAlarm`/`ExtractTagHistorize`/`ExtractTagArray` statics (T5) breaks compilation of + `OpcUaServer.Tests/ExtractTag{Alarm,Historize,Array}Tests` (they call the now-deleted internals). To + keep T5's commit build-green — the plan's T5 step explicitly sanctions "deleting their direct-static + references now" — the three test files were removed in the T5 commit. T10 therefore ran as the + grep-sweep verification only (`MUST parse identically` → 0 hits in `src/`; the byte-parity authority is + `Commons.Tests/TagConfigIntentTests`). No coverage lost: every table row was ported to + `TagConfigIntentTests`, and the compose-level behaviour is held by the permanent + `Runtime.Tests/TagConfigCorpusParityTests` guard. +- **T6 — composer device-host unit tests re-homed.** `AddressSpaceComposerDeviceHostTests`' two direct + `TryExtractDeviceHost` / `NormalizeDeviceHost` static tests were removed (the statics are deleted); their + semantics now live in `Commons.Tests/DeviceConfigIntentTests`. The suite keeps its Compose-level + `EquipmentNode.DeviceHost` projection coverage. diff --git a/archreview/plans/R2-11-tagconfig-consolidation-plan.md.tasks.json b/archreview/plans/R2-11-tagconfig-consolidation-plan.md.tasks.json index 92f4e5b6..f2a05e27 100644 --- a/archreview/plans/R2-11-tagconfig-consolidation-plan.md.tasks.json +++ b/archreview/plans/R2-11-tagconfig-consolidation-plan.md.tasks.json @@ -11,7 +11,7 @@ { "id": "T7", "subject": "DeploymentArtifact swap: delete 4 private mirrors, parse once per tag element via TagConfigIntent", "status": "completed", "blockedBy": ["T5"] }, { "id": "T8", "subject": "DraftValidator swap: Configuration→Commons ProjectReference; ExtractTagConfigFullName → TagConfigIntent.ExplicitFullName (null-on-absent preserved)", "status": "completed", "blockedBy": ["T2", "T3"] }, { "id": "T9", "subject": "EquipmentNodeWalker.ExtractFullName delegates to TagConfigIntent; repoint tree-wide canonical-parser doc cites", "status": "completed", "blockedBy": ["T2", "T3"] }, - { "id": "T10", "subject": "Retire OpcUaServer.Tests ExtractTag*Tests (authority moved to Commons.Tests); verify zero 'MUST parse identically' hits", "status": "pending", "blockedBy": ["T3", "T5"] }, + { "id": "T10", "subject": "Retire OpcUaServer.Tests ExtractTag*Tests (authority moved to Commons.Tests); verify zero 'MUST parse identically' hits", "status": "completed", "blockedBy": ["T3", "T5"] }, { "id": "T11", "subject": "TagConfigJson strict-capable readers in Core.Abstractions (TryReadEnum Absent/Valid/Invalid, ReadEnumOrDefault, ReadWritable, DescribeInvalidEnum) (TDD)", "status": "pending", "blockedBy": [] }, { "id": "T12", "subject": "Modbus equipment-tag parser: freeze test, shared readers, honour writable key, Inspect warnings", "status": "pending", "blockedBy": ["T11"] }, { "id": "T13", "subject": "S7 equipment-tag parser: freeze test, shared readers, honour writable key, Inspect warnings (+ amend Contracts banner)", "status": "pending", "blockedBy": ["T11"] },