fix(historian-sidecar): cancel SocketException guard + version-reject log + TLS test (review)

This commit is contained in:
Joseph Doherty
2026-06-12 11:31:04 -04:00
parent fd4d05534e
commit 999e58c605
2 changed files with 35 additions and 1 deletions
@@ -69,6 +69,7 @@ public sealed class TcpFrameServer : IDisposable
try { client = await _listener!.AcceptTcpClientAsync().ConfigureAwait(false); }
catch (ObjectDisposedException) when (linked.Token.IsCancellationRequested) { throw new OperationCanceledException(linked.Token); }
catch (InvalidOperationException) when (linked.Token.IsCancellationRequested) { throw new OperationCanceledException(linked.Token); }
catch (SocketException) when (linked.Token.IsCancellationRequested) { throw new OperationCanceledException(linked.Token); }
using (client)
{
@@ -107,6 +108,7 @@ public sealed class TcpFrameServer : IDisposable
await writer.WriteAsync(MessageKind.HelloAck,
new HelloAck { Accepted = false, RejectReason = $"major-version-mismatch-peer={hello.ProtocolMajor}-server={Hello.CurrentMajor}" },
linked.Token).ConfigureAwait(false);
_logger.Warning("Sidecar TCP Hello rejected: major mismatch peer={Peer} server={Server}", hello.ProtocolMajor, Hello.CurrentMajor);
return;
}
await writer.WriteAsync(MessageKind.HelloAck,