dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

review(Driver.OpcUaClient.Contracts): first review; fix TryResolve nullability + [Range] guards

Browse Source 
First review at 7286d320. -001 (Medium): TryResolve session param -> ISession? matching the
null guard + out-contract doc. -003: [Range] on MaxDiscoveredNodes/MaxBrowseDepth, drop dead
[Display]. -002 (NamespaceMap pulls full SDK into a DTO project) Open. Surfaced cross-module:
the OpcUaClient.Browser serializer lacks JsonStringEnumConverter (enum-as-int bug).
This commit is contained in:
Joseph Doherty
2026-06-19 12:22:53 -04:00
parent a7ce742763
commit 9244e506c9
3 changed files with 90 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Contracts/NamespaceMap.cs
+8 -4
View File
@@ -110,12 +110,16 @@ public sealed class NamespaceMap
/// <see cref="ToStableReference"/> or a plain <c>ns=N;…</c> NodeId — against the
/// <paramref name="currentSession"/>'s namespace table. A <c>nsu=…</c> reference is
/// re-bound through the current session's URI table so a remote reorder since connect
/// time is corrected. Returns false for empty/malformed input or an unknown URI.
/// time is corrected. Returns false for empty/malformed input, an unknown URI, or a
/// null session (defensive — callers on the reconnect path may pass a session that has
/// been torn down concurrently).
/// </summary>
/// <param name="currentSession">The OPC UA session whose namespace table to resolve against.</param>
/// <param name="currentSession">The live OPC UA session to resolve against. Passing null
/// returns false rather than throwing, matching the TryXxx contract.</param>
/// <param name="reference">The reference string to resolve (either <c>nsu=…</c> or <c>ns=N;…</c> format).</param>
/// <param name="nodeId">On success, the resolved NodeId; otherwise NodeId.Null.</param>
public static bool TryResolve(ISession currentSession, string reference, out NodeId nodeId)
/// <param name="nodeId">On success, the resolved NodeId; on failure, <c>NodeId.Null</c>.
/// Use <see cref="NodeId.IsNull(NodeId)"/> — not <c>== null</c> — to test this value.</param>
public static bool TryResolve(ISession? currentSession, string reference, out NodeId nodeId)
{
nodeId = NodeId.Null;
if (currentSession is null || string.IsNullOrWhiteSpace(reference)) return false;