perf(adminui): coalesce /script-log and /alerts renders with a ring buffer (R04 P7)

Each received event used to Insert(0) into a List and render the full page.
LiveTailBuffer queues events from the bridge thread into a bounded newest-first
ring; CoalescingRenderScheduler (TimeProvider-driven, drained on dispose)
flushes and renders at most once per 200 ms window. ScriptLog's filtered rows
are recomputed on flush/filter change instead of three times per render.

Refs #745
Claude-Session: https://claude.ai/code/session_01Ub9hGmYLQvn9XETzw7CMsT

src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Alerts.razor

@@ -12,6 +12,7 @@
 @inject AuthenticationStateProvider AuthState
 @inject IAuthorizationService AuthorizationService
 @inject IAdminOperationsClient AdminOps
+@using ZB.MOM.WW.OtOpcUa.AdminUI.LiveTail
 @implements IAsyncDisposable
 
 <PageErrorBoundary>
@@ -29,7 +30,7 @@
     Shows the most-recent @Capacity entries since the page opened; reload for a fresh window.
 </section>
 
-@if (_rows.Count == 0)
+@if (_tail.Items.Count == 0)
 {
     <section class="panel notice rise mt-3" style="animation-delay:.08s">
         No alarms in the current window. The table will populate as soon as a
@@ -39,7 +40,7 @@
 else
 {
     <section class="panel rise mt-3" style="animation-delay:.08s">
-        <div class="panel-head">Recent transitions (@_rows.Count)</div>
+        <div class="panel-head">Recent transitions (@_tail.Items.Count)</div>
         <div class="table-wrap">
             <table class="data-table">
                 <thead>
@@ -58,7 +59,7 @@ else
                     </tr>
                 </thead>
                 <tbody>
-                    @foreach (var e in _rows)
+                    @foreach (var e in _tail.Items)
                     {
                         <tr>
                             <td><span class="mono small">@e.TimestampUtc.ToString("HH:mm:ss.fff")</span></td>
@@ -137,7 +138,9 @@ else
 @code {
     private const int Capacity = 200;
 
-    private readonly List<AlarmTransitionEvent> _rows = new();
+    // Newest-first ring, filled from the bridge thread and drained once per coalescing window (R04 P7).
+    private readonly LiveTailBuffer<AlarmTransitionEvent> _tail = new(Capacity);
+    private CoalescingRenderScheduler? _render;
     private bool _connected;
 
     // Authorization — DriverOperator gates the per-row Ack/Shelve/Unshelve controls.
@@ -172,6 +175,8 @@ else
         // Subscribe to the health signal BEFORE reading IsConnected so a state change between the
         // read and the subscribe can't be missed (TOCTOU) — mirrors DriverStatusPanel's
         // SnapshotChanged-then-TryGet ordering.
+        _render = new CoalescingRenderScheduler(CoalescingRenderScheduler.DefaultWindow,
+            () => InvokeAsync(FlushTail));
         Alarms.ConnectionStateChanged += OnConnectionStateChanged;
         Alarms.Received += OnAlarm;
         _connected = Alarms.IsConnected;
@@ -275,15 +280,18 @@ else
             null, TimeSpan.FromSeconds(8), Timeout.InfiniteTimeSpan);
     }
 
-    private void OnAlarm(AlarmTransitionEvent evt) =>
-        // Marshal both the mutation and the re-render onto the circuit sync context so this can't
-        // race ClearAsync (which runs there) over the shared _rows list.
-        InvokeAsync(() =>
-        {
-            _rows.Insert(0, evt);
-            if (_rows.Count > Capacity) _rows.RemoveAt(_rows.Count - 1);
-            StateHasChanged();
-        });
+    // Bridge-actor thread: queue only. The first transition of a window arms one render ~200 ms
+    // later, so an alarm storm costs one render per window per tab instead of one per transition.
+    private void OnAlarm(AlarmTransitionEvent evt)
+    {
+        if (_tail.Add(evt)) _render?.Schedule();
+    }
+
+    // Render context: drain the queue into the ring and render once.
+    private void FlushTail()
+    {
+        if (_tail.Flush()) StateHasChanged();
+    }
 
     // Raised by the broadcaster (on the bridge actor's thread) whenever the upstream DPS
     // subscription's health flips. Marshal onto the circuit sync context like OnAlarm so the live
@@ -293,7 +301,7 @@ else
 
     private async Task ClearAsync()
     {
-        _rows.Clear();
+        _tail.Clear();
         await InvokeAsync(StateHasChanged);
     }
 
@@ -314,5 +322,6 @@ else
         Alarms.ConnectionStateChanged -= OnConnectionStateChanged;
         Alarms.Received -= OnAlarm;
         if (_opResultClearTimer is not null) await _opResultClearTimer.DisposeAsync();
+        if (_render is not null) await _render.DisposeAsync();
     }
 }

src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/ScriptLog.razor

@@ -6,13 +6,14 @@
 @using ZB.MOM.WW.OtOpcUa.AdminUI.Hubs
 @using ZB.MOM.WW.OtOpcUa.Commons.Messages.Logging
 @inject IInProcessBroadcaster<ScriptLogEntry> ScriptLogs
-@implements IDisposable
+@using ZB.MOM.WW.OtOpcUa.AdminUI.LiveTail
+@implements IAsyncDisposable
 
 <PageErrorBoundary>
 <div class="d-flex justify-content-between align-items-center mb-3">
     <h4 class="mb-0">Script log</h4>
     <div class="d-flex align-items-center gap-2">
-        <select class="form-select form-select-sm" style="width:auto" @bind="_levelFilter">
+        <select class="form-select form-select-sm" style="width:auto" @bind="_levelFilter" @bind:after="RecomputeVisible">
             <option value="">All levels</option>
             <option value="Trace">Trace+</option>
             <option value="Debug">Debug+</option>
@@ -21,7 +22,7 @@
             <option value="Error">Error+</option>
         </select>
         <input type="text" class="form-control form-control-sm" style="width:200px"
-               placeholder="Filter script ID…" @bind="_scriptFilter" @bind:event="oninput" />
+               placeholder="Filter script ID…" @bind="_scriptFilter" @bind:event="oninput" @bind:after="RecomputeVisible" />
         <span class="conn-pill" data-state="@(_connected ? "connected" : "disconnected")">
             <span class="dot"></span><span>@(_connected ? "live" : "disconnected")</span>
         </span>
@@ -29,23 +30,23 @@
     </div>
 </div>
 
-@if (VisibleRows.Count == 0)
+@if (_visible.Count == 0)
 {
     <section class="panel notice rise mt-3" style="animation-delay:.08s">
-        @if (_rows.Count == 0)
+        @if (_tail.Items.Count == 0)
         {
             <span>No script-log entries yet.</span>
         }
         else
         {
-            <span>No entries match the current filter (@_rows.Count entries available).</span>
+            <span>No entries match the current filter (@_tail.Items.Count entries available).</span>
         }
     </section>
 }
 else
 {
     <section class="panel rise mt-3" style="animation-delay:.08s">
-        <div class="panel-head">Showing @VisibleRows.Count of @_rows.Count</div>
+        <div class="panel-head">Showing @_visible.Count of @_tail.Items.Count</div>
         <div class="table-wrap">
             <table class="data-table">
                 <thead>
@@ -58,7 +59,7 @@ else
                     </tr>
                 </thead>
                 <tbody>
-                    @foreach (var e in VisibleRows)
+                    @foreach (var e in _visible)
                     {
                         <tr>
                             <td><span class="mono small">@e.TimestampUtc.ToString("HH:mm:ss.fff")</span></td>
@@ -82,7 +83,11 @@ else
 @code {
     private const int Capacity = 500;
 
-    private readonly List<ScriptLogEntry> _rows = new();
+    // Newest-first ring, filled from the bridge thread and drained once per coalescing window (R04 P7).
+    private readonly LiveTailBuffer<ScriptLogEntry> _tail = new(Capacity);
+    private CoalescingRenderScheduler? _render;
+    // The filtered rows, recomputed on flush / filter change — not on every render.
+    private IReadOnlyList<ScriptLogEntry> _visible = Array.Empty<ScriptLogEntry>();
     private bool _connected;
     private string _levelFilter = "";
     private string _scriptFilter = "";
@@ -92,22 +97,19 @@ else
         ["Trace"] = 0, ["Debug"] = 1, ["Information"] = 2, ["Warning"] = 3, ["Error"] = 4, ["Critical"] = 5,
     };
 
-    private List<ScriptLogEntry> VisibleRows
+    private void RecomputeVisible()
     {
-        get
+        IEnumerable<ScriptLogEntry> q = _tail.Items;
+        if (!string.IsNullOrWhiteSpace(_levelFilter)
+            && LevelRank.TryGetValue(_levelFilter, out var minRank))
         {
-            IEnumerable<ScriptLogEntry> q = _rows;
-            if (!string.IsNullOrWhiteSpace(_levelFilter)
-                && LevelRank.TryGetValue(_levelFilter, out var minRank))
-            {
-                q = q.Where(e => LevelRank.TryGetValue(e.Level, out var r) && r >= minRank);
-            }
-            if (!string.IsNullOrWhiteSpace(_scriptFilter))
-            {
-                q = q.Where(e => e.ScriptId.Contains(_scriptFilter, StringComparison.OrdinalIgnoreCase));
-            }
-            return q.ToList();
+            q = q.Where(e => LevelRank.TryGetValue(e.Level, out var r) && r >= minRank);
         }
+        if (!string.IsNullOrWhiteSpace(_scriptFilter))
+        {
+            q = q.Where(e => e.ScriptId.Contains(_scriptFilter, StringComparison.OrdinalIgnoreCase));
+        }
+        _visible = q.ToList();
     }
 
     protected override void OnInitialized()
@@ -116,6 +118,8 @@ else
         // 'script-logs' DPS topic). Blazor Server can't self-connect a SignalR HubConnection behind
         // a reverse proxy — see IInProcessBroadcaster — so we subscribe in-process instead.
         // Subscribe the state-change event BEFORE reading IsConnected so no transition is missed.
+        _render = new CoalescingRenderScheduler(CoalescingRenderScheduler.DefaultWindow,
+            () => InvokeAsync(FlushTail));
         ScriptLogs.ConnectionStateChanged += OnConnectionStateChanged;
         ScriptLogs.Received += OnEntry;
         _connected = ScriptLogs.IsConnected;
@@ -124,19 +128,25 @@ else
     private void OnConnectionStateChanged(bool connected) =>
         InvokeAsync(() => { _connected = connected; StateHasChanged(); });
 
-    private void OnEntry(ScriptLogEntry entry) =>
-        // Marshal both the mutation and the re-render onto the circuit sync context so this can't
-        // race ClearAsync (which runs there) over the shared _rows list.
-        InvokeAsync(() =>
-        {
-            _rows.Insert(0, entry);
-            if (_rows.Count > Capacity) _rows.RemoveAt(_rows.Count - 1);
-            StateHasChanged();
-        });
+    // Bridge-actor thread: queue only. The first entry of a window arms one render ~200 ms later, so
+    // a chatty script costs one render per window per tab instead of one per log line.
+    private void OnEntry(ScriptLogEntry entry)
+    {
+        if (_tail.Add(entry)) _render?.Schedule();
+    }
+
+    // Render context: drain the queue into the ring and render once.
+    private void FlushTail()
+    {
+        if (!_tail.Flush()) return;
+        RecomputeVisible();
+        StateHasChanged();
+    }
 
     private async Task ClearAsync()
     {
-        _rows.Clear();
+        _tail.Clear();
+        RecomputeVisible();
         await InvokeAsync(StateHasChanged);
     }
 
@@ -148,9 +158,11 @@ else
         _ => "chip-idle",
     };
 
-    public void Dispose()
+    public async ValueTask DisposeAsync()
     {
         ScriptLogs.ConnectionStateChanged -= OnConnectionStateChanged;
         ScriptLogs.Received -= OnEntry;
+        // Drains an in-flight window and suppresses later ones, so no flush renders a gone component.
+        if (_render is not null) await _render.DisposeAsync();
     }
 }

src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/LiveTail/CoalescingRenderScheduler.cs

@@ -0,0 +1,79 @@
+namespace ZB.MOM.WW.OtOpcUa.AdminUI.LiveTail;
+
+/// <summary>
+///     Coalesces bursts of "please re-render" requests into at most one flush per window. The first
+///     <see cref="Schedule"/> after a flush arms a one-shot timer; further calls inside the window are
+///     no-ops; when the timer fires the flush callback runs once (the page marshals it onto its render
+///     context with <c>InvokeAsync</c>). Disposal drains an in-flight callback and suppresses later ones.
+/// </summary>
+public sealed class CoalescingRenderScheduler : IAsyncDisposable
+{
+    /// <summary>The default coalescing window for live-tail pages.</summary>
+    public static readonly TimeSpan DefaultWindow = TimeSpan.FromMilliseconds(200);
+
+    private readonly TimeSpan _window;
+    private readonly Func<Task> _flush;
+    private readonly ITimer _timer;
+    private int _armed;
+    private volatile bool _disposed;
+
+    /// <summary>Creates the scheduler.</summary>
+    /// <param name="window">The coalescing window.</param>
+    /// <param name="flush">The callback run once per window; exceptions are swallowed (the page is the
+    ///     only consumer, and a throw here would surface as an unobserved timer-thread exception).</param>
+    /// <param name="timeProvider">The time source; <see cref="TimeProvider.System"/> when null.</param>
+    public CoalescingRenderScheduler(TimeSpan window, Func<Task> flush, TimeProvider? timeProvider = null)
+    {
+        _window = window;
+        _flush = flush;
+        _timer = (timeProvider ?? TimeProvider.System)
+            .CreateTimer(OnFire, null, Timeout.InfiniteTimeSpan, Timeout.InfiniteTimeSpan);
+    }
+
+    /// <summary>Requests a flush within one window. Safe from any thread.</summary>
+    public void Schedule()
+    {
+        if (_disposed) return;
+        if (Interlocked.CompareExchange(ref _armed, 1, 0) != 0) return;
+        try
+        {
+            _timer.Change(_window, Timeout.InfiniteTimeSpan);
+        }
+        catch (ObjectDisposedException)
+        {
+            // Raced DisposeAsync — nothing left to render to.
+        }
+    }
+
+    private void OnFire(object? state)
+    {
+        // Disarm BEFORE flushing: an item arriving during the flush schedules the next window rather
+        // than being stranded until some later item happens to arrive.
+        Volatile.Write(ref _armed, 0);
+        if (_disposed) return;
+
+        // Not async void: a fault is observed on the returned task, never thrown onto the timer thread.
+        // The circuit going away mid-flush (ObjectDisposedException and friends) is the expected fault,
+        // and a live-tail render failure is never worth an unhandled exception.
+        Task task;
+        try
+        {
+            task = _flush();
+        }
+        catch
+        {
+            return;
+        }
+
+        _ = task.ContinueWith(static t => _ = t.Exception, CancellationToken.None,
+            TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously,
+            TaskScheduler.Default);
+    }
+
+    /// <inheritdoc />
+    public async ValueTask DisposeAsync()
+    {
+        _disposed = true;
+        await _timer.DisposeAsync().ConfigureAwait(false);
+    }
+}

src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/LiveTail/LiveTailBuffer.cs

@@ -0,0 +1,94 @@
+namespace ZB.MOM.WW.OtOpcUa.AdminUI.LiveTail;
+
+/// <summary>
+///     A bounded, newest-first buffer for a live event tail (the <c>/script-log</c> and <c>/alerts</c>
+///     pages). Producers call <see cref="Add"/> from the bridge actor's thread; it only queues the item.
+///     The page drains the queue into a fixed-capacity ring on its render context (<see cref="Flush"/>),
+///     once per coalescing window, so a chatty feed costs one render per window instead of one per event,
+///     and no <c>List.Insert(0, …)</c> memmove per event.
+/// </summary>
+/// <typeparam name="T">The event type.</typeparam>
+public sealed class LiveTailBuffer<T>
+{
+    private readonly object _gate = new();
+    private readonly T[] _ring;
+    private readonly List<T> _pending = new();
+    private int _head;   // index the next item is written to
+    private int _count;
+    private IReadOnlyList<T> _snapshot = Array.Empty<T>();
+
+    /// <summary>Creates a buffer that keeps the most recent <paramref name="capacity"/> items.</summary>
+    /// <param name="capacity">Maximum retained items; must be positive.</param>
+    public LiveTailBuffer(int capacity)
+    {
+        ArgumentOutOfRangeException.ThrowIfNegativeOrZero(capacity);
+        _ring = new T[capacity];
+    }
+
+    /// <summary>The maximum number of retained items.</summary>
+    public int Capacity => _ring.Length;
+
+    /// <summary>Retained items, newest first, as of the last <see cref="Flush"/> or <see cref="Clear"/>.</summary>
+    public IReadOnlyList<T> Items => Volatile.Read(ref _snapshot);
+
+    /// <summary>Queues an item. Safe from any thread; does not change <see cref="Items"/> until the next flush.</summary>
+    /// <param name="item">The item to queue.</param>
+    /// <returns><see langword="true"/> when the queue was empty before this call, i.e. the caller should
+    ///     schedule a flush.</returns>
+    public bool Add(T item)
+    {
+        lock (_gate)
+        {
+            // A burst larger than the ring would be evicted at flush anyway; dropping the oldest pending
+            // now keeps the queue bounded when no flush runs (e.g. a stalled circuit).
+            if (_pending.Count >= _ring.Length) _pending.RemoveAt(0);
+            _pending.Add(item);
+            return _pending.Count == 1;
+        }
+    }
+
+    /// <summary>Moves the queued items into the ring (evicting the oldest past capacity) and refreshes <see cref="Items"/>.</summary>
+    /// <returns><see langword="true"/> when anything was queued, i.e. a render is worthwhile.</returns>
+    public bool Flush()
+    {
+        lock (_gate)
+        {
+            if (_pending.Count == 0) return false;
+            foreach (var item in _pending)
+            {
+                _ring[_head] = item;
+                _head = (_head + 1) % _ring.Length;
+                if (_count < _ring.Length) _count++;
+            }
+
+            _pending.Clear();
+            Volatile.Write(ref _snapshot, BuildNewestFirst());
+            return true;
+        }
+    }
+
+    /// <summary>Drops every retained and queued item.</summary>
+    public void Clear()
+    {
+        lock (_gate)
+        {
+            _pending.Clear();
+            Array.Clear(_ring);
+            _head = 0;
+            _count = 0;
+            Volatile.Write(ref _snapshot, Array.Empty<T>());
+        }
+    }
+
+    private T[] BuildNewestFirst()
+    {
+        var result = new T[_count];
+        for (var i = 0; i < _count; i++)
+        {
+            var idx = (_head - 1 - i + _ring.Length) % _ring.Length;
+            result[i] = _ring[idx];
+        }
+
+        return result;
+    }
+}