fix(admin-ui): bind Raw callers and lazy reads to their presentations

This commit is contained in:
Joseph Doherty
2026-11-14 01:00:12 -05:00
parent b3f6001f3b
commit 8929f5f32e
37 changed files with 2677 additions and 131 deletions
@@ -0,0 +1,203 @@
using System.Reflection;
using Bunit;
using Bunit.TestDoubles;
using Microsoft.AspNetCore.Components;
using Microsoft.Extensions.DependencyInjection;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.AdminUI.Components.Shared.Raw;
using ZB.MOM.WW.OtOpcUa.AdminUI.Uns;
namespace ZB.MOM.WW.OtOpcUa.AdminUI.Tests.Pages;
[Trait("Category","Unit")]
public sealed class RawCallerPresentationTests:BunitContext
{
private readonly IRawTreeService _service;
private readonly RawNode _a=new(){Kind=RawNodeKind.Folder,Key="folder:a",EntityId="a",ClusterId="cluster",DisplayName="Same folder",RowVersion=[1]};
private readonly RawNode _b=new(){Kind=RawNodeKind.Folder,Key="folder:b",EntityId="b",ClusterId="cluster",DisplayName="Same folder",RowVersion=[2]};
private readonly RawNode _driver=new(){Kind=RawNodeKind.Driver,Key="driver:a",EntityId="driver-a",ClusterId="cluster",DisplayName="Driver A",RowVersion=[1],Enabled=true};
private CallerService Service=>(CallerService)(object)_service;
public RawCallerPresentationTests()
{
JSInterop.Mode=JSRuntimeMode.Loose;JSInterop.SetupModule("./_content/ZB.MOM.WW.OtOpcUa.AdminUI/js/tree-layout.js").Mode=JSRuntimeMode.Loose;
var names=new HashSet<string>{"DriverConfigModal","DeviceModal","RawTagModal","RawManualTagEntryModal","RawCsvImportModal","RawCsvExportModal","RawBrowseModal","RawNameDialog","RawConfirmDialog","RawDriverTypeDialog","RawStubModal"};
ComponentFactories.AddStub(t=>names.Contains(t.Name));
_service=DispatchProxy.Create<IRawTreeService,CallerService>();Services.AddSingleton(_service);
}
private IRenderedComponent<RawTree> Tree()=>Render<RawTree>(p=>p.Add(x=>x.Roots,new[]{_a,_b,_driver}));
private static Task Open(IRenderedComponent<RawTree> tree,string method,RawNode node)=>tree.InvokeAsync(()=> (Task)typeof(RawTree).GetMethod(method,BindingFlags.Instance|BindingFlags.NonPublic)!.Invoke(tree.Instance,[node])!);
[Fact]
public async Task RetiredNameHandler_CannotRenameReplacementWithSameCaption()
{
var tree=Tree();await Open(tree,"OnRenameFolder",_a);var old=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);
await Open(tree,"OnRenameFolder",_b);await tree.InvokeAsync(()=>old.InvokeAsync("renamed"));Service.Renames.ShouldBeEmpty();
var current=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);await tree.InvokeAsync(()=>current.InvokeAsync("new-b"));Service.Renames.ShouldBe(new[]{"b"});
}
[Fact]
public async Task RetiredConfirmHandler_CannotDeleteReplacement()
{
var tree=Tree();await Open(tree,"OnDeleteFolder",_a);var old=tree.FindComponent<Stub<RawConfirmDialog>>().Instance.Parameters.Get(x=>x.OnConfirm);
await Open(tree,"OnDeleteFolder",_b);await tree.InvokeAsync(()=>old.InvokeAsync());Service.Deletes.ShouldBeEmpty();
}
[Fact]
public async Task RetiredDriverTypeHandler_CannotCreateUnderReplacementFolder()
{
var tree=Tree();await Open(tree,"OnNewDriver",_a);var old=tree.FindComponent<Stub<RawDriverTypeDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);
await Open(tree,"OnNewDriver",_b);await tree.InvokeAsync(()=>old.InvokeAsync(("Modbus","local")));Service.Creates.ShouldBeEmpty();
}
[Fact]
public async Task DispatchedRenameA_CannotPublishWarningOrCloseReplacementB()
{
var pending=new TaskCompletionSource<RawRenameResult>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Rename=_=>pending.Task;
var tree=Tree();await Open(tree,"OnRenameFolder",_a);var action=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);
var save=tree.InvokeAsync(()=>action.InvokeAsync("name-a"));tree.WaitForAssertion(()=>Service.Renames.ShouldBe(new[]{"a"}));
await Open(tree,"OnRenameFolder",_b);pending.SetResult(RawRenameResult.Success(new[]{"Warning for A only"}));await save;
tree.FindComponent<Stub<RawStubModal>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeFalse();tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeTrue();Service.Reads.ShouldBeEmpty();
}
[Fact]
public async Task RetiredCsvSavedHandler_CannotReloadCurrentTargetB()
{
var a=new RawNode{Kind=RawNodeKind.Device,Key="device:a",EntityId="device-a",DisplayName="A",DriverType="Modbus",HasLazyChildren=true,Loaded=true};var b=new RawNode{Kind=RawNodeKind.Device,Key="device:b",EntityId="device-b",DisplayName="B",DriverType="Modbus",HasLazyChildren=true,Loaded=true};
var tree=Tree();await Open(tree,"OnImportCsv",a);var old=tree.FindComponent<Stub<RawCsvImportModal>>().Instance.Parameters.Get(x=>x.OnSaved);
await Open(tree,"OnImportCsv",b);await tree.InvokeAsync(()=>old.InvokeAsync());Service.Reads.ShouldBeEmpty();
}
[Fact]
public async Task BlockedDelete_MessageWaitsForOriginatingConfirmationToHide()
{
Service.DeleteResult=new(false,"Synthetic referenced folder blocker");var tree=Tree();await Open(tree,"OnDeleteFolder",_a);
var confirm=tree.FindComponent<Stub<RawConfirmDialog>>().Instance.Parameters;
await tree.InvokeAsync(()=>confirm.Get(x=>x.OnConfirm).InvokeAsync());
tree.FindComponent<Stub<RawStubModal>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeFalse();
await tree.InvokeAsync(()=>confirm.Get(x=>x.VisibleChanged).InvokeAsync(false));
tree.WaitForAssertion(()=>tree.FindComponent<Stub<RawStubModal>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeTrue());
tree.FindComponent<Stub<RawStubModal>>().Instance.Parameters.Get(x=>x.Message).ShouldContain("referenced folder blocker");
}
[Fact]
public async Task IdenticalCreateCaptions_StillCarryDistinctPresentationTarget()
{
var tree=Tree();await Open(tree,"OnNewFolder",_a);var first=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.Target);
await Open(tree,"OnNewFolder",_b);var second=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.Target);
first.ShouldNotBeNull();second.ShouldNotBeNull();second.ShouldNotBe(first);
}
[Fact]
public async Task OldRefreshCompletion_CannotClearNewReadOrInstallOldChildren()
{
var node=new RawNode{Kind=RawNodeKind.Device,Key="device:shared",EntityId="shared",DisplayName="Shared device",DriverType="Modbus",HasLazyChildren=true,Loaded=true};
var first=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);
var second=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);
Service.Read=_=>Service.Reads.Count==1?first.Task:second.Task;
var tree=Tree();await Open(tree,"OnImportCsv",node);var a=tree.FindComponent<Stub<RawCsvImportModal>>().Instance.Parameters.Get(x=>x.OnSaved);
var readA=tree.InvokeAsync(()=>a.InvokeAsync());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(1));
await Open(tree,"OnAddManualTags",node);var b=tree.FindComponent<Stub<RawManualTagEntryModal>>().Instance.Parameters.Get(x=>x.OnSaved);
var readB=tree.InvokeAsync(()=>b.InvokeAsync());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(2));
first.SetResult([new(){Kind=RawNodeKind.Tag,Key="old",DisplayName="Old result"}]);await readA;
node.Loading.ShouldBeTrue();node.Children.ShouldBeEmpty();
second.SetResult([new(){Kind=RawNodeKind.Tag,Key="new",DisplayName="New result"}]);await readB;
node.Loading.ShouldBeFalse();node.Children.ShouldHaveSingleItem().Key.ShouldBe("new");
}
[Fact]
public async Task HiddenOrigin_CannotPublishALateFailureMessage()
{
var pending=new TaskCompletionSource<RawRenameResult>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Rename=_=>pending.Task;
var tree=Tree();await Open(tree,"OnRenameFolder",_a);var parameters=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters;
var operation=tree.InvokeAsync(()=>parameters.Get(x=>x.OnSubmit).InvokeAsync("new-a"));tree.WaitForAssertion(()=>Service.Renames.Count.ShouldBe(1));
await tree.InvokeAsync(()=>parameters.Get(x=>x.VisibleChanged).InvokeAsync(false));
pending.SetResult(RawRenameResult.Failure("Late failure for hidden A"));await operation;
tree.FindComponent<Stub<RawStubModal>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeFalse();
}
[Fact]
public async Task RetiredRefresh_KeepsLastLoadedChildrenInsteadOfLeavingAFalseEmptyBranch()
{
var node=new RawNode{Kind=RawNodeKind.Device,Key="device:a",EntityId="a",DisplayName="A",DriverType="Modbus",HasLazyChildren=true,Loaded=true};
node.Children.Add(new(){Kind=RawNodeKind.Tag,Key="last-good",DisplayName="Last loaded tag"});
var other=new RawNode{Kind=RawNodeKind.Device,Key="device:b",EntityId="b",DisplayName="B",DriverType="Modbus",HasLazyChildren=true,Loaded=true};
var pending=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Read=_=>pending.Task;
var tree=Tree();await Open(tree,"OnImportCsv",node);var saved=tree.FindComponent<Stub<RawCsvImportModal>>().Instance.Parameters.Get(x=>x.OnSaved);
var read=tree.InvokeAsync(()=>saved.InvokeAsync());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(1));
await Open(tree,"OnImportCsv",other);pending.SetResult([new(){Kind=RawNodeKind.Tag,Key="retired-result",DisplayName="Retired result"}]);await read;
node.Children.ShouldHaveSingleItem().Key.ShouldBe("last-good");node.Loading.ShouldBeFalse();node.Loaded.ShouldBeFalse();
}
[Fact]
public async Task RetiredRenameException_CannotFaultReplacementB()
{
var pending=new TaskCompletionSource<RawRenameResult>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Rename=_=>pending.Task;
var tree=Tree();await Open(tree,"OnRenameFolder",_a);var action=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);
var operation=tree.InvokeAsync(()=>action.InvokeAsync("a"));tree.WaitForAssertion(()=>Service.Renames.Count.ShouldBe(1));await Open(tree,"OnRenameFolder",_b);
pending.SetException(new IOException("Retired A exception"));await operation;
tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeTrue();
}
[Fact]
public async Task DirectToggleException_AfterAnotherDialogOpensCannotFaultThatDialog()
{
var pending=new TaskCompletionSource<UnsMutationResult>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Toggle=_=>pending.Task;
var tree=Tree();var operation=Open(tree,"OnToggleDriverEnabled",_driver);tree.WaitForAssertion(()=>Service.Toggles.Count.ShouldBe(1));
await Open(tree,"OnRenameFolder",_b);pending.SetException(new IOException("Retired direct operation"));await operation;
tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.Visible).ShouldBeTrue();
}
[Fact]
public async Task CurrentDirectToggleException_StillPropagatesToExistingBoundary()
{
Service.Toggle=_=>Task.FromException<UnsMutationResult>(new IOException("Current failure"));var tree=Tree();
await Should.ThrowAsync<IOException>(()=>Open(tree,"OnToggleDriverEnabled",_driver));
}
[Theory]
[InlineData(false,false)]
[InlineData(false,true)]
[InlineData(true,false)]
[InlineData(true,true)]
public async Task InitialExpansion_AndSavedReloadShareReadOwnership(bool initialFirst,bool initialFails)
{
var node=new RawNode{Kind=RawNodeKind.Folder,Key="read-folder",EntityId="read-folder",ClusterId="cluster",DisplayName="Read folder",HasLazyChildren=true};
var initial=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);var refreshed=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);
Service.Read=_=>Service.Reads.Count==1?initial.Task:refreshed.Task;
var tree=Render<RawTree>(p=>p.Add(x=>x.Roots,new[]{node}));
var expanding=tree.Find("button[aria-label='Expand Read folder']").ClickAsync(new());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(1));
await Open(tree,"OnNewFolder",node);var callback=tree.FindComponent<Stub<RawNameDialog>>().Instance.Parameters.Get(x=>x.OnSubmit);
var saving=tree.InvokeAsync(()=>callback.InvokeAsync("new-child"));tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(2));
void FinishInitial(){if(initialFails)initial.SetException(new IOException("Retired initial read"));else initial.SetResult([new(){Kind=RawNodeKind.Tag,Key="old-child",DisplayName="Old child"}]);}
if(initialFirst)
{
FinishInitial();await expanding;node.Loading.ShouldBeTrue();node.Children.ShouldBeEmpty();node.Error.ShouldBeNull();
refreshed.SetResult([new(){Kind=RawNodeKind.Tag,Key="fresh-child",DisplayName="Fresh child"}]);await saving;
}
else
{
refreshed.SetResult([new(){Kind=RawNodeKind.Tag,Key="fresh-child",DisplayName="Fresh child"}]);await saving;FinishInitial();await expanding;
}
node.Children.ShouldHaveSingleItem().Key.ShouldBe("fresh-child");node.Error.ShouldBeNull();node.Loading.ShouldBeFalse();node.Loaded.ShouldBeTrue();
}
[Fact]
public async Task OpeningDialogAlone_DoesNotInvalidateAnOrdinaryExpansion()
{
var node=new RawNode{Kind=RawNodeKind.Folder,Key="ordinary",EntityId="ordinary",ClusterId="cluster",DisplayName="Ordinary",HasLazyChildren=true};
var pending=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Read=_=>pending.Task;
var tree=Render<RawTree>(p=>p.Add(x=>x.Roots,new[]{node}));var expanding=tree.Find("button[aria-label='Expand Ordinary']").ClickAsync(new());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(1));
await Open(tree,"OnNewFolder",node);pending.SetResult([new(){Kind=RawNodeKind.Tag,Key="ordinary-child",DisplayName="Ordinary child"}]);await expanding;
node.Children.ShouldHaveSingleItem().Key.ShouldBe("ordinary-child");node.Loaded.ShouldBeTrue();
}
[Fact]
public async Task DisposedExpansion_CannotInstallLateChildren()
{
var node=new RawNode{Kind=RawNodeKind.Folder,Key="disposed",EntityId="disposed",DisplayName="Disposed",HasLazyChildren=true};
var pending=new TaskCompletionSource<IReadOnlyList<RawNode>>(TaskCreationOptions.RunContinuationsAsynchronously);Service.Read=_=>pending.Task;
var tree=Render<RawTree>(p=>p.Add(x=>x.Roots,new[]{node}));var expanding=tree.Find("button[aria-label='Expand Disposed']").ClickAsync(new());tree.WaitForAssertion(()=>Service.Reads.Count.ShouldBe(1));
await tree.InvokeAsync(()=>tree.Instance.DisposeAsync().AsTask());pending.SetResult([new(){Kind=RawNodeKind.Tag,Key="late",DisplayName="Late"}]);await expanding;
node.Children.ShouldBeEmpty();node.Loaded.ShouldBeFalse();node.Loading.ShouldBeFalse();
}
public class CallerService:DispatchProxy
{
public UnsMutationResult DeleteResult=new(true,null);public List<string> Renames=[],Deletes=[],Creates=[],Reads=[],Toggles=[];public Func<string,Task<RawRenameResult>>? Rename;public Func<RawNode,Task<IReadOnlyList<RawNode>>>? Read;public Func<string,Task<UnsMutationResult>>? Toggle;
protected override object? Invoke(MethodInfo? m,object?[]? a)
{
switch(m?.Name)
{
case "SetDriverEnabledAsync":var toggleId=(string)a![0]!;Toggles.Add(toggleId);return Toggle?.Invoke(toggleId)??Task.FromResult(new UnsMutationResult(true,null));
case "RenameFolderAsync":var id=(string)a![0]!;Renames.Add(id);return Rename?.Invoke(id)??Task.FromResult(RawRenameResult.Success());
case "DeleteFolderAsync":Deletes.Add((string)a![0]!);return Task.FromResult(DeleteResult);
case "CreateFolderAsync":Creates.Add((string)a![1]!);return Task.FromResult(new UnsMutationResult(true,null));
case "CreateDriverAsync":Creates.Add((string)a![1]!);return Task.FromResult(new UnsMutationResult(true,null));
case "LoadChildrenAsync":var node=(RawNode)a![0]!;Reads.Add(node.EntityId??"root");return Read?.Invoke(node)??Task.FromResult<IReadOnlyList<RawNode>>([]);
default:throw new InvalidOperationException("Unexpected caller operation: "+m?.Name);
}
}
}
}