feat(historian): honor per-alarm HistorizeToAveva opt-out at the durable write

2026-06-11 12:48:13 -04:00
parent fa839d1dbf
commit 8012509584
6 changed files with 78 additions and 9 deletions
@@ -71,7 +71,13 @@ public sealed class HistorianAdapterActor : ReceiveActor
        // ShouldHistorize gate keeps only the Primary writing ⇒ exactly-once across the warm pair.
        // NOTE: Translate is intentionally inside the gate so Secondary/Detached nodes never allocate a
        // discarded AlarmHistorianEvent.
-        Receive<AlarmTransitionEvent>(t => { if (ShouldHistorize()) _ = EnqueueAsync(Translate(t)); });
+        // t.HistorizeToAveva=false is a per-alarm opt-out of DURABLE historization only — the live `alerts`
+        // fan-out already happened upstream (the publish is NOT gated on this flag), so we gate the SINK
+        // write here, not the publish. Rolling-restart-safe: the node that WRITES is always the same-version
+        // node that PUBLISHED (Primary or boot window), so a cross-version old→new flow only reaches the
+        // Secondary, which never writes — an old-format message deserializing HistorizeToAveva as the CLR
+        // default (false) cannot drop a Primary's historization.
+        Receive<AlarmTransitionEvent>(t => { if (ShouldHistorize() && t.HistorizeToAveva) _ = EnqueueAsync(Translate(t)); });

        Receive<GetStatus>(_ => Sender.Tell(_sink.GetStatus()));

@@ -298,7 +298,10 @@ public sealed class ScriptedAlarmHostActor : ReceiveActor
            // Historian feed prep: carry the Part-9 subtype name (e.Kind.ToString() yields
            // LimitAlarm/DiscreteAlarm/OffNormalAlarm/AlarmCondition) + any operator comment.
            AlarmTypeName: e.Kind.ToString(),
-            Comment: e.Comment);
+            Comment: e.Comment,
+            // Per-alarm DURABLE-historization opt-out — honored downstream by HistorianAdapterActor to
+            // suppress only the sink write. This publish (and the live `/alerts` fan-out) is NOT gated on it.
+            HistorizeToAveva: e.HistorizeToAveva);

        // Warm-standby dedup: only the Primary (driver-role leader) publishes the cluster-wide
        // transition. Default-emit until told we are Secondary/Detached so single-node deploys + the