dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs(galaxy): neutralize remaining stale SystemPlatform/alias terminology in comments + a test name

Browse Source 
Replace "SystemPlatform mirror tag", "Galaxy alias", and "SystemPlatform-kind" in doc-comments and
test names with neutral accurate wording ("FolderPath-scoped tag", "EquipmentId == null", etc.).
No code, logic, or test bodies changed — comments and one test method name only.
This commit is contained in:
Joseph Doherty
2026-06-12 22:30:50 -04:00
parent ba42bed538
commit 7d25480fee
8 changed files with 33 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/ScriptAnalysis/ScriptTagCatalogTests.cs
+9 -9
View File
@@ -42,7 +42,7 @@ public sealed class ScriptTagCatalogTests
/// <summary>
/// Seeds an Area → Line → Equipment path with: one equipment driver tag (FullName "Motor.Speed"),
/// one virtual tag, and one SystemPlatform tag (EquipmentId null, FolderPath set).
/// one virtual tag, and one FolderPath-scoped tag (EquipmentId null, FolderPath set).
/// </summary>
private static void Seed(DbContextOptions<OtOpcUaConfigDbContext> opts)
{
@@ -71,7 +71,7 @@ public sealed class ScriptTagCatalogTests
TagConfig = "{\"FullName\":\"Motor.Speed\"}",
});
// SystemPlatform tag — EquipmentId null, FolderPath set; Galaxy subscribes by "FolderPath.Name".
// FolderPath-scoped tag — EquipmentId null, FolderPath set; subscribes by "FolderPath.Name".
db.Tags.Add(new Tag
{
TagId = "TAG-SP",
@@ -97,7 +97,7 @@ public sealed class ScriptTagCatalogTests
}
/// <summary>A null filter returns only the resolvable keys: the driver FullName for the equipment
/// tag, the MXAccess dot-ref for the SystemPlatform tag, and the virtual tag's leaf Name — and
/// tag, the MXAccess dot-ref for the FolderPath-scoped tag, and the virtual tag's leaf Name — and
/// NONE of the UNS browse paths.</summary>
[Fact]
public async Task GetPaths_no_filter_returns_resolvable_keys_only()
@@ -110,7 +110,7 @@ public sealed class ScriptTagCatalogTests
// Equipment driver tag: the authoritative GetTag key (driver FullName).
paths.ShouldContain("Motor.Speed");
// SystemPlatform tag: MXAccess dot-ref.
// FolderPath-scoped tag: MXAccess dot-ref.
paths.ShouldContain("DelmiaReceiver_001.DownloadPath");
// Virtual tag: leaf Name only.
@@ -193,10 +193,10 @@ public sealed class ScriptTagCatalogTests
paths.ShouldContain("Computed");
}
/// <summary>A SystemPlatform tag with a null/empty <c>FolderPath</c> yields just its <c>Name</c>
/// <summary>A FolderPath-scoped tag with a null/empty <c>FolderPath</c> yields just its <c>Name</c>
/// (no leading dot).</summary>
[Fact]
public async Task GetPaths_systemplatform_tag_without_folder_yields_name_only()
public async Task GetPaths_unbound_tag_without_folder_yields_name_only()
{
var (catalog, opts) = Fresh();
@@ -233,10 +233,10 @@ public sealed class ScriptTagCatalogTests
paths.ShouldBeEmpty();
}
/// <summary>A SystemPlatform tag resolves by its "FolderPath.Name" dot-ref to a Tag-kind info with
/// the configured DataType + DriverInstanceId.</summary>
/// <summary>A FolderPath-scoped tag resolves by its "FolderPath.Name" dot-ref to a Tag-kind info
/// with the configured DataType + DriverInstanceId.</summary>
[Fact]
public async Task GetTagInfo_systemplatform_tag_returns_tag_info()
public async Task GetTagInfo_unbound_tag_returns_tag_info()
{
var (catalog, opts) = Fresh();
Seed(opts);
tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.Tests/Phase7ComposerAliasTagTests.cs
+5 -7
View File
@@ -7,19 +7,17 @@ namespace ZB.MOM.WW.OtOpcUa.OpcUaServer.Tests;
/// <summary>
/// Verifies the live-edit compose seam (<see cref="Phase7Composer.Compose"/>) treats a Galaxy
/// point as an ordinary equipment tag now that <c>GalaxyMxGateway</c> is a standard
/// Equipment-kind driver. An equipment-scoped <see cref="Tag"/> (non-null
/// <see cref="Tag.EquipmentId"/>) bound to a <c>GalaxyMxGateway</c> driver living in an
/// <c>Equipment</c>-kind namespace must surface under
/// <see cref="Phase7CompositionResult.EquipmentTags"/> (carrying its driver-side FullName). The
/// SystemPlatform-mirror <c>GalaxyTags</c> contract is retired entirely.
/// point as an ordinary equipment tag: <c>GalaxyMxGateway</c> is a standard Equipment-kind driver.
/// An equipment-scoped <see cref="Tag"/> (non-null <see cref="Tag.EquipmentId"/>) bound to a
/// <c>GalaxyMxGateway</c> driver living in an <c>Equipment</c>-kind namespace must surface under
/// <see cref="Phase7CompositionResult.EquipmentTags"/> (carrying its driver-side FullName).
/// </summary>
public sealed class Phase7ComposerAliasTagTests
{
/// <summary>A <c>GalaxyMxGateway</c> driver in an Equipment-kind namespace carries an
/// equipment-scoped Galaxy tag (EquipmentId set, FolderPath null, TagConfig FullName = the Galaxy
/// ref). Compose must put it in EquipmentTags with its FullName, coalescing the null FolderPath to
/// <c>string.Empty</c> (the SystemPlatform mirror producer is gone entirely).</summary>
/// <c>string.Empty</c>.</summary>
[Fact]
public void Compose_admits_galaxy_equipment_tag_in_equipment_tags()
{