From 70e1bde90f3492d5323e86cb020a1a9f9f5dfda9 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Thu, 18 Jun 2026 02:54:20 -0400 Subject: [PATCH] chore(plan): mark script-editor ctx-completion tasks complete + live results --- ...06-18-script-editor-ctx-completions.md.tasks.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/plans/2026-06-18-script-editor-ctx-completions.md.tasks.json b/docs/plans/2026-06-18-script-editor-ctx-completions.md.tasks.json index 04bf5e6e..b48083f9 100644 --- a/docs/plans/2026-06-18-script-editor-ctx-completions.md.tasks.json +++ b/docs/plans/2026-06-18-script-editor-ctx-completions.md.tasks.json @@ -4,11 +4,17 @@ "designCommit": "e84f7a6e", "baseMaster": "651018f9", "branch": "feat/script-editor-ctx-completions", - "scope": "AdminUI-only ScriptAnalysis fix. Component 1: ctx-receiver guard in ScriptAnalysisService.TryGetTagPathLiteral (mirror the runtime EquipmentScriptPaths.GetTagRefRegex `ctx`-anchor) so tag-path completion/hover fires only on ctx.GetTag/ctx.SetVirtualTag, not an unrelated x.GetTag(...). Component 2: surface which method matched; Hover appends a truthful note that ctx.SetVirtualTag cross-tag writes are dropped in single-tag mode (RoslynVirtualTagEvaluator drops them; cascade VirtualTagEngine dormant). The 'authoritative write-key' goal is dropped as moot. NO runtime/Commons/proto/EF change; NO bUnit.", + "scope": "AdminUI-only ScriptAnalysis fix. Component 1: ctx-receiver guard in ScriptAnalysisService.TryGetTagPathLiteral (mirror the runtime EquipmentScriptPaths.GetTagRefRegex `ctx`-anchor) so tag-path completion/hover fires only on ctx.GetTag/ctx.SetVirtualTag, not an unrelated x.GetTag(...). Component 2: surface which method matched; Hover appends a truthful note that ctx.SetVirtualTag cross-tag writes are dropped in single-tag mode (RoslynVirtualTagEvaluator drops them; cascade VirtualTagEngine dormant). The 'authoritative write-key' goal dropped as moot. NO runtime/Commons/proto/EF change; NO bUnit.", "dependencyGraph": "T1 -> T2", "tasks": [ - {"id": 1, "nativeId": 532, "subject": "ctx-receiver guard + truthful SetVirtualTag hover", "classification": "small", "status": "pending"}, - {"id": 2, "nativeId": 533, "subject": "Docs + build/test + live /run + finish", "classification": "small", "status": "pending", "blockedBy": [1]} + {"id": 1, "nativeId": 532, "subject": "ctx-receiver guard + truthful SetVirtualTag hover", "classification": "small", "status": "completed", "commit": "ac3450d5", "review": "code-review APPROVE WITH MINOR (haiku). The lone minor (negatives could pass spuriously) is mitigated by the differential design — 'Line1.Speed'/'Tag path' are catalog-only sentinels that can only come from the now-guarded branch, and tests form positive/negative pairs differing only in receiver/method. Purely syntactic guard (IdentifierNameSyntax ValueText==ctx); both call sites updated; hover note appended only for SetVirtualTag. 5 new tests; full AdminUI suite 477/477."}, + {"id": 2, "nativeId": 533, "subject": "Docs + build/test + live /run + finish", "classification": "small", "status": "completed", "commit": "6f9e9c5c", "review": "docs(ScriptEditor.md): rewrote the now-stale 'Literal gate' paragraph (it called the method-name-only match 'harmless') to describe the ctx-receiver guard + the SetVirtualTag single-tag-drop hover note; no overclaim (cascade-engine wiring stated out of scope). Build 0 errors (359 pre-existing warnings); AdminUI 477/477.", + "live": "LIVE /run PASS (docker-dev, login-disabled, both central nodes rebuilt from branch). Drove the real /api/script-analysis/{completions,hover} endpoints against the live DB catalog: ctx.GetTag(\"cy\") x6 -> tag-path completion every time; foo.GetTag(\"cy\") x6 -> 0 tag-path (receiver guard) every time; foo.SetVirtualTag hover -> null (guard); ctx.SetVirtualTag hover -> the single-tag-drop note. KEY live-debug learning: an initial flicker (non-ctx receivers alternating 1/0) was root-caused to an INCOMPLETE DEPLOYMENT, not a code defect — Traefik round-robins :9200 across BOTH central-1 AND central-2, and only central-1 had been rebuilt; central-2 still ran the pre-branch code (no guard). After rebuilding central-2 too, the guard is deterministic on every request. Both nodes started healthy (0 exceptions, applied plan added=91 rebuild=True, full materialisation)."} + ], + "executionState": "COMPLETE — merged to master + pushed. ctx-receiver guard + truthful SetVirtualTag hover in the script-editor completions. Build 0 errors; AdminUI 477/477; live /run PASS on docker-dev. NO runtime/Commons/proto/EF change; NO bUnit.", + "reviewFollowUps": [ + "Pre-existing position-boundary fragility (NOT introduced by this change): for a DEGENERATE caret at the closing quote of an EMPTY string literal (e.g. ctx.GetTag(\"\") with the caret on the closing quote), the completion gate's FindToken can land inconsistently. Realistic carets (on content / just after the open quote) are deterministic and obey the guard. Orthogonal to the receiver guard; low value to chase.", + "Live-rig deployment note: docker-dev :9200 is Traefik-load-balanced across central-1 AND central-2 — an AdminUI live-verify must rebuild BOTH central nodes (or hit a node directly) or requests round-robin between old and new code. Recorded so future AdminUI live-verifies don't repeat the half-deployed flicker." ], "lastUpdated": "2026-06-18" }