fix(opcuaserver): chunked, per-item-isolated WriteValues with typed partial-failure outcome

2026-08-15 12:32:44 -04:00
parent 8ef02506f7
commit 6bf1fb3754
7 changed files with 468 additions and 82 deletions
@@ -339,7 +339,12 @@ public sealed class OpcUaPublishActor : ReceiveActor, IWithTimers
    /// <summary>Mirrors <see cref="HandleAttributeUpdate"/> for a whole burst: ONE
    /// <see cref="IOpcUaAddressSpaceSink.WriteValues"/> call, but the write tally and the
    /// <c>otopcua.opcua.sink.write</c> meter still advance PER ITEM — batching is a transport change, so
-    /// dashboards must not drop by the batch factor.</summary>
+    /// dashboards must not drop by the batch factor.
+    /// <para>A <see cref="ValueWriteBatchException"/> is a PARTIAL failure: the sink applied every item it
+    /// could and is telling us which one it couldn't. So it is caught ahead of the general catch to (a) name
+    /// the offending node in the log — a bare "the batch threw" cannot be acted on — and (b) still count the
+    /// items that DID land, keeping the per-item counting invariant honest instead of silently under-reporting
+    /// a whole batch because one item was bad.</para></summary>
    private void HandleAttributeBatchUpdate(AttributeValueBatchUpdate msg)
    {
        try
@@ -348,6 +353,15 @@ public sealed class OpcUaPublishActor : ReceiveActor, IWithTimers
            Interlocked.Add(ref _writes, msg.Items.Count);
            OtOpcUaTelemetry.OpcUaSinkWrite.Add(msg.Items.Count, new KeyValuePair<string, object?>("kind", "value"));
        }
+        catch (ValueWriteBatchException ex)
+        {
+            _log.Warning(ex,
+                "OpcUaPublish: sink.WriteValues partially failed for a {Count}-item batch — {Failed} failed " +
+                "(first: {Node}), {Succeeded} applied",
+                msg.Items.Count, ex.FailedCount, ex.FirstFailedNodeId, ex.SucceededCount);
+            Interlocked.Add(ref _writes, ex.SucceededCount);
+            OtOpcUaTelemetry.OpcUaSinkWrite.Add(ex.SucceededCount, new KeyValuePair<string, object?>("kind", "value"));
+        }
        catch (Exception ex)
        {
            _log.Warning(ex, "OpcUaPublish: sink.WriteValues threw for a {Count}-item batch", msg.Items.Count);