From 68637396b57f99e51b57a5cebec1a6dfa7eaa5a6 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Thu, 18 Jun 2026 06:11:31 -0400 Subject: [PATCH] =?UTF-8?q?docs(abstractions):=20correct=20ReadEventsAsync?= =?UTF-8?q?=20remark=20=E2=80=94=20OpcUaClient=20now=20overrides?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code-review minor: the DIM remark said the OPC UA Client driver stays with the default; it now overrides (forwards HistoryReadEvents upstream). Comment-only — no contract/signature change. The session-capture-before-gate race the review also noted is a pre-existing ExecuteHistoryReadAsync pattern (shared by raw/processed/attime); ReadEventsAsync intentionally mirrors it — tracked as a follow-up to fix all four history paths together. --- .../IHistoryProvider.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Core/ZB.MOM.WW.OtOpcUa.Core.Abstractions/IHistoryProvider.cs b/src/Core/ZB.MOM.WW.OtOpcUa.Core.Abstractions/IHistoryProvider.cs index 70e089bd..6a337153 100644 --- a/src/Core/ZB.MOM.WW.OtOpcUa.Core.Abstractions/IHistoryProvider.cs +++ b/src/Core/ZB.MOM.WW.OtOpcUa.Core.Abstractions/IHistoryProvider.cs @@ -95,9 +95,10 @@ public interface IHistoryProvider /// /// Request cancellation. /// - /// Default implementation throws. Only drivers with an event historian (Galaxy via the - /// Wonderware Alarm & Events log) override. Modbus / the OPC UA Client driver stay - /// with the default and let callers see BadHistoryOperationUnsupported. + /// Default implementation throws. Drivers whose backend can serve historical events + /// override: Galaxy (Wonderware Alarm & Events log) and the OPC UA Client driver + /// (forwarding HistoryReadEvents to its upstream server). Raw-only drivers such as Modbus + /// stay with the default and let callers see BadHistoryOperationUnsupported. /// /// Note the type asymmetry with / /// (both use uint maxValuesPerNode): event