fix(runtime): a stopping driver child announces comms loss so restart/respawn latches its nodes Bad

2026-08-20 11:07:02 -04:00
parent 1d251cc037
commit 62c5bc3aad
4 changed files with 98 additions and 1 deletions
@@ -374,4 +374,54 @@ public sealed class DriverInstanceActorTests : RuntimeActorTestBase
        AwaitCondition(() => driver.SubscribeCount >= 1, TimeSpan.FromSeconds(3));
    }

+    /// <summary>
+    ///     Archreview <b>03/S15 (T11)</b> — a child that is <b>stopped</b> announces comms loss on its way
+    ///     out, so the host latches its value nodes <c>BadNoCommunication</c>.
+    ///     <para>Every other route into <c>Reconnecting</c> announces it (watchdog trip, failed initial
+    ///     connect, Force Reconnect all run the <c>Reconnecting</c> entry). Stopping did not: an operator's
+    ///     Restart and a supervision respawn tore the child down silently, so its nodes kept serving their
+    ///     last value at Good across the gap. The fresh child's re-subscribe + initial push (03/S16) is what
+    ///     clears them again.</para>
+    /// </summary>
+    [Fact]
+    public void Stopping_a_connected_child_announces_comms_loss_to_its_parent()
+    {
+        var parent = CreateTestProbe();
+        var driver = new StubDriver();
+        var actor = parent.ChildActorOf(DriverInstanceActor.Props(driver));
+
+        actor.Tell(new DriverInstanceActor.InitializeRequested("{}"));
+        parent.ExpectMsg<DriverInstanceActor.ConnectivityChanged>(PresenceBudget).Connected.ShouldBeTrue();
+
+        parent.Watch(actor);
+        parent.Send(actor, PoisonPill.Instance);
+
+        parent.ExpectMsg<DriverInstanceActor.ConnectivityChanged>(PresenceBudget).Connected.ShouldBeFalse();
+        parent.ExpectTerminated(actor, PresenceBudget);
+    }
+
+    /// <summary>
+    ///     <b>Control.</b> A child that never reached <c>Connected</c> announces nothing when stopped — its
+    ///     nodes are still <c>BadWaitingForInitialData</c>, which is a more precise statement than
+    ///     "communication lost", and overwriting it would claim an outage that never happened.
+    /// </summary>
+    [Fact]
+    public void Stopping_a_never_connected_child_announces_nothing()
+    {
+        var parent = CreateTestProbe();
+        var driver = new StubDriver { InitializeShouldThrow = true };
+        var actor = parent.ChildActorOf(DriverInstanceActor.Props(
+            driver, reconnectInterval: TimeSpan.FromSeconds(30)));
+
+        actor.Tell(new DriverInstanceActor.InitializeRequested("{}"));
+        // The failed initial connect announces Connected=false from the Reconnecting entry; consume it, so
+        // what follows is only what STOPPING produced.
+        parent.ExpectMsg<DriverInstanceActor.ConnectivityChanged>(PresenceBudget).Connected.ShouldBeFalse();
+
+        parent.Watch(actor);
+        parent.Send(actor, PoisonPill.Instance);
+
+        parent.ExpectTerminated(actor, PresenceBudget);
+        parent.ExpectNoMsg(TimeSpan.FromMilliseconds(300));
+    }
 }