fix(probe): bound AbLegacy handshake by timeout CTS + stop sw; correct FOCAS timeout comment (code-review)

2026-06-16 07:03:55 -04:00
parent 9bfbbb0fd8
commit 5df3c73204
2 changed files with 13 additions and 3 deletions
@@ -114,7 +114,9 @@ public sealed class FocasDriverProbe : IDriverProbe
        }
        catch (OperationCanceledException)
        {
-            // ct cancelled or the native handshake exceeded the timeout budget.
+            // The caller cancelled, or the Task.Run was cancelled before the native call started.
+            // (A native cnc_allclibhndl3 that is already running is bounded by the timeoutSeconds
+            // argument passed into it, not by handshakeCts — see TryAllocateAndFreeHandle.)
            return new(false, $"Probe timed out after {timeout.TotalSeconds:F0}s.", null);
        }
    }