fix(abcip): ALMA review round 2 - IsRestatement contract docs, ALMD no-InAlarm warning, un-ack retrigger

Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
2026-10-09 04:30:56 -04:00
parent 83d8de303c
commit 5d7c53bb19
8 changed files with 105 additions and 10 deletions
@@ -52,8 +52,10 @@ public sealed class NativeAlarmProjector
    ///         <item>Gitea #656 — a <see cref="AlarmEventArgs.IsRestatement"/> event (a source re-stating upstream's
    ///         current state: a reconnect snapshot, first sight after a respawn) writes no row when it changes nothing
    ///         the condition shows: a Retrigger on an Active+unacked condition with the same message AND severity, or
-    ///         a Clear on an already-inactive condition. Unflagged sources (FOCAS, MTConnect, AbCip, live Galaxy
-    ///         transitions) are unaffected — a live Retrigger is a genuine re-occurrence and keeps its row.</item>
+    ///         a Clear on an already-inactive condition; and a flagged Unspecified update of an already-active
+    ///         condition moves its message/severity (node + one condition event) with active/acked kept and no row
+    ///         (AbCip ALMA's governing-limit change). Unflagged sources (FOCAS, MTConnect, live Galaxy transitions) are
+    ///         unaffected — a live Retrigger is a genuine re-occurrence and keeps its row.</item>
    ///     </list>
    /// </summary>
    /// <param name="nodeId">The materialised condition node's id (the projection's state key).</param>
@@ -110,6 +112,9 @@ public sealed class NativeAlarmProjector
                break;
            // A message/severity-only update of an ALREADY-ACTIVE condition that the source flags as a re-statement
            // (AbCip ALMA: the governing limit changed but no new occurrence started, e.g. HH dropped back to H).
+            // OpcUaClient can reach it too: first sight after a respawn of an upstream-inactive condition is told
+            // Unspecified+flagged; with the host still Active the node stays Active exactly as before (a pre-existing
+            // gap) and the false "Activated" row it used to write is now gone.
            // The node's text/severity move; active/acked are kept; NO row (an "Activated" row would be false).
            case AlarmTransitionKind.Unspecified when e.IsRestatement && prev.Active:
                (active, acked, historyKinds) = (true, prev.Acked, []);