dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(client-ui): resolve Medium code-review finding (Client.UI-002)

Browse Source 
Guard the two nullable child VM dereferences (BrowseTree at ConnectAsync
and History at ViewHistoryForSelectedNode) with != null checks, matching
the guarding style already used for Subscriptions and Alarms nearby.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-05-22 07:25:47 -04:00
parent 2816c76c2b
commit 55c2a5a209
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Client/ZB.MOM.WW.OtOpcUa.Client.UI/ViewModels/MainWindowViewModel.cs
View File

@@ -252,7 +252,7 @@ public partial class MainWindowViewModel : ObservableObject
} }
// Load root nodes // Load root nodes
await BrowseTree.LoadRootsAsync(); if (BrowseTree != null) await BrowseTree.LoadRootsAsync();
// Restore saved subscriptions // Restore saved subscriptions
if (_savedSubscribedNodes.Count > 0 && Subscriptions != null) if (_savedSubscribedNodes.Count > 0 && Subscriptions != null)
@@ -330,7 +330,7 @@ public partial class MainWindowViewModel : ObservableObject
if (SelectedTreeNodes.Count == 0 || !IsConnected) return; if (SelectedTreeNodes.Count == 0 || !IsConnected) return;
var node = SelectedTreeNodes[0]; var node = SelectedTreeNodes[0];
History.SelectedNodeId = node.NodeId; if (History != null) History.SelectedNodeId = node.NodeId;
SelectedTabIndex = 3; // History tab SelectedTabIndex = 3; // History tab
} }