From 5310a7e07a8b619f9c7d81da6d2ed35f80406d73 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Tue, 13 Oct 2026 16:12:31 -0400 Subject: [PATCH] Discard asserted probe-task return values without joining loops --- .../AbCipReinitializeReleasesStateTests.cs | 2 +- .../AbLegacyReinitializeReleasesStateTests.cs | 2 +- .../FocasReinitializeReleasesStateTests.cs | 4 ++-- .../TwinCATReinitializeReleasesStateTests.cs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbCip.Tests/AbCipReinitializeReleasesStateTests.cs b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbCip.Tests/AbCipReinitializeReleasesStateTests.cs index ebee2056..ce3b02f4 100644 --- a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbCip.Tests/AbCipReinitializeReleasesStateTests.cs +++ b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbCip.Tests/AbCipReinitializeReleasesStateTests.cs @@ -39,7 +39,7 @@ public sealed class AbCipReinitializeReleasesStateTests } var firstTag = factory.Tags["@raw_cpu_type"]; var firstLoop = first.ProbeTask; - firstLoop.ShouldNotBeNull(); + _ = firstLoop.ShouldNotBeNull(); firstLoop!.IsCompleted.ShouldBeFalse(); firstTag.Disposed.ShouldBeFalse(); diff --git a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests/AbLegacyReinitializeReleasesStateTests.cs b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests/AbLegacyReinitializeReleasesStateTests.cs index 85f3d1b5..50e01bdc 100644 --- a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests/AbLegacyReinitializeReleasesStateTests.cs +++ b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.Tests/AbLegacyReinitializeReleasesStateTests.cs @@ -35,7 +35,7 @@ public sealed class AbLegacyReinitializeReleasesStateTests } var firstTag = factory.Tags["S:0"]; var firstLoop = first.ProbeTask; - firstLoop.ShouldNotBeNull(); + _ = firstLoop.ShouldNotBeNull(); firstLoop!.IsCompleted.ShouldBeFalse(); firstTag.Disposed.ShouldBeFalse(); diff --git a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests/FocasReinitializeReleasesStateTests.cs b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests/FocasReinitializeReleasesStateTests.cs index e1687105..e1f3cf31 100644 --- a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests/FocasReinitializeReleasesStateTests.cs +++ b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests/FocasReinitializeReleasesStateTests.cs @@ -31,7 +31,7 @@ public sealed class FocasReinitializeReleasesStateTests // Positive control: the first state's probe loop is demonstrably running and holds a live client. await WaitUntilAsync(() => factory.Clients.Count > 0 && factory.Clients[0].IsConnected); var firstLoop = first.ProbeTask; - firstLoop.ShouldNotBeNull(); + _ = firstLoop.ShouldNotBeNull(); firstLoop!.IsCompleted.ShouldBeFalse(); var firstClient = factory.Clients[0]; @@ -41,7 +41,7 @@ public sealed class FocasReinitializeReleasesStateTests firstClient.DisposeCount.ShouldBeGreaterThanOrEqualTo(1); firstClient.IsConnected.ShouldBeFalse(); drv.GetDeviceState(host).ShouldNotBeSameAs(first); - drv.GetDeviceState(host)!.ProbeTask.ShouldNotBeNull(); // the new state is running + _ = drv.GetDeviceState(host)!.ProbeTask.ShouldNotBeNull(); // the new state is running await drv.ShutdownAsync(CancellationToken.None); } diff --git a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests/TwinCATReinitializeReleasesStateTests.cs b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests/TwinCATReinitializeReleasesStateTests.cs index 8ef5f9eb..d41513c5 100644 --- a/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests/TwinCATReinitializeReleasesStateTests.cs +++ b/tests/Drivers/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests/TwinCATReinitializeReleasesStateTests.cs @@ -33,7 +33,7 @@ public sealed class TwinCATReinitializeReleasesStateTests } var firstClient = factory.Clients[0]; var firstLoop = first.ProbeTask; - firstLoop.ShouldNotBeNull(); + _ = firstLoop.ShouldNotBeNull(); firstLoop!.IsCompleted.ShouldBeFalse(); await drv.InitializeAsync("{}", CancellationToken.None);