fix(scripted-alarms): log failed event-report via SDK trace + correct sink doc (T16 review)

This commit is contained in:
Joseph Doherty
2026-06-10 19:53:33 -04:00
parent 295bb55dc6
commit 4c417f7fb8
2 changed files with 13 additions and 4 deletions
@@ -20,7 +20,8 @@ public interface IOpcUaAddressSpaceSink
/// this projects the whole <see cref="AlarmConditionSnapshot"/> /// this projects the whole <see cref="AlarmConditionSnapshot"/>
/// (Enabled/Active/Acked/Confirmed/Shelving/Severity/Message) onto it and recomputes Retain; /// (Enabled/Active/Acked/Confirmed/Shelving/Severity/Message) onto it and recomputes Retain;
/// otherwise it falls back to the legacy two-element <c>[Active, Acknowledged]</c> placeholder /// otherwise it falls back to the legacy two-element <c>[Active, Acknowledged]</c> placeholder
/// variable. No OPC UA event is fired — that is T16's responsibility.</summary> /// variable. A materialised condition also fires a Part 9 condition event on each transition (T16)
/// so subscribed clients receive the alarm event, not just the changed attributes.</summary>
/// <param name="alarmNodeId">The OPC UA node ID of the alarm (== ScriptedAlarmId for materialised conditions).</param> /// <param name="alarmNodeId">The OPC UA node ID of the alarm (== ScriptedAlarmId for materialised conditions).</param>
/// <param name="state">The full condition state to project onto the node.</param> /// <param name="state">The full condition state to project onto the node.</param>
/// <param name="sourceTimestampUtc">The source timestamp in UTC.</param> /// <param name="sourceTimestampUtc">The source timestamp in UTC.</param>
@@ -224,13 +224,21 @@ public sealed class OtOpcUaNodeManager : CustomNodeManager2
snapshot.Initialize(SystemContext, alarm); snapshot.Initialize(SystemContext, alarm);
alarm.ReportEvent(SystemContext, snapshot); alarm.ReportEvent(SystemContext, snapshot);
} }
catch (Exception) catch (Exception ex)
{ {
// A failed event report must NOT break the state projection or the calling actor: the node's // A failed event report must NOT break the state projection or the calling actor: the node's
// state has already been applied + ClearChangeMasks'd, so attribute subscribers still see the // state has already been applied + ClearChangeMasks'd, so attribute subscribers still see the
// change; only the event delivery is lost. There is no logger on this CustomNodeManager2 // change; only the event delivery is lost. This CustomNodeManager2 carries no ILogger, so log
// (the SDK base class carries none), so swallow rather than propagate. T19's live Client.CLI // through the SDK's static trace (Utils.LogError) instead of swallowing silently — a recurring
// failure here is then visible in the server log rather than invisible. T19's live Client.CLI
// run is the integration proof that the happy path delivers. // run is the integration proof that the happy path delivers.
// Utils.LogError routes to the SDK's trace sink. It's [Obsolete] in 1.5.378 in favour of an
// ITelemetryContext/ILogger this CustomNodeManager2 doesn't have wired — suppress the
// deprecation here (wiring the telemetry logger through is a separate follow-up); the point is
// that a recurring failure is visible in the server trace rather than silently swallowed.
#pragma warning disable CS0618 // Type or member is obsolete
Utils.LogError(ex, "OtOpcUaNodeManager: failed to report Part 9 condition event for {0}", alarm.NodeId);
#pragma warning restore CS0618
} }
} }