test(galaxy.browser): unit + fake-transport session coverage

2026-05-28 16:07:13 -04:00
parent 5475ab2aa3
commit 48c3c56073
5 changed files with 220 additions and 0 deletions
@@ -0,0 +1,55 @@
+using Shouldly;
+using Xunit;
+
+namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Browser.Tests;
+
+/// <summary>
+///     Unit-only coverage of <see cref="GalaxyDriverBrowser"/>'s pre-connect validation.
+///     These tests do not require a live mxaccessgw endpoint and are safe to run without
+///     the gateway fixture — they exercise the JSON deserialization + validation paths
+///     that run before <c>GalaxyRepositoryClient.Create</c> + <c>TestConnectionAsync</c>.
+///     The factory's transport-construction path is covered by the integration suite
+///     (Task 17) and manual smoke (Task 18) since both require a real gateway.
+/// </summary>
+[Trait("Category", "Unit")]
+public sealed class GalaxyDriverBrowserTests
+{
+    private readonly GalaxyDriverBrowser _sut = new();
+
+    /// <summary>The DriverType key must match the AdminUI's persisted "Galaxy" value
+    /// so the factory wire-up picks the right browser implementation.</summary>
+    [Fact]
+    public void DriverType_is_Galaxy() => _sut.DriverType.ShouldBe("Galaxy");
+
+    /// <summary>An empty Gateway.Endpoint must fail fast with a clear, endpoint-mentioning
+    /// message rather than surfacing a downstream gRPC URI parse error.</summary>
+    [Fact]
+    public async Task OpenAsync_with_empty_endpoint_throws_InvalidOperationException()
+    {
+        var json = """{"Gateway":{"Endpoint":"","ApiKeySecretRef":"dev:k"},"MxAccess":{"ClientName":"X"},"Repository":{},"Reconnect":{}}""";
+        var ex = await Should.ThrowAsync<InvalidOperationException>(
+            () => _sut.OpenAsync(json, TestContext.Current.CancellationToken));
+        ex.Message.ShouldContain("Endpoint");
+    }
+
+    /// <summary>An empty MxAccess.ClientName must fail fast — refused so the gateway
+    /// side doesn't see anonymous browse sessions during triage.</summary>
+    [Fact]
+    public async Task OpenAsync_with_empty_clientName_throws_InvalidOperationException()
+    {
+        var json = """{"Gateway":{"Endpoint":"http://127.0.0.1:1","ApiKeySecretRef":"dev:k"},"MxAccess":{"ClientName":""},"Repository":{},"Reconnect":{}}""";
+        var ex = await Should.ThrowAsync<InvalidOperationException>(
+            () => _sut.OpenAsync(json, TestContext.Current.CancellationToken));
+        ex.Message.ShouldContain("ClientName");
+    }
+
+    /// <summary>A JSON literal that deserializes to null must fail fast with a
+    /// "deserialized to null" message — never a downstream NRE.</summary>
+    [Fact]
+    public async Task OpenAsync_with_null_json_throws_InvalidOperationException()
+    {
+        var ex = await Should.ThrowAsync<InvalidOperationException>(
+            () => _sut.OpenAsync("null", TestContext.Current.CancellationToken));
+        ex.Message.ShouldContain("null");
+    }
+}