fix(security): no role, no login — refuse zero-role and mapper-fault AdminUI sign-in and tokens (#913)
/auth/login signed users in with an empty role set (and did so when the role mapper threw), and AuthenticatedRead / the fallback policy admit any authenticated user — with a domain-root SearchBase any AD user would get AdminUI read access and a token. - Empty mapped role set: refused like bad credentials (JSON 401; form redirect to /login with a generic message), no cookie, Warning logged with the groups. - Mapper throws: refused, fail closed (JSON 503 like an LDAP outage; form redirect with a generic "temporarily unavailable"), exception logged. - /auth/token: refuses (401) a cookie session carrying no role claim. - Replaces Login_when_role_mapper_throws_signs_in_with_no_role_claims with refusal tests (JSON + form), adds zero-role refused (JSON + form), one-mapped-role signs in, zero-role cookie gets no token. JwtConfigurationGateTests' stub user now holds a mapped group. Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
This commit is contained in:
@@ -83,7 +83,8 @@ public sealed class JwtConfigurationGateTests
|
||||
private static async Task<IHost> StartHostAsync(string? signingKey)
|
||||
{
|
||||
var dbName = $"jwt-gate-{Guid.NewGuid():N}";
|
||||
var settings = new Dictionary<string, string?>();
|
||||
// lmxopcua#913: a login whose groups map to no role is refused, so alice's group must map.
|
||||
var settings = new Dictionary<string, string?> { ["Security:Ldap:GroupToRole:ReadOnly"] = "Viewer" };
|
||||
if (signingKey is not null) settings["Security:Jwt:SigningKey"] = signingKey;
|
||||
var configuration = new ConfigurationBuilder().AddInMemoryCollection(settings).Build();
|
||||
|
||||
@@ -122,6 +123,6 @@ public sealed class JwtConfigurationGateTests
|
||||
public Task<LdapAuthResult> AuthenticateAsync(string username, string password, CancellationToken ct = default) =>
|
||||
Task.FromResult(new LdapAuthResult(
|
||||
Success: password == "valid-password", DisplayName: "Alice", Username: username,
|
||||
Groups: [], Roles: [], Error: null));
|
||||
Groups: ["ReadOnly"], Roles: [], Error: null));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user