fix: preserve SDK 2.0 client value and lifetime contracts
This commit is contained in:
@@ -34,8 +34,8 @@ public class NodeIdParserTests
|
||||
{
|
||||
var result = NodeIdParser.Parse("ns=2;s=MyNode");
|
||||
result.ShouldNotBeNull();
|
||||
result.NamespaceIndex.ShouldBe((ushort)2);
|
||||
result.Identifier.ShouldBe("MyNode");
|
||||
result.Value.NamespaceIndex.ShouldBe((ushort)2);
|
||||
result.Value.IdentifierAsString.ShouldBe("MyNode");
|
||||
}
|
||||
|
||||
/// <summary>Verifies that Parse correctly parses numeric NodeId format (i=85).</summary>
|
||||
@@ -44,7 +44,7 @@ public class NodeIdParserTests
|
||||
{
|
||||
var result = NodeIdParser.Parse("i=85");
|
||||
result.ShouldNotBeNull();
|
||||
result.IdType.ShouldBe(IdType.Numeric);
|
||||
result.Value.IdType.ShouldBe(IdType.Numeric);
|
||||
}
|
||||
|
||||
/// <summary>Verifies that Parse treats bare numeric input as namespace 0 numeric NodeId.</summary>
|
||||
@@ -53,8 +53,9 @@ public class NodeIdParserTests
|
||||
{
|
||||
var result = NodeIdParser.Parse("85");
|
||||
result.ShouldNotBeNull();
|
||||
result.NamespaceIndex.ShouldBe((ushort)0);
|
||||
result.Identifier.ShouldBe((uint)85);
|
||||
result.Value.NamespaceIndex.ShouldBe((ushort)0);
|
||||
result.Value.TryGetValue(out uint identifier).ShouldBeTrue();
|
||||
identifier.ShouldBe(85u);
|
||||
}
|
||||
|
||||
/// <summary>Verifies that Parse trims whitespace padding from input.</summary>
|
||||
@@ -63,7 +64,7 @@ public class NodeIdParserTests
|
||||
{
|
||||
var result = NodeIdParser.Parse(" ns=2;s=MyNode ");
|
||||
result.ShouldNotBeNull();
|
||||
result.Identifier.ShouldBe("MyNode");
|
||||
result.Value.IdentifierAsString.ShouldBe("MyNode");
|
||||
}
|
||||
|
||||
/// <summary>Verifies that Parse throws FormatException for invalid input.</summary>
|
||||
@@ -92,7 +93,36 @@ public class NodeIdParserTests
|
||||
public void ParseRequired_ValidInput_ReturnsNodeId()
|
||||
{
|
||||
var result = NodeIdParser.ParseRequired("ns=2;s=TestNode");
|
||||
result.ShouldNotBeNull();
|
||||
result.Identifier.ShouldBe("TestNode");
|
||||
result.IsNull.ShouldBeFalse();
|
||||
result.IdentifierAsString.ShouldBe("TestNode");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Parse_OpaqueIdentifier_PreservesBytes()
|
||||
{
|
||||
var node = NodeIdParser.ParseRequired("ns=3;b=AQID");
|
||||
node.IdType.ShouldBe(IdType.Opaque);
|
||||
node.NamespaceIndex.ShouldBe((ushort)3);
|
||||
node.TryGetValue(out ByteString bytes).ShouldBeTrue();
|
||||
bytes.ToArray().ShouldBe(new byte[] { 1, 2, 3 });
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Parse_StringIdentifierContainingEncodedText_StaysLiteral()
|
||||
{
|
||||
var node = NodeIdParser.ParseRequired("ns=4;s=ns=2;b=AQID");
|
||||
node.IdType.ShouldBe(IdType.String);
|
||||
node.NamespaceIndex.ShouldBe((ushort)4);
|
||||
node.TryGetValue(out string? identifier).ShouldBeTrue();
|
||||
identifier.ShouldBe("ns=2;b=AQID");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("ns=bad;i=1")]
|
||||
[InlineData("ns=2;b=invalid!")]
|
||||
[InlineData("ns=2;i=invalid")]
|
||||
public void Parse_InvalidEncodedIdentifier_IsRejected(string input)
|
||||
{
|
||||
Should.Throw<FormatException>(() => NodeIdParser.ParseRequired(input));
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user