refactor(configdb): drop ClusterNode.RedundancyRole (replaced by Akka leader)

Phase 1d of the v2 entity-model rewrite. The static RedundancyRole column
is replaced by Akka cluster's role-leader-of-"driver" election at runtime
(see RedundancyStateActor + ServiceLevelCalculator in Task 35).

Changes:

  - Removed `public required RedundancyRole RedundancyRole` from
    ClusterNode entity.
  - Removed `e.Property(x => x.RedundancyRole).HasConversion<string>()...`
    mapping from OtOpcUaConfigDbContext.ConfigureClusterNode.
  - Removed the `UX_ClusterNode_Primary_Per_Cluster` filtered unique index
    (filter referenced [RedundancyRole]='Primary').
  - Dropped `using ZB.MOM.WW.OtOpcUa.Configuration.Enums` from ClusterNode.cs
    (no longer needed).
  - Deleted `Enums/RedundancyRole.cs` — the enum is unused in v2-kept code.
  - DraftValidator: dropped the "exactly one Primary per cluster"
    validation block. Comment in place explaining v2 picks primary at
    runtime via Akka.
  - DraftValidatorTests: dropped ValidateClusterTopology_flags_multiple_Primary
    test; reworked BuildNode helper to no longer take a `role` argument.

Untouched (Server + Admin still reference RedundancyRole; accepted broken
per Task 56 policy):

  src/Server/ZB.MOM.WW.OtOpcUa.Server/Redundancy/{ClusterTopologyLoader,
    RedundancyStatePublisher, RedundancyTopology, ServiceLevelCalculator}.cs
  src/Server/ZB.MOM.WW.OtOpcUa.Admin/Services/RedundancyMetrics.cs

DB-runtime tests will fail against the new schema (Task 14f's migration
drops the column) — to be updated in Task 14f's SchemaComplianceTests
update:

  - SchemaComplianceTests.cs:55 (expected filtered index list)
  - StoredProceduresTests.cs:263 (raw INSERT names the column)

Verification:
  src/Core/ZB.MOM.WW.OtOpcUa.Configuration            -> 0 errors
  tests/Core/ZB.MOM.WW.OtOpcUa.Configuration.Tests    -> 0 errors
  whole solution                                       -> 71 errors
    (70 from Task 14b in Server/Admin, +1 new Server/Redundancy reference)

This commit is contained in:

Joseph Doherty

2026-05-26 04:11:57 -04:00

parent 1ddf8bb50e

commit 3c915e652e

5 changed files with 16 additions and 45 deletions

									
										src/Core/ZB.MOM.WW.OtOpcUa.Configuration/Entities/ClusterNode.cs
									
		-4
	
												View File
												
				@@ -1,5 +1,3 @@

				using ZB.MOM.WW.OtOpcUa.Configuration.Enums;

				namespace ZB.MOM.WW.OtOpcUa.Configuration.Entities;

				/// <summary>Physical OPC UA server node within a <see cref="ServerCluster"/>.</summary>

				@@ -10,8 +8,6 @@ public sealed class ClusterNode

				    public required string ClusterId { get; set; }

				    public required RedundancyRole RedundancyRole { get; set; }

				    /// <summary>Machine hostname / IP.</summary>

				    public required string Host { get; set; }