dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

review(AdminUI): fix null-TagConfig crash, CTS leak, unencoded historian tag

Browse Source 
Review at HEAD 7286d320. AdminUI-002: IsValidJson null/blank -> friendly error (was
ArgumentNullException). AdminUI-003: DriverStatusPanel Reconnect/Restart dispose CTS (build-
verified, live /run deferred). AdminUI-005: HistorianWonderware picker URL-encodes tag name.
AdminUI-008: Format round-trip test. 001 (script-page authz) + 004 (hub [Authorize]) left
Open as cross-cutting w/ Host/Security.
This commit is contained in:
Joseph Doherty
2026-06-19 10:52:23 -04:00
parent 1aa7905676
commit 3c908f1df0
7 changed files with 306 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/Uns/UnsTreeServiceTagTests.cs
+35
View File
@@ -167,6 +167,41 @@ public sealed class UnsTreeServiceTagTests
db.Tags.Any(t => t.TagId == "TAG-1").ShouldBeFalse();
}
/// <summary>A tag with a null TagConfig is blocked with the friendly "not valid JSON" message
/// (rather than an unhandled ArgumentNullException) — AdminUI-002.</summary>
[Fact]
public async Task CreateTag_with_null_TagConfig_returns_friendly_error()
{
var (service, dbName) = Fresh();
SeedHierarchyAndDrivers(dbName, equipmentCluster: "MAIN", seedEquipmentDriver: true);
var result = await service.CreateTagAsync(
"EQ-1", Input("TAG-1", "speed", "DRV-EQ", tagConfig: null!));
result.Ok.ShouldBeFalse();
result.Error.ShouldBe("TagConfig is not valid JSON.");
using var db = UnsTreeTestDb.CreateNamed(dbName);
db.Tags.Any(t => t.TagId == "TAG-1").ShouldBeFalse();
}
/// <summary>A tag with a blank/whitespace TagConfig is blocked with the friendly message — AdminUI-002.</summary>
[Fact]
public async Task CreateTag_with_blank_TagConfig_returns_friendly_error()
{
var (service, dbName) = Fresh();
SeedHierarchyAndDrivers(dbName, equipmentCluster: "MAIN", seedEquipmentDriver: true);
var result = await service.CreateTagAsync(
"EQ-1", Input("TAG-1", "speed", "DRV-EQ", tagConfig: " "));
result.Ok.ShouldBeFalse();
result.Error.ShouldBe("TagConfig is not valid JSON.");
using var db = UnsTreeTestDb.CreateNamed(dbName);
db.Tags.Any(t => t.TagId == "TAG-1").ShouldBeFalse();
}
/// <summary>Binding a tag to a driver in a different cluster than the equipment is blocked (#122).</summary>
[Fact]
public async Task CreateTag_driver_in_other_cluster_blocked()