Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*
Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.
Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.
Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,129 @@
|
||||
using System.Threading.Tasks;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Shouldly;
|
||||
using Xunit;
|
||||
using ZB.MOM.WW.OtOpcUa.Host.Configuration;
|
||||
using ZB.MOM.WW.OtOpcUa.Host.GalaxyRepository;
|
||||
|
||||
namespace ZB.MOM.WW.OtOpcUa.IntegrationTests
|
||||
{
|
||||
/// <summary>
|
||||
/// Integration tests that exercise the real Galaxy repository queries against the test database configuration.
|
||||
/// </summary>
|
||||
public class GalaxyRepositoryServiceTests
|
||||
{
|
||||
/// <summary>
|
||||
/// Loads repository configuration from the integration test settings and controls whether extended attributes are
|
||||
/// enabled.
|
||||
/// </summary>
|
||||
/// <param name="extendedAttributes">A value indicating whether the extended attribute query path should be enabled.</param>
|
||||
/// <returns>The repository configuration used by the integration test.</returns>
|
||||
private static GalaxyRepositoryConfiguration LoadConfig(bool extendedAttributes = false)
|
||||
{
|
||||
var configuration = new ConfigurationBuilder()
|
||||
.AddJsonFile("appsettings.test.json", false)
|
||||
.Build();
|
||||
|
||||
var config = new GalaxyRepositoryConfiguration();
|
||||
configuration.GetSection("GalaxyRepository").Bind(config);
|
||||
config.ExtendedAttributes = extendedAttributes;
|
||||
return config;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that the standard attribute query returns rows from the repository.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_StandardMode_ReturnsRows()
|
||||
{
|
||||
var config = LoadConfig(false);
|
||||
var service = new GalaxyRepositoryService(config);
|
||||
|
||||
var results = await service.GetAttributesAsync();
|
||||
|
||||
results.ShouldNotBeEmpty();
|
||||
// Standard mode: PrimitiveName and AttributeSource should be empty
|
||||
results.ShouldAllBe(r => r.PrimitiveName == "" && r.AttributeSource == "");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that the extended attribute query returns more rows than the standard query path.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_ExtendedMode_ReturnsMoreRows()
|
||||
{
|
||||
var standardConfig = LoadConfig(false);
|
||||
var extendedConfig = LoadConfig(true);
|
||||
var standardService = new GalaxyRepositoryService(standardConfig);
|
||||
var extendedService = new GalaxyRepositoryService(extendedConfig);
|
||||
|
||||
var standardResults = await standardService.GetAttributesAsync();
|
||||
var extendedResults = await extendedService.GetAttributesAsync();
|
||||
|
||||
extendedResults.Count.ShouldBeGreaterThan(standardResults.Count);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that the extended attribute query includes both primitive and dynamic attribute sources.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_ExtendedMode_IncludesPrimitiveAttributes()
|
||||
{
|
||||
var config = LoadConfig(true);
|
||||
var service = new GalaxyRepositoryService(config);
|
||||
|
||||
var results = await service.GetAttributesAsync();
|
||||
|
||||
results.ShouldContain(r => r.AttributeSource == "primitive");
|
||||
results.ShouldContain(r => r.AttributeSource == "dynamic");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that extended mode populates attribute-source metadata across the result set.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_ExtendedMode_PrimitiveNamePopulated()
|
||||
{
|
||||
var config = LoadConfig(true);
|
||||
var service = new GalaxyRepositoryService(config);
|
||||
|
||||
var results = await service.GetAttributesAsync();
|
||||
|
||||
// Some primitive attributes have non-empty primitive names
|
||||
// (though many have empty primitive_name for the root UDO)
|
||||
results.ShouldNotBeEmpty();
|
||||
// All should have an attribute source
|
||||
results.ShouldAllBe(r => r.AttributeSource == "primitive" || r.AttributeSource == "dynamic");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that standard-mode results always include fully qualified tag references.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_StandardMode_AllHaveFullTagReference()
|
||||
{
|
||||
var config = LoadConfig(false);
|
||||
var service = new GalaxyRepositoryService(config);
|
||||
|
||||
var results = await service.GetAttributesAsync();
|
||||
|
||||
results.ShouldAllBe(r => !string.IsNullOrEmpty(r.FullTagReference));
|
||||
results.ShouldAllBe(r => r.FullTagReference.Contains("."));
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Confirms that extended-mode results always include fully qualified tag references.
|
||||
/// </summary>
|
||||
[Fact]
|
||||
public async Task GetAttributesAsync_ExtendedMode_AllHaveFullTagReference()
|
||||
{
|
||||
var config = LoadConfig(true);
|
||||
var service = new GalaxyRepositoryService(config);
|
||||
|
||||
var results = await service.GetAttributesAsync();
|
||||
|
||||
results.ShouldAllBe(r => !string.IsNullOrEmpty(r.FullTagReference));
|
||||
results.ShouldAllBe(r => r.FullTagReference.Contains("."));
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user