dohertj2/lmxopcua
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*

Browse Source 
Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.

Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.

Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-04-17 13:57:47 -04:00
parent 5b8d708c58
commit 3b2defd94f
293 changed files with 841 additions and 722 deletions
Download Patch File Download Diff File Expand all files Collapse all files

155
tests/ZB.MOM.WW.OtOpcUa.Client.UI.Tests/BrowseTreeViewModelTests.cs Normal file
View File

@@ -0,0 +1,155 @@
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class BrowseTreeViewModelTests
{
private readonly SynchronousUiDispatcher _dispatcher;
private readonly FakeOpcUaClientService _service;
private readonly BrowseTreeViewModel _vm;
public BrowseTreeViewModelTests()
{
_service = new FakeOpcUaClientService
{
BrowseResults =
[
new BrowseResult("ns=2;s=Node1", "Node1", "Object", true),
new BrowseResult("ns=2;s=Node2", "Node2", "Variable", false)
]
};
_dispatcher = new SynchronousUiDispatcher();
_vm = new BrowseTreeViewModel(_service, _dispatcher);
}
[Fact]
public async Task LoadRootsAsync_PopulatesRootNodes()
{
await _vm.LoadRootsAsync();
_vm.RootNodes.Count.ShouldBe(2);
_vm.RootNodes[0].DisplayName.ShouldBe("Node1");
_vm.RootNodes[1].DisplayName.ShouldBe("Node2");
}
[Fact]
public async Task LoadRootsAsync_BrowsesWithNullParent()
{
await _vm.LoadRootsAsync();
_service.BrowseCallCount.ShouldBe(1);
_service.LastBrowseParentNodeId.ShouldBeNull();
}
[Fact]
public void Clear_RemovesAllRootNodes()
{
_vm.RootNodes.Add(new TreeNodeViewModel("ns=2;s=X", "X", "Object", false, _service, _dispatcher));
_vm.Clear();
_vm.RootNodes.ShouldBeEmpty();
}
[Fact]
public async Task LoadRootsAsync_NodeWithChildren_HasPlaceholder()
{
await _vm.LoadRootsAsync();
var nodeWithChildren = _vm.RootNodes[0];
nodeWithChildren.HasChildren.ShouldBeTrue();
nodeWithChildren.Children.Count.ShouldBe(1);
nodeWithChildren.Children[0].IsPlaceholder.ShouldBeTrue();
}
[Fact]
public async Task LoadRootsAsync_NodeWithoutChildren_HasNoPlaceholder()
{
await _vm.LoadRootsAsync();
var leafNode = _vm.RootNodes[1];
leafNode.HasChildren.ShouldBeFalse();
leafNode.Children.ShouldBeEmpty();
}
[Fact]
public async Task TreeNode_FirstExpand_TriggersChildBrowse()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
// Reset browse results for child browse
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false)
];
var parent = _vm.RootNodes[0];
var initialBrowseCount = _service.BrowseCallCount;
parent.IsExpanded = true;
// Allow async operation to complete
await Task.Delay(50);
_service.BrowseCallCount.ShouldBe(initialBrowseCount + 1);
parent.Children.Count.ShouldBe(1);
parent.Children[0].DisplayName.ShouldBe("Child1");
}
[Fact]
public async Task TreeNode_SecondExpand_DoesNotBrowseAgain()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false)
];
var parent = _vm.RootNodes[0];
parent.IsExpanded = true;
await Task.Delay(50);
var browseCountAfterFirst = _service.BrowseCallCount;
parent.IsExpanded = false;
parent.IsExpanded = true;
await Task.Delay(50);
_service.BrowseCallCount.ShouldBe(browseCountAfterFirst);
}
[Fact]
public async Task TreeNode_IsLoading_TransitionsDuringBrowse()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
_service.BrowseResults = [];
var parent = _vm.RootNodes[0];
parent.IsExpanded = true;
await Task.Delay(50);
// After completion, IsLoading should be false
parent.IsLoading.ShouldBeFalse();
}
}