Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*

Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.

Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.

Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-04-17 13:57:47 -04:00
parent 5b8d708c58
commit 3b2defd94f
293 changed files with 841 additions and 722 deletions

View File

@@ -0,0 +1,141 @@
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class AlarmsViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly AlarmsViewModel _vm;
public AlarmsViewModelTests()
{
_service = new FakeOpcUaClientService();
var dispatcher = new SynchronousUiDispatcher();
_vm = new AlarmsViewModel(_service, dispatcher);
}
[Fact]
public void SubscribeCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void SubscribeCommand_CannotExecute_WhenAlreadySubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = true;
_vm.SubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void SubscribeCommand_CanExecute_WhenConnectedAndNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.SubscribeCommand.CanExecute(null).ShouldBeTrue();
}
[Fact]
public async Task SubscribeCommand_SetsIsSubscribed()
{
_vm.IsConnected = true;
await _vm.SubscribeCommand.ExecuteAsync(null);
_vm.IsSubscribed.ShouldBeTrue();
_service.SubscribeAlarmsCallCount.ShouldBe(1);
}
[Fact]
public void UnsubscribeCommand_CannotExecute_WhenNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.UnsubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task UnsubscribeCommand_ClearsIsSubscribed()
{
_vm.IsConnected = true;
await _vm.SubscribeCommand.ExecuteAsync(null);
await _vm.UnsubscribeCommand.ExecuteAsync(null);
_vm.IsSubscribed.ShouldBeFalse();
_service.UnsubscribeAlarmsCallCount.ShouldBe(1);
}
[Fact]
public async Task RefreshCommand_CallsService()
{
_vm.IsConnected = true;
_vm.IsSubscribed = true;
await _vm.RefreshCommand.ExecuteAsync(null);
_service.RequestConditionRefreshCallCount.ShouldBe(1);
}
[Fact]
public void RefreshCommand_CannotExecute_WhenNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.RefreshCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void AlarmEvent_AddsToCollection()
{
var alarm = new AlarmEventArgs(
"Source1", "HighAlarm", 500, "Temperature high",
true, true, false, DateTime.UtcNow);
_service.RaiseAlarmEvent(alarm);
_vm.AlarmEvents.Count.ShouldBe(1);
_vm.AlarmEvents[0].SourceName.ShouldBe("Source1");
_vm.AlarmEvents[0].ConditionName.ShouldBe("HighAlarm");
_vm.AlarmEvents[0].Severity.ShouldBe((ushort)500);
_vm.AlarmEvents[0].Message.ShouldBe("Temperature high");
}
[Fact]
public void Clear_ResetsState()
{
_vm.IsSubscribed = true;
_vm.AlarmEvents.Add(new AlarmEventViewModel("Src", "Cond", 100, "Msg", true, true, false, DateTime.UtcNow));
_vm.Clear();
_vm.AlarmEvents.ShouldBeEmpty();
_vm.IsSubscribed.ShouldBeFalse();
}
[Fact]
public void Teardown_UnhooksEventHandler()
{
_vm.Teardown();
var alarm = new AlarmEventArgs(
"Source1", "HighAlarm", 500, "Test",
true, true, false, DateTime.UtcNow);
_service.RaiseAlarmEvent(alarm);
_vm.AlarmEvents.ShouldBeEmpty();
}
[Fact]
public void DefaultInterval_Is1000()
{
_vm.Interval.ShouldBe(1000);
}
}