Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*

Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.

Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.

Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-04-17 13:57:47 -04:00
parent 5b8d708c58
commit 3b2defd94f
293 changed files with 841 additions and 722 deletions

View File

@@ -0,0 +1,141 @@
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class AlarmsViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly AlarmsViewModel _vm;
public AlarmsViewModelTests()
{
_service = new FakeOpcUaClientService();
var dispatcher = new SynchronousUiDispatcher();
_vm = new AlarmsViewModel(_service, dispatcher);
}
[Fact]
public void SubscribeCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void SubscribeCommand_CannotExecute_WhenAlreadySubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = true;
_vm.SubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void SubscribeCommand_CanExecute_WhenConnectedAndNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.SubscribeCommand.CanExecute(null).ShouldBeTrue();
}
[Fact]
public async Task SubscribeCommand_SetsIsSubscribed()
{
_vm.IsConnected = true;
await _vm.SubscribeCommand.ExecuteAsync(null);
_vm.IsSubscribed.ShouldBeTrue();
_service.SubscribeAlarmsCallCount.ShouldBe(1);
}
[Fact]
public void UnsubscribeCommand_CannotExecute_WhenNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.UnsubscribeCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task UnsubscribeCommand_ClearsIsSubscribed()
{
_vm.IsConnected = true;
await _vm.SubscribeCommand.ExecuteAsync(null);
await _vm.UnsubscribeCommand.ExecuteAsync(null);
_vm.IsSubscribed.ShouldBeFalse();
_service.UnsubscribeAlarmsCallCount.ShouldBe(1);
}
[Fact]
public async Task RefreshCommand_CallsService()
{
_vm.IsConnected = true;
_vm.IsSubscribed = true;
await _vm.RefreshCommand.ExecuteAsync(null);
_service.RequestConditionRefreshCallCount.ShouldBe(1);
}
[Fact]
public void RefreshCommand_CannotExecute_WhenNotSubscribed()
{
_vm.IsConnected = true;
_vm.IsSubscribed = false;
_vm.RefreshCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void AlarmEvent_AddsToCollection()
{
var alarm = new AlarmEventArgs(
"Source1", "HighAlarm", 500, "Temperature high",
true, true, false, DateTime.UtcNow);
_service.RaiseAlarmEvent(alarm);
_vm.AlarmEvents.Count.ShouldBe(1);
_vm.AlarmEvents[0].SourceName.ShouldBe("Source1");
_vm.AlarmEvents[0].ConditionName.ShouldBe("HighAlarm");
_vm.AlarmEvents[0].Severity.ShouldBe((ushort)500);
_vm.AlarmEvents[0].Message.ShouldBe("Temperature high");
}
[Fact]
public void Clear_ResetsState()
{
_vm.IsSubscribed = true;
_vm.AlarmEvents.Add(new AlarmEventViewModel("Src", "Cond", 100, "Msg", true, true, false, DateTime.UtcNow));
_vm.Clear();
_vm.AlarmEvents.ShouldBeEmpty();
_vm.IsSubscribed.ShouldBeFalse();
}
[Fact]
public void Teardown_UnhooksEventHandler()
{
_vm.Teardown();
var alarm = new AlarmEventArgs(
"Source1", "HighAlarm", 500, "Test",
true, true, false, DateTime.UtcNow);
_service.RaiseAlarmEvent(alarm);
_vm.AlarmEvents.ShouldBeEmpty();
}
[Fact]
public void DefaultInterval_Is1000()
{
_vm.Interval.ShouldBe(1000);
}
}

View File

@@ -0,0 +1,155 @@
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class BrowseTreeViewModelTests
{
private readonly SynchronousUiDispatcher _dispatcher;
private readonly FakeOpcUaClientService _service;
private readonly BrowseTreeViewModel _vm;
public BrowseTreeViewModelTests()
{
_service = new FakeOpcUaClientService
{
BrowseResults =
[
new BrowseResult("ns=2;s=Node1", "Node1", "Object", true),
new BrowseResult("ns=2;s=Node2", "Node2", "Variable", false)
]
};
_dispatcher = new SynchronousUiDispatcher();
_vm = new BrowseTreeViewModel(_service, _dispatcher);
}
[Fact]
public async Task LoadRootsAsync_PopulatesRootNodes()
{
await _vm.LoadRootsAsync();
_vm.RootNodes.Count.ShouldBe(2);
_vm.RootNodes[0].DisplayName.ShouldBe("Node1");
_vm.RootNodes[1].DisplayName.ShouldBe("Node2");
}
[Fact]
public async Task LoadRootsAsync_BrowsesWithNullParent()
{
await _vm.LoadRootsAsync();
_service.BrowseCallCount.ShouldBe(1);
_service.LastBrowseParentNodeId.ShouldBeNull();
}
[Fact]
public void Clear_RemovesAllRootNodes()
{
_vm.RootNodes.Add(new TreeNodeViewModel("ns=2;s=X", "X", "Object", false, _service, _dispatcher));
_vm.Clear();
_vm.RootNodes.ShouldBeEmpty();
}
[Fact]
public async Task LoadRootsAsync_NodeWithChildren_HasPlaceholder()
{
await _vm.LoadRootsAsync();
var nodeWithChildren = _vm.RootNodes[0];
nodeWithChildren.HasChildren.ShouldBeTrue();
nodeWithChildren.Children.Count.ShouldBe(1);
nodeWithChildren.Children[0].IsPlaceholder.ShouldBeTrue();
}
[Fact]
public async Task LoadRootsAsync_NodeWithoutChildren_HasNoPlaceholder()
{
await _vm.LoadRootsAsync();
var leafNode = _vm.RootNodes[1];
leafNode.HasChildren.ShouldBeFalse();
leafNode.Children.ShouldBeEmpty();
}
[Fact]
public async Task TreeNode_FirstExpand_TriggersChildBrowse()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
// Reset browse results for child browse
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false)
];
var parent = _vm.RootNodes[0];
var initialBrowseCount = _service.BrowseCallCount;
parent.IsExpanded = true;
// Allow async operation to complete
await Task.Delay(50);
_service.BrowseCallCount.ShouldBe(initialBrowseCount + 1);
parent.Children.Count.ShouldBe(1);
parent.Children[0].DisplayName.ShouldBe("Child1");
}
[Fact]
public async Task TreeNode_SecondExpand_DoesNotBrowseAgain()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false)
];
var parent = _vm.RootNodes[0];
parent.IsExpanded = true;
await Task.Delay(50);
var browseCountAfterFirst = _service.BrowseCallCount;
parent.IsExpanded = false;
parent.IsExpanded = true;
await Task.Delay(50);
_service.BrowseCallCount.ShouldBe(browseCountAfterFirst);
}
[Fact]
public async Task TreeNode_IsLoading_TransitionsDuringBrowse()
{
_service.BrowseResults =
[
new BrowseResult("ns=2;s=Parent", "Parent", "Object", true)
];
await _vm.LoadRootsAsync();
_service.BrowseResults = [];
var parent = _vm.RootNodes[0];
parent.IsExpanded = true;
await Task.Delay(50);
// After completion, IsLoading should be false
parent.IsLoading.ShouldBeFalse();
}
}

View File

@@ -0,0 +1,287 @@
using Opc.Ua;
using ZB.MOM.WW.OtOpcUa.Client.Shared;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
/// <summary>
/// Test double for the shared OPC UA client service used by UI view-model tests.
/// It lets tests script connection, browse, history, redundancy, and alarm behavior without a live server.
/// </summary>
public sealed class FakeOpcUaClientService : IOpcUaClientService
{
// Configurable responses
/// <summary>
/// Gets or sets the connection metadata returned when a UI test performs a successful connect.
/// </summary>
public ConnectionInfo? ConnectResult { get; set; }
/// <summary>
/// Gets or sets the exception thrown to simulate a failed connect workflow in the UI.
/// </summary>
public Exception? ConnectException { get; set; }
/// <summary>
/// Gets or sets the default browse results returned when no parent-specific branch is configured.
/// </summary>
public IReadOnlyList<BrowseResult> BrowseResults { get; set; } = [];
/// <summary>
/// Gets or sets browse results keyed by parent node so tree-navigation tests can model multiple address-space branches.
/// </summary>
public Dictionary<string, IReadOnlyList<BrowseResult>> BrowseResultsByParent { get; set; } = new();
/// <summary>
/// Gets or sets the exception thrown to simulate browse failures in the UI tree.
/// </summary>
public Exception? BrowseException { get; set; }
/// <summary>
/// Gets or sets the current value returned by point-read tests.
/// </summary>
public DataValue ReadResult { get; set; } =
new(new Variant(42), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow);
/// <summary>
/// Gets or sets the exception thrown to simulate point-read failures in the UI.
/// </summary>
public Exception? ReadException { get; set; }
/// <summary>
/// Gets or sets the status code returned by write operations in UI tests.
/// </summary>
public StatusCode WriteResult { get; set; } = StatusCodes.Good;
/// <summary>
/// Gets or sets the exception thrown to simulate failed write workflows in the UI.
/// </summary>
public Exception? WriteException { get; set; }
/// <summary>
/// Gets or sets the redundancy snapshot returned when the UI inspects server redundancy state.
/// </summary>
public RedundancyInfo? RedundancyResult { get; set; }
/// <summary>
/// Gets or sets the exception thrown to simulate redundancy lookup failures.
/// </summary>
public Exception? RedundancyException { get; set; }
/// <summary>
/// Gets or sets the raw historical values returned to history-view tests.
/// </summary>
public IReadOnlyList<DataValue> HistoryRawResult { get; set; } = [];
/// <summary>
/// Gets or sets the aggregate historical values returned to history-view tests.
/// </summary>
public IReadOnlyList<DataValue> HistoryAggregateResult { get; set; } = [];
/// <summary>
/// Gets or sets the exception thrown to simulate historical-data failures in the UI.
/// </summary>
public Exception? HistoryException { get; set; }
// Call tracking
public int ConnectCallCount { get; private set; }
public int DisconnectCallCount { get; private set; }
public int ReadCallCount { get; private set; }
public int WriteCallCount { get; private set; }
public int BrowseCallCount { get; private set; }
public int SubscribeCallCount { get; private set; }
public int UnsubscribeCallCount { get; private set; }
public int SubscribeAlarmsCallCount { get; private set; }
public int UnsubscribeAlarmsCallCount { get; private set; }
public int RequestConditionRefreshCallCount { get; private set; }
public int HistoryReadRawCallCount { get; private set; }
public int HistoryReadAggregateCallCount { get; private set; }
public int GetRedundancyInfoCallCount { get; private set; }
public ConnectionSettings? LastConnectionSettings { get; private set; }
public NodeId? LastReadNodeId { get; private set; }
public NodeId? LastWriteNodeId { get; private set; }
public object? LastWriteValue { get; private set; }
public NodeId? LastBrowseParentNodeId { get; private set; }
public NodeId? LastSubscribeNodeId { get; private set; }
public int LastSubscribeIntervalMs { get; private set; }
public NodeId? LastUnsubscribeNodeId { get; private set; }
public AggregateType? LastAggregateType { get; private set; }
/// <inheritdoc />
public bool IsConnected { get; set; }
/// <inheritdoc />
public ConnectionInfo? CurrentConnectionInfo { get; set; }
/// <inheritdoc />
public event EventHandler<DataChangedEventArgs>? DataChanged;
/// <inheritdoc />
public event EventHandler<AlarmEventArgs>? AlarmEvent;
/// <inheritdoc />
public event EventHandler<ConnectionStateChangedEventArgs>? ConnectionStateChanged;
/// <inheritdoc />
public Task<ConnectionInfo> ConnectAsync(ConnectionSettings settings, CancellationToken ct = default)
{
ConnectCallCount++;
LastConnectionSettings = settings;
if (ConnectException != null) throw ConnectException;
IsConnected = true;
CurrentConnectionInfo = ConnectResult;
return Task.FromResult(ConnectResult!);
}
/// <inheritdoc />
public Task DisconnectAsync(CancellationToken ct = default)
{
DisconnectCallCount++;
IsConnected = false;
CurrentConnectionInfo = null;
return Task.CompletedTask;
}
/// <inheritdoc />
public Task<DataValue> ReadValueAsync(NodeId nodeId, CancellationToken ct = default)
{
ReadCallCount++;
LastReadNodeId = nodeId;
if (ReadException != null) throw ReadException;
return Task.FromResult(ReadResult);
}
/// <inheritdoc />
public Task<StatusCode> WriteValueAsync(NodeId nodeId, object value, CancellationToken ct = default)
{
WriteCallCount++;
LastWriteNodeId = nodeId;
LastWriteValue = value;
if (WriteException != null) throw WriteException;
return Task.FromResult(WriteResult);
}
/// <inheritdoc />
public Task<IReadOnlyList<BrowseResult>> BrowseAsync(NodeId? parentNodeId = null, CancellationToken ct = default)
{
BrowseCallCount++;
LastBrowseParentNodeId = parentNodeId;
if (BrowseException != null) throw BrowseException;
if (parentNodeId != null && BrowseResultsByParent.TryGetValue(parentNodeId.ToString(), out var perParent))
return Task.FromResult(perParent);
return Task.FromResult(BrowseResults);
}
/// <inheritdoc />
public Task SubscribeAsync(NodeId nodeId, int intervalMs = 1000, CancellationToken ct = default)
{
SubscribeCallCount++;
LastSubscribeNodeId = nodeId;
LastSubscribeIntervalMs = intervalMs;
return Task.CompletedTask;
}
/// <inheritdoc />
public Task UnsubscribeAsync(NodeId nodeId, CancellationToken ct = default)
{
UnsubscribeCallCount++;
LastUnsubscribeNodeId = nodeId;
return Task.CompletedTask;
}
/// <inheritdoc />
public Task SubscribeAlarmsAsync(NodeId? sourceNodeId = null, int intervalMs = 1000, CancellationToken ct = default)
{
SubscribeAlarmsCallCount++;
return Task.CompletedTask;
}
/// <inheritdoc />
public Task UnsubscribeAlarmsAsync(CancellationToken ct = default)
{
UnsubscribeAlarmsCallCount++;
return Task.CompletedTask;
}
/// <inheritdoc />
public Task RequestConditionRefreshAsync(CancellationToken ct = default)
{
RequestConditionRefreshCallCount++;
return Task.CompletedTask;
}
public StatusCode AcknowledgeResult { get; set; } = StatusCodes.Good;
public Exception? AcknowledgeException { get; set; }
public int AcknowledgeCallCount { get; private set; }
/// <inheritdoc />
public Task<StatusCode> AcknowledgeAlarmAsync(string conditionNodeId, byte[] eventId, string comment,
CancellationToken ct = default)
{
AcknowledgeCallCount++;
if (AcknowledgeException != null) throw AcknowledgeException;
return Task.FromResult(AcknowledgeResult);
}
/// <inheritdoc />
public Task<IReadOnlyList<DataValue>> HistoryReadRawAsync(NodeId nodeId, DateTime startTime, DateTime endTime,
int maxValues = 1000, CancellationToken ct = default)
{
HistoryReadRawCallCount++;
if (HistoryException != null) throw HistoryException;
return Task.FromResult(HistoryRawResult);
}
/// <inheritdoc />
public Task<IReadOnlyList<DataValue>> HistoryReadAggregateAsync(NodeId nodeId, DateTime startTime, DateTime endTime,
AggregateType aggregate, double intervalMs = 3600000, CancellationToken ct = default)
{
HistoryReadAggregateCallCount++;
LastAggregateType = aggregate;
if (HistoryException != null) throw HistoryException;
return Task.FromResult(HistoryAggregateResult);
}
/// <inheritdoc />
public Task<RedundancyInfo> GetRedundancyInfoAsync(CancellationToken ct = default)
{
GetRedundancyInfoCallCount++;
if (RedundancyException != null) throw RedundancyException;
return Task.FromResult(RedundancyResult!);
}
/// <summary>
/// Releases fake service resources at the end of a UI test run.
/// </summary>
public void Dispose()
{
// No-op for testing
}
/// <summary>
/// Raises a simulated data-change notification so UI tests can validate live update handling.
/// </summary>
public void RaiseDataChanged(DataChangedEventArgs args)
{
DataChanged?.Invoke(this, args);
}
/// <summary>
/// Raises a simulated alarm event so UI tests can validate alarm-list behavior.
/// </summary>
public void RaiseAlarmEvent(AlarmEventArgs args)
{
AlarmEvent?.Invoke(this, args);
}
/// <summary>
/// Raises a simulated connection-state transition so UI tests can validate status presentation and failover behavior.
/// </summary>
public void RaiseConnectionStateChanged(ConnectionStateChangedEventArgs args)
{
ConnectionStateChanged?.Invoke(this, args);
}
}

View File

@@ -0,0 +1,21 @@
using ZB.MOM.WW.OtOpcUa.Client.Shared;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
/// <summary>
/// Fake factory that returns a preconfigured FakeOpcUaClientService.
/// </summary>
public sealed class FakeOpcUaClientServiceFactory : IOpcUaClientServiceFactory
{
private readonly FakeOpcUaClientService _service;
public FakeOpcUaClientServiceFactory(FakeOpcUaClientService service)
{
_service = service;
}
public IOpcUaClientService Create()
{
return _service;
}
}

View File

@@ -0,0 +1,23 @@
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
public sealed class FakeSettingsService : ISettingsService
{
public UserSettings Settings { get; set; } = new();
public int LoadCallCount { get; private set; }
public int SaveCallCount { get; private set; }
public UserSettings? LastSaved { get; private set; }
public UserSettings Load()
{
LoadCallCount++;
return Settings;
}
public void Save(UserSettings settings)
{
SaveCallCount++;
LastSaved = settings;
}
}

View File

@@ -0,0 +1,160 @@
using Opc.Ua;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class HistoryViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly HistoryViewModel _vm;
public HistoryViewModelTests()
{
_service = new FakeOpcUaClientService
{
HistoryRawResult =
[
new DataValue(new Variant(10), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow),
new DataValue(new Variant(20), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow)
],
HistoryAggregateResult =
[
new DataValue(new Variant(15.0), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow)
]
};
var dispatcher = new SynchronousUiDispatcher();
_vm = new HistoryViewModel(_service, dispatcher);
}
[Fact]
public void ReadHistoryCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadHistoryCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadHistoryCommand_CannotExecute_WhenNoNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = null;
_vm.ReadHistoryCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadHistoryCommand_CanExecute_WhenConnectedAndNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadHistoryCommand.CanExecute(null).ShouldBeTrue();
}
[Fact]
public async Task ReadHistoryCommand_Raw_PopulatesResults()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.SelectedAggregateType = null; // Raw
await _vm.ReadHistoryCommand.ExecuteAsync(null);
_vm.Results.Count.ShouldBe(2);
_vm.Results[0].Value.ShouldBe("10");
_vm.Results[1].Value.ShouldBe("20");
_service.HistoryReadRawCallCount.ShouldBe(1);
_service.HistoryReadAggregateCallCount.ShouldBe(0);
}
[Fact]
public async Task ReadHistoryCommand_Aggregate_PopulatesResults()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.SelectedAggregateType = AggregateType.Average;
await _vm.ReadHistoryCommand.ExecuteAsync(null);
_vm.Results.Count.ShouldBe(1);
_vm.Results[0].Value.ShouldBe("15");
_service.HistoryReadAggregateCallCount.ShouldBe(1);
_service.LastAggregateType.ShouldBe(AggregateType.Average);
_service.HistoryReadRawCallCount.ShouldBe(0);
}
[Fact]
public async Task ReadHistoryCommand_ClearsResultsBefore()
{
_vm.Results.Add(new HistoryValueViewModel("old", "Good", "t1", "t2"));
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
await _vm.ReadHistoryCommand.ExecuteAsync(null);
_vm.Results.ShouldNotContain(r => r.Value == "old");
}
[Fact]
public async Task ReadHistoryCommand_IsLoading_FalseAfterComplete()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
await _vm.ReadHistoryCommand.ExecuteAsync(null);
_vm.IsLoading.ShouldBeFalse();
}
[Fact]
public void DefaultValues_AreCorrect()
{
_vm.MaxValues.ShouldBe(1000);
_vm.IntervalMs.ShouldBe(3600000);
_vm.SelectedAggregateType.ShouldBeNull();
_vm.IsAggregateRead.ShouldBeFalse();
}
[Fact]
public void IsAggregateRead_TrueWhenAggregateSelected()
{
_vm.SelectedAggregateType = AggregateType.Maximum;
_vm.IsAggregateRead.ShouldBeTrue();
}
[Fact]
public void AggregateTypes_ContainsNullForRaw()
{
_vm.AggregateTypes.ShouldContain((AggregateType?)null);
_vm.AggregateTypes.Count.ShouldBe(8); // null + 7 enum values
}
[Fact]
public void Clear_ResetsState()
{
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.Results.Add(new HistoryValueViewModel("v", "s", "t1", "t2"));
_vm.Clear();
_vm.Results.ShouldBeEmpty();
_vm.SelectedNodeId.ShouldBeNull();
}
[Fact]
public async Task ReadHistoryCommand_Error_ShowsErrorInResults()
{
_service.HistoryException = new Exception("History not supported");
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
await _vm.ReadHistoryCommand.ExecuteAsync(null);
_vm.Results.Count.ShouldBe(1);
_vm.Results[0].Value.ShouldContain("History not supported");
}
}

View File

@@ -0,0 +1,542 @@
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
using ConnectionState = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.ConnectionState;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
/// <summary>
/// Verifies the main UI shell behavior for connection state, settings persistence, browsing, subscriptions, and history navigation.
/// </summary>
public class MainWindowViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly FakeSettingsService _settingsService;
private readonly MainWindowViewModel _vm;
public MainWindowViewModelTests()
{
_service = new FakeOpcUaClientService
{
ConnectResult = new ConnectionInfo(
"opc.tcp://localhost:4840",
"TestServer",
"None",
"http://opcfoundation.org/UA/SecurityPolicy#None",
"session-1",
"TestSession"),
BrowseResults =
[
new BrowseResult("ns=2;s=Root", "Root", "Object", true)
],
RedundancyResult = new RedundancyInfo("None", 200, ["urn:test"], "urn:test")
};
_settingsService = new FakeSettingsService();
var factory = new FakeOpcUaClientServiceFactory(_service);
var dispatcher = new SynchronousUiDispatcher();
_vm = new MainWindowViewModel(factory, dispatcher, _settingsService);
}
/// <summary>
/// Verifies that the shell starts disconnected with the default endpoint and status text.
/// </summary>
[Fact]
public void DefaultState_IsDisconnected()
{
_vm.ConnectionState.ShouldBe(ConnectionState.Disconnected);
_vm.IsConnected.ShouldBeFalse();
_vm.EndpointUrl.ShouldBe("opc.tcp://localhost:4840");
_vm.StatusMessage.ShouldBe("Disconnected");
}
/// <summary>
/// Verifies that the connect command is available before a session is established.
/// </summary>
[Fact]
public void ConnectCommand_CanExecute_WhenDisconnected()
{
_vm.ConnectCommand.CanExecute(null).ShouldBeTrue();
}
/// <summary>
/// Verifies that disconnect is disabled until a server session is active.
/// </summary>
[Fact]
public void DisconnectCommand_CannotExecute_WhenDisconnected()
{
_vm.DisconnectCommand.CanExecute(null).ShouldBeFalse();
}
/// <summary>
/// Verifies that a successful connect command updates the shell into the connected state.
/// </summary>
[Fact]
public async Task ConnectCommand_TransitionsToConnected()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.ConnectionState.ShouldBe(ConnectionState.Connected);
_vm.IsConnected.ShouldBeTrue();
_service.ConnectCallCount.ShouldBe(1);
}
/// <summary>
/// Verifies that the initial browse tree is loaded after a successful connect.
/// </summary>
[Fact]
public async Task ConnectCommand_LoadsRootNodes()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.BrowseTree.RootNodes.Count.ShouldBe(1);
_vm.BrowseTree.RootNodes[0].DisplayName.ShouldBe("Root");
}
/// <summary>
/// Verifies that redundancy details are fetched and exposed after connecting.
/// </summary>
[Fact]
public async Task ConnectCommand_FetchesRedundancyInfo()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.RedundancyInfo.ShouldNotBeNull();
_vm.RedundancyInfo!.Mode.ShouldBe("None");
_vm.RedundancyInfo.ServiceLevel.ShouldBe((byte)200);
}
/// <summary>
/// Verifies that the session label shows the connected server and session identity.
/// </summary>
[Fact]
public async Task ConnectCommand_SetsSessionLabel()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.SessionLabel.ShouldContain("TestServer");
_vm.SessionLabel.ShouldContain("TestSession");
}
/// <summary>
/// Verifies that disconnect returns the shell to the disconnected state.
/// </summary>
[Fact]
public async Task DisconnectCommand_TransitionsToDisconnected()
{
await _vm.ConnectCommand.ExecuteAsync(null);
await _vm.DisconnectCommand.ExecuteAsync(null);
_vm.ConnectionState.ShouldBe(ConnectionState.Disconnected);
_vm.IsConnected.ShouldBeFalse();
_service.DisconnectCallCount.ShouldBe(1);
}
/// <summary>
/// Verifies that disconnect clears session-specific UI state such as browse data and redundancy details.
/// </summary>
[Fact]
public async Task Disconnect_ClearsStateAndChildren()
{
await _vm.ConnectCommand.ExecuteAsync(null);
await _vm.DisconnectCommand.ExecuteAsync(null);
_vm.SessionLabel.ShouldBe(string.Empty);
_vm.RedundancyInfo.ShouldBeNull();
_vm.BrowseTree.RootNodes.ShouldBeEmpty();
_vm.SubscriptionCount.ShouldBe(0);
}
/// <summary>
/// Verifies that connection-state events from the client update the shell status text and state.
/// </summary>
[Fact]
public async Task ConnectionStateChangedEvent_UpdatesState()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_service.RaiseConnectionStateChanged(
new ConnectionStateChangedEventArgs(ConnectionState.Connected, ConnectionState.Reconnecting,
"opc.tcp://localhost:4840"));
_vm.ConnectionState.ShouldBe(ConnectionState.Reconnecting);
_vm.StatusMessage.ShouldBe("Reconnecting...");
}
/// <summary>
/// Verifies that selecting a tree node updates the dependent read/write and history panels.
/// </summary>
[Fact]
public async Task SelectedTreeNode_PropagatesToChildViewModels()
{
await _vm.ConnectCommand.ExecuteAsync(null);
var node = _vm.BrowseTree.RootNodes[0];
_vm.SelectedTreeNode = node;
_vm.ReadWrite.SelectedNodeId.ShouldBe(node.NodeId);
_vm.History.SelectedNodeId.ShouldBe(node.NodeId);
}
/// <summary>
/// Verifies that a successful connect propagates connected state into the child tabs.
/// </summary>
[Fact]
public async Task ConnectCommand_PropagatesIsConnectedToChildViewModels()
{
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.ReadWrite.IsConnected.ShouldBeTrue();
_vm.Subscriptions.IsConnected.ShouldBeTrue();
_vm.Alarms.IsConnected.ShouldBeTrue();
_vm.History.IsConnected.ShouldBeTrue();
}
/// <summary>
/// Verifies that disconnect propagates disconnected state into the child tabs.
/// </summary>
[Fact]
public async Task DisconnectCommand_PropagatesIsConnectedFalseToChildViewModels()
{
await _vm.ConnectCommand.ExecuteAsync(null);
await _vm.DisconnectCommand.ExecuteAsync(null);
_vm.ReadWrite.IsConnected.ShouldBeFalse();
_vm.Subscriptions.IsConnected.ShouldBeFalse();
_vm.Alarms.IsConnected.ShouldBeFalse();
_vm.History.IsConnected.ShouldBeFalse();
}
/// <summary>
/// Verifies that failed connection attempts restore the disconnected shell state and surface the error text.
/// </summary>
[Fact]
public async Task ConnectFailure_RevertsToDisconnected()
{
_service.ConnectException = new Exception("Connection refused");
await _vm.ConnectCommand.ExecuteAsync(null);
_vm.ConnectionState.ShouldBe(ConnectionState.Disconnected);
_vm.StatusMessage.ShouldContain("Connection refused");
}
/// <summary>
/// Verifies that connection-state transitions raise property-changed notifications for UI binding updates.
/// </summary>
[Fact]
public async Task PropertyChanged_FiredForConnectionState()
{
await _vm.ConnectCommand.ExecuteAsync(null);
var changed = new List<string>();
_vm.PropertyChanged += (_, e) => changed.Add(e.PropertyName!);
_service.RaiseConnectionStateChanged(
new ConnectionStateChangedEventArgs(ConnectionState.Connected, ConnectionState.Reconnecting,
"opc.tcp://localhost:4840"));
changed.ShouldContain(nameof(MainWindowViewModel.ConnectionState));
}
/// <summary>
/// Verifies that the shell initializes advanced connection settings with the expected defaults.
/// </summary>
[Fact]
public void DefaultState_HasCorrectAdvancedSettings()
{
_vm.FailoverUrls.ShouldBeNull();
_vm.SessionTimeoutSeconds.ShouldBe(60);
_vm.AutoAcceptCertificates.ShouldBeTrue();
_vm.CertificateStorePath.ShouldContain("LmxOpcUaClient");
_vm.CertificateStorePath.ShouldContain("pki");
}
/// <summary>
/// Verifies that failover endpoint text is parsed into connection settings on connect.
/// </summary>
[Fact]
public async Task ConnectCommand_MapsFailoverUrlsToSettings()
{
_vm.FailoverUrls = "opc.tcp://backup1:4840, opc.tcp://backup2:4840";
await _vm.ConnectCommand.ExecuteAsync(null);
_service.LastConnectionSettings.ShouldNotBeNull();
_service.LastConnectionSettings!.FailoverUrls.ShouldNotBeNull();
_service.LastConnectionSettings.FailoverUrls!.Length.ShouldBe(2);
_service.LastConnectionSettings.FailoverUrls[0].ShouldBe("opc.tcp://backup1:4840");
_service.LastConnectionSettings.FailoverUrls[1].ShouldBe("opc.tcp://backup2:4840");
}
/// <summary>
/// Verifies that empty failover text is normalized to no configured failover endpoints.
/// </summary>
[Fact]
public async Task ConnectCommand_MapsEmptyFailoverUrlsToNull()
{
_vm.FailoverUrls = "";
await _vm.ConnectCommand.ExecuteAsync(null);
_service.LastConnectionSettings.ShouldNotBeNull();
_service.LastConnectionSettings!.FailoverUrls.ShouldBeNull();
}
/// <summary>
/// Verifies that the configured session timeout is passed into the connection settings.
/// </summary>
[Fact]
public async Task ConnectCommand_MapsSessionTimeoutToSettings()
{
_vm.SessionTimeoutSeconds = 120;
await _vm.ConnectCommand.ExecuteAsync(null);
_service.LastConnectionSettings.ShouldNotBeNull();
_service.LastConnectionSettings!.SessionTimeoutSeconds.ShouldBe(120);
}
/// <summary>
/// Verifies that the auto-accept certificate toggle is passed into the connection settings.
/// </summary>
[Fact]
public async Task ConnectCommand_MapsAutoAcceptCertificatesToSettings()
{
_vm.AutoAcceptCertificates = false;
await _vm.ConnectCommand.ExecuteAsync(null);
_service.LastConnectionSettings.ShouldNotBeNull();
_service.LastConnectionSettings!.AutoAcceptCertificates.ShouldBeFalse();
}
/// <summary>
/// Verifies that a custom certificate store path is passed into the connection settings.
/// </summary>
[Fact]
public async Task ConnectCommand_MapsCertificateStorePathToSettings()
{
_vm.CertificateStorePath = "/custom/pki/path";
await _vm.ConnectCommand.ExecuteAsync(null);
_service.LastConnectionSettings.ShouldNotBeNull();
_service.LastConnectionSettings!.CertificateStorePath.ShouldBe("/custom/pki/path");
}
/// <summary>
/// Verifies that subscribing selected nodes adds subscriptions and switches the shell to the subscriptions tab.
/// </summary>
[Fact]
public async Task SubscribeSelectedNodesCommand_SubscribesAndSwitchesToTab()
{
await _vm.ConnectCommand.ExecuteAsync(null);
// Use a Variable node so recursive subscribe subscribes it directly
var varNode = new TreeNodeViewModel(
"ns=2;s=TestVar", "TestVar", "Variable", false, _service, new SynchronousUiDispatcher());
_vm.SelectedTreeNodes.Add(varNode);
await _vm.SubscribeSelectedNodesCommand.ExecuteAsync(null);
_vm.Subscriptions!.ActiveSubscriptions.Count.ShouldBe(1);
_vm.Subscriptions.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=TestVar");
_vm.SelectedTabIndex.ShouldBe(1);
}
/// <summary>
/// Verifies that subscribing selected nodes is a no-op when nothing is selected.
/// </summary>
[Fact]
public async Task SubscribeSelectedNodesCommand_DoesNothing_WhenNoSelection()
{
await _vm.ConnectCommand.ExecuteAsync(null);
await _vm.SubscribeSelectedNodesCommand.ExecuteAsync(null);
_vm.Subscriptions.ActiveSubscriptions.ShouldBeEmpty();
}
/// <summary>
/// Verifies that the history command targets the selected node and switches the shell to the history tab.
/// </summary>
[Fact]
public async Task ViewHistoryForSelectedNodeCommand_SetsNodeAndSwitchesToTab()
{
await _vm.ConnectCommand.ExecuteAsync(null);
var node = _vm.BrowseTree.RootNodes[0];
_vm.SelectedTreeNodes.Add(node);
_vm.ViewHistoryForSelectedNodeCommand.Execute(null);
_vm.History.SelectedNodeId.ShouldBe(node.NodeId);
_vm.SelectedTabIndex.ShouldBe(3);
}
/// <summary>
/// Verifies that history actions are enabled when a variable node is selected.
/// </summary>
[Fact]
public async Task UpdateHistoryEnabledForSelection_TrueForVariableNode()
{
await _vm.ConnectCommand.ExecuteAsync(null);
var variableNode = new TreeNodeViewModel(
"ns=2;s=Var1", "Var1", "Variable", false, _service, new SynchronousUiDispatcher());
_vm.SelectedTreeNodes.Add(variableNode);
_vm.UpdateHistoryEnabledForSelection();
_vm.IsHistoryEnabledForSelection.ShouldBeTrue();
}
/// <summary>
/// Verifies that history actions stay disabled when an object node rather than a variable is selected.
/// </summary>
[Fact]
public async Task UpdateHistoryEnabledForSelection_FalseForObjectNode()
{
await _vm.ConnectCommand.ExecuteAsync(null);
var objectNode = new TreeNodeViewModel(
"ns=2;s=Obj1", "Obj1", "Object", true, _service, new SynchronousUiDispatcher());
_vm.SelectedTreeNodes.Add(objectNode);
_vm.UpdateHistoryEnabledForSelection();
_vm.IsHistoryEnabledForSelection.ShouldBeFalse();
}
/// <summary>
/// Verifies that history actions stay disabled when no server connection is active.
/// </summary>
[Fact]
public void UpdateHistoryEnabledForSelection_FalseWhenDisconnected()
{
_vm.UpdateHistoryEnabledForSelection();
_vm.IsHistoryEnabledForSelection.ShouldBeFalse();
}
/// <summary>
/// Verifies that saved user settings are loaded during shell construction.
/// </summary>
[Fact]
public void Constructor_LoadsSettingsFromService()
{
_settingsService.LoadCallCount.ShouldBe(1);
}
/// <summary>
/// Verifies that persisted connection and security settings are applied to the shell on startup.
/// </summary>
[Fact]
public void Constructor_AppliesSavedSettings()
{
var saved = new UserSettings
{
EndpointUrl = "opc.tcp://saved:5555",
Username = "savedUser",
Password = "savedPass",
SecurityMode = SecurityMode.Sign,
FailoverUrls = "opc.tcp://backup:5555",
SessionTimeoutSeconds = 120,
AutoAcceptCertificates = false,
CertificateStorePath = "/custom/path"
};
var settingsService = new FakeSettingsService { Settings = saved };
var service = new FakeOpcUaClientService
{
ConnectResult = _service.ConnectResult,
BrowseResults = _service.BrowseResults,
RedundancyResult = _service.RedundancyResult
};
var factory = new FakeOpcUaClientServiceFactory(service);
var vm = new MainWindowViewModel(factory, new SynchronousUiDispatcher(), settingsService);
vm.EndpointUrl.ShouldBe("opc.tcp://saved:5555");
vm.Username.ShouldBe("savedUser");
vm.Password.ShouldBe("savedPass");
vm.SelectedSecurityMode.ShouldBe(SecurityMode.Sign);
vm.FailoverUrls.ShouldBe("opc.tcp://backup:5555");
vm.SessionTimeoutSeconds.ShouldBe(120);
vm.AutoAcceptCertificates.ShouldBeFalse();
vm.CertificateStorePath.ShouldBe("/custom/path");
}
/// <summary>
/// Verifies that successful connections persist the current connection settings.
/// </summary>
[Fact]
public async Task ConnectCommand_SavesSettingsOnSuccess()
{
_vm.EndpointUrl = "opc.tcp://myserver:4840";
_vm.Username = "admin";
await _vm.ConnectCommand.ExecuteAsync(null);
_settingsService.SaveCallCount.ShouldBe(1);
_settingsService.LastSaved.ShouldNotBeNull();
_settingsService.LastSaved!.EndpointUrl.ShouldBe("opc.tcp://myserver:4840");
_settingsService.LastSaved.Username.ShouldBe("admin");
}
/// <summary>
/// Verifies that failed connection attempts do not overwrite saved settings.
/// </summary>
[Fact]
public async Task ConnectCommand_DoesNotSaveOnFailure()
{
_service.ConnectException = new Exception("Connection refused");
await _vm.ConnectCommand.ExecuteAsync(null);
_settingsService.SaveCallCount.ShouldBe(0);
}
/// <summary>
/// Verifies that active subscriptions are persisted when the shell disconnects.
/// </summary>
[Fact]
public async Task ConnectCommand_SavesSubscribedNodes()
{
await _vm.ConnectCommand.ExecuteAsync(null);
// Add a subscription
_vm.Subscriptions.IsConnected = true;
await _vm.Subscriptions.AddSubscriptionForNodeAsync("ns=2;s=TestSub");
// Disconnect saves settings including subscriptions
await _vm.DisconnectCommand.ExecuteAsync(null);
_settingsService.LastSaved.ShouldNotBeNull();
_settingsService.LastSaved!.SubscribedNodes.ShouldContain("ns=2;s=TestSub");
}
/// <summary>
/// Verifies that saved subscriptions are restored after reconnecting the shell.
/// </summary>
[Fact]
public async Task ConnectCommand_RestoresSavedSubscriptions()
{
_settingsService.Settings.SubscribedNodes = ["ns=2;s=Restored1", "ns=2;s=Restored2"];
var service = new FakeOpcUaClientService
{
ConnectResult = _service.ConnectResult,
BrowseResults = _service.BrowseResults,
RedundancyResult = _service.RedundancyResult
};
var factory = new FakeOpcUaClientServiceFactory(service);
var vm = new MainWindowViewModel(factory, new SynchronousUiDispatcher(), _settingsService);
await vm.ConnectCommand.ExecuteAsync(null);
vm.Subscriptions.ActiveSubscriptions.Count.ShouldBe(2);
vm.Subscriptions.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=Restored1");
vm.Subscriptions.ActiveSubscriptions[1].NodeId.ShouldBe("ns=2;s=Restored2");
vm.SubscriptionCount.ShouldBe(2);
}
}

View File

@@ -0,0 +1,152 @@
using Opc.Ua;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class ReadWriteViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly ReadWriteViewModel _vm;
public ReadWriteViewModelTests()
{
_service = new FakeOpcUaClientService
{
ReadResult = new DataValue(new Variant("TestValue"), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow)
};
var dispatcher = new SynchronousUiDispatcher();
_vm = new ReadWriteViewModel(_service, dispatcher);
}
[Fact]
public void ReadCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadCommand_CannotExecute_WhenNoNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = null;
_vm.ReadCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadCommand_CanExecute_WhenConnectedAndNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadCommand.CanExecute(null).ShouldBeTrue();
}
[Fact]
public async Task ReadCommand_UpdatesValueAndStatus()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
// auto-read fires on selection change, so reset count
var countBefore = _service.ReadCallCount;
await _vm.ReadCommand.ExecuteAsync(null);
_vm.CurrentValue.ShouldBe("TestValue");
_vm.CurrentStatus.ShouldNotBeNull();
_vm.SourceTimestamp.ShouldNotBeNull();
_vm.ServerTimestamp.ShouldNotBeNull();
(_service.ReadCallCount - countBefore).ShouldBe(1);
}
[Fact]
public void AutoRead_OnSelectionChange_WhenConnected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
// The auto-read fires asynchronously; give it a moment
// In synchronous dispatcher it should fire immediately
_service.ReadCallCount.ShouldBeGreaterThanOrEqualTo(1);
}
[Fact]
public void NullSelection_DoesNotCallService()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = null;
_service.ReadCallCount.ShouldBe(0);
}
[Fact]
public async Task WriteCommand_UpdatesWriteStatus()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteValue = "NewValue";
// Reset read count from auto-read
var readCountBefore = _service.ReadCallCount;
await _vm.WriteCommand.ExecuteAsync(null);
_vm.WriteStatus.ShouldNotBeNull();
_service.WriteCallCount.ShouldBe(1);
_service.LastWriteValue.ShouldBe("NewValue");
}
[Fact]
public void WriteCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task ReadCommand_Error_SetsErrorStatus()
{
_service.ReadException = new Exception("Read failed");
_vm.IsConnected = true;
// We need to set SelectedNodeId and manually trigger read
// because auto-read catches the exception too
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.CurrentStatus.ShouldContain("Error");
}
[Fact]
public void Clear_ResetsAllProperties()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteValue = "test";
_vm.WriteStatus = "Good";
_vm.Clear();
_vm.SelectedNodeId.ShouldBeNull();
_vm.CurrentValue.ShouldBeNull();
_vm.CurrentStatus.ShouldBeNull();
_vm.SourceTimestamp.ShouldBeNull();
_vm.ServerTimestamp.ShouldBeNull();
_vm.WriteValue.ShouldBeNull();
_vm.WriteStatus.ShouldBeNull();
}
[Fact]
public void IsNodeSelected_TracksSelectedNodeId()
{
_vm.IsNodeSelected.ShouldBeFalse();
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.IsNodeSelected.ShouldBeTrue();
_vm.SelectedNodeId = null;
_vm.IsNodeSelected.ShouldBeFalse();
}
}

View File

@@ -0,0 +1,299 @@
using Opc.Ua;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class SubscriptionsViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly SubscriptionsViewModel _vm;
public SubscriptionsViewModelTests()
{
_service = new FakeOpcUaClientService();
var dispatcher = new SynchronousUiDispatcher();
_vm = new SubscriptionsViewModel(_service, dispatcher);
}
[Fact]
public void AddSubscriptionCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.NewNodeIdText = "ns=2;s=SomeNode";
_vm.AddSubscriptionCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void AddSubscriptionCommand_CannotExecute_WhenNoNodeId()
{
_vm.IsConnected = true;
_vm.NewNodeIdText = null;
_vm.AddSubscriptionCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task AddSubscriptionCommand_AddsItem()
{
_vm.IsConnected = true;
_vm.NewNodeIdText = "ns=2;s=SomeNode";
_vm.NewInterval = 500;
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
_vm.ActiveSubscriptions.Count.ShouldBe(1);
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=SomeNode");
_vm.ActiveSubscriptions[0].IntervalMs.ShouldBe(500);
_vm.SubscriptionCount.ShouldBe(1);
_service.SubscribeCallCount.ShouldBe(1);
}
[Fact]
public async Task RemoveSubscriptionCommand_RemovesItem()
{
_vm.IsConnected = true;
_vm.NewNodeIdText = "ns=2;s=SomeNode";
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
_vm.SelectedSubscription = _vm.ActiveSubscriptions[0];
await _vm.RemoveSubscriptionCommand.ExecuteAsync(null);
_vm.ActiveSubscriptions.ShouldBeEmpty();
_vm.SubscriptionCount.ShouldBe(0);
_service.UnsubscribeCallCount.ShouldBe(1);
}
[Fact]
public void RemoveSubscriptionCommand_CannotExecute_WhenNoSelection()
{
_vm.IsConnected = true;
_vm.SelectedSubscription = null;
_vm.RemoveSubscriptionCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task DataChanged_UpdatesMatchingRow()
{
_vm.IsConnected = true;
_vm.NewNodeIdText = "ns=2;s=SomeNode";
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=SomeNode", dataValue));
_vm.ActiveSubscriptions[0].Value.ShouldBe("42");
_vm.ActiveSubscriptions[0].Status.ShouldNotBeNull();
}
[Fact]
public async Task DataChanged_DoesNotUpdateNonMatchingRow()
{
_vm.IsConnected = true;
_vm.NewNodeIdText = "ns=2;s=SomeNode";
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=OtherNode", dataValue));
_vm.ActiveSubscriptions[0].Value.ShouldBeNull();
}
[Fact]
public void Clear_RemovesAllSubscriptions()
{
_vm.ActiveSubscriptions.Add(new SubscriptionItemViewModel("ns=2;s=X", 1000));
_vm.SubscriptionCount = 1;
_vm.Clear();
_vm.ActiveSubscriptions.ShouldBeEmpty();
_vm.SubscriptionCount.ShouldBe(0);
}
[Fact]
public void Teardown_UnhooksEventHandler()
{
_vm.Teardown();
// After teardown, raising event should not update anything
_vm.ActiveSubscriptions.Add(new SubscriptionItemViewModel("ns=2;s=X", 1000));
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=X", dataValue));
_vm.ActiveSubscriptions[0].Value.ShouldBeNull();
}
[Fact]
public void DefaultInterval_Is1000()
{
_vm.NewInterval.ShouldBe(1000);
}
[Fact]
public async Task AddSubscriptionForNodeAsync_AddsSubscription()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
_vm.ActiveSubscriptions.Count.ShouldBe(1);
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=TestNode");
_vm.SubscriptionCount.ShouldBe(1);
_service.SubscribeCallCount.ShouldBe(1);
}
[Fact]
public async Task AddSubscriptionForNodeAsync_SkipsDuplicate()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
_vm.ActiveSubscriptions.Count.ShouldBe(1);
_service.SubscribeCallCount.ShouldBe(1);
}
[Fact]
public async Task AddSubscriptionForNodeAsync_DoesNothing_WhenDisconnected()
{
_vm.IsConnected = false;
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
_vm.ActiveSubscriptions.ShouldBeEmpty();
_service.SubscribeCallCount.ShouldBe(0);
}
[Fact]
public async Task GetSubscribedNodeIds_ReturnsActiveNodeIds()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node1");
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node2");
var ids = _vm.GetSubscribedNodeIds();
ids.Count.ShouldBe(2);
ids.ShouldContain("ns=2;s=Node1");
ids.ShouldContain("ns=2;s=Node2");
}
[Fact]
public async Task RestoreSubscriptionsAsync_SubscribesAllNodes()
{
_vm.IsConnected = true;
await _vm.RestoreSubscriptionsAsync(["ns=2;s=A", "ns=2;s=B"]);
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_service.SubscribeCallCount.ShouldBe(2);
}
[Fact]
public async Task ValidateAndWriteAsync_SuccessReturnsTrue()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteResult = Opc.Ua.StatusCodes.Good;
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "99");
success.ShouldBeTrue();
message.ShouldContain("Good");
_service.WriteCallCount.ShouldBe(1);
}
[Fact]
public async Task ValidateAndWriteAsync_ParseFailureReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "not-a-number");
success.ShouldBeFalse();
message.ShouldContain("Cannot parse");
message.ShouldContain("Int32");
_service.WriteCallCount.ShouldBe(0);
}
[Fact]
public async Task ValidateAndWriteAsync_WriteFailureReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteException = new Exception("Access denied");
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
success.ShouldBeFalse();
message.ShouldContain("Access denied");
}
[Fact]
public async Task ValidateAndWriteAsync_BadStatusReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteResult = Opc.Ua.StatusCodes.BadNotWritable;
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
success.ShouldBeFalse();
message.ShouldContain("Write failed");
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_SubscribesVariableDirectly()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Var1", "Variable");
_vm.ActiveSubscriptions.Count.ShouldBe(1);
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=Var1");
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_BrowsesObjectAndSubscribesVariableChildren()
{
_vm.IsConnected = true;
_service.BrowseResultsByParent["ns=2;s=Folder"] =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false),
new BrowseResult("ns=2;s=Child2", "Child2", "Variable", false)
];
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Folder", "Object");
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_service.SubscribeCallCount.ShouldBe(2);
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_RecursesNestedObjects()
{
_vm.IsConnected = true;
_service.BrowseResultsByParent["ns=2;s=Root"] =
[
new BrowseResult("ns=2;s=SubFolder", "SubFolder", "Object", true),
new BrowseResult("ns=2;s=RootVar", "RootVar", "Variable", false)
];
_service.BrowseResultsByParent["ns=2;s=SubFolder"] =
[
new BrowseResult("ns=2;s=DeepVar", "DeepVar", "Variable", false)
];
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Root", "Object");
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=RootVar");
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=DeepVar");
}
}

View File

@@ -0,0 +1,29 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
<RootNamespace>ZB.MOM.WW.OtOpcUa.Client.UI.Tests</RootNamespace>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Avalonia.Headless" Version="11.2.7"/>
<PackageReference Include="Avalonia.Themes.Fluent" Version="11.2.7"/>
<PackageReference Include="xunit.v3" Version="1.1.0"/>
<PackageReference Include="Shouldly" Version="4.3.0"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0"/>
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\ZB.MOM.WW.OtOpcUa.Client.UI\ZB.MOM.WW.OtOpcUa.Client.UI.csproj"/>
<ProjectReference Include="..\..\src\ZB.MOM.WW.OtOpcUa.Client.Shared\ZB.MOM.WW.OtOpcUa.Client.Shared.csproj"/>
</ItemGroup>
</Project>