Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*

Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.

Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.

Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-04-17 13:57:47 -04:00
parent 5b8d708c58
commit 3b2defd94f
293 changed files with 841 additions and 722 deletions

View File

@@ -0,0 +1,36 @@
using Opc.Ua;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Helpers;
/// <summary>
/// Formats OPC UA status codes as "0xHEX (description)".
/// </summary>
internal static class StatusCodeFormatter
{
public static string Format(StatusCode statusCode)
{
var code = statusCode.Code;
var hex = $"0x{code:X8}";
// Try the SDK's browse name lookup first
var name = StatusCodes.GetBrowseName(code);
if (!string.IsNullOrEmpty(name))
return $"{hex} ({name})";
// Try masking to just the main code (top 16 bits) for sub-status codes
var mainCode = code & 0xFFFF0000;
if (mainCode != code)
{
name = StatusCodes.GetBrowseName(mainCode);
if (!string.IsNullOrEmpty(name))
return $"{hex} ({name})";
}
// Fallback to severity category
if (StatusCode.IsGood(statusCode))
return $"{hex} (Good)";
if (StatusCode.IsBad(statusCode))
return $"{hex} (Bad)";
return $"{hex} (Uncertain)";
}
}

View File

@@ -0,0 +1,33 @@
using System.Collections;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Helpers;
/// <summary>
/// Formats OPC UA values for display, with array support.
/// </summary>
internal static class ValueFormatter
{
public static string Format(object? value)
{
if (value is null) return "(null)";
if (value is Array array) return FormatArray(array);
if (value is IEnumerable enumerable and not string) return FormatEnumerable(enumerable);
return value.ToString() ?? "(null)";
}
private static string FormatArray(Array array)
{
var elements = new string[array.Length];
for (var i = 0; i < array.Length; i++)
elements[i] = array.GetValue(i)?.ToString() ?? "null";
return $"[{string.Join(",", elements)}]";
}
private static string FormatEnumerable(IEnumerable enumerable)
{
var items = new List<string>();
foreach (var item in enumerable)
items.Add(item?.ToString() ?? "null");
return $"[{string.Join(",", items)}]";
}
}