refactor(runtime): delete the dead in-place ApplyDelta seam; config change = respawn only (#665)

Since #516 a DriverConfig change is stop + respawn, so DriverSpawnPlan.ToApplyDelta was always empty and the in-place path had no producer. #663 and #664 were both latent bugs in it. This deletes it: - host: ApplyChildDelta, _pendingDelta, HandleApplyResult and HandleDeltaApplied - plan: DriverSpawnPlan.ToApplyDelta - actor: the ApplyDelta, ApplyResult and DeltaApplied messages, the Connected reinit handler and the mid-connect AdoptConfigDuringInit - tests: the actor tests that drove the seam IDriver.ReinitializeAsync and each driver's implementation and unit tests stay. Comments and docs that cited AdoptConfigDuringInit as the reason a driver must release prior state at init now cite the IDriver contract and overlapping retries, which still apply. Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
2026-10-09 11:23:16 -04:00
parent f622d0be2d
commit 1ea1da8236
33 changed files with 112 additions and 559 deletions
@@ -225,8 +225,8 @@ public sealed class S7Driver
    /// <inheritdoc />
    public async Task InitializeAsync(string driverConfigJson, CancellationToken cancellationToken)
    {
-        // #630: InitializeAsync is reachable on a live driver (DriverInstanceActor.AdoptConfigDuringInit
-        // runs it with no teardown first). Stop the previous probe loop and drop the previous connection
+        // #630: InitializeAsync is reachable on a live driver with no teardown first (the IDriver contract
+        // allows it, and a reconnect retry can overlap a running attempt). Stop the previous probe loop and drop the previous connection
        // before they are overwritten below. Deliberately NOT ShutdownAsync: that also drops _poll and the
        // subscriptions, which are owned by the shutdown path (the actor re-subscribes after every successful init).
        await ReleaseConnectionAsync().ConfigureAwait(false);