dohertj2/lmxopcua
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add UI features, alarm ack, historian UTC fix, and Client.UI documentation

Browse Source 
Major changes across the client stack:
- Settings persistence (connection, subscriptions, alarm source)
- Deferred OPC UA SDK init for instant startup
- Array/status code formatting, write value popup, alarm acknowledgment
- Severity-colored alarm rows, condition dedup on server side
- DateTimeRangePicker control with preset buttons and UTC text input
- Historian queries use wwTimezone=UTC and OPCQuality column
- Recursive subscribe from tree, multi-select remove
- Connection panel with expander, folder chooser for cert path
- Dynamic tab headers showing subscription/alarm counts
- Client.UI.md documentation with headless-rendered screenshots

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-03-31 20:46:45 -04:00
parent 8fae2cb790
commit 188cbf7d24
53 changed files with 2652 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

128
tests/ZB.MOM.WW.LmxOpcUa.Client.UI.Tests/SubscriptionsViewModelTests.cs
View File

@@ -5,6 +5,7 @@ using ZB.MOM.WW.LmxOpcUa.Client.Shared.Models;
using ZB.MOM.WW.LmxOpcUa.Client.UI.Services;
using ZB.MOM.WW.LmxOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.LmxOpcUa.Client.UI.ViewModels;
using BrowseResult = ZB.MOM.WW.LmxOpcUa.Client.Shared.Models.BrowseResult;
namespace ZB.MOM.WW.LmxOpcUa.Client.UI.Tests;
@@ -168,4 +169,131 @@ public class SubscriptionsViewModelTests
_vm.ActiveSubscriptions.ShouldBeEmpty();
_service.SubscribeCallCount.ShouldBe(0);
}
[Fact]
public async Task GetSubscribedNodeIds_ReturnsActiveNodeIds()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node1");
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node2");
var ids = _vm.GetSubscribedNodeIds();
ids.Count.ShouldBe(2);
ids.ShouldContain("ns=2;s=Node1");
ids.ShouldContain("ns=2;s=Node2");
}
[Fact]
public async Task RestoreSubscriptionsAsync_SubscribesAllNodes()
{
_vm.IsConnected = true;
await _vm.RestoreSubscriptionsAsync(["ns=2;s=A", "ns=2;s=B"]);
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_service.SubscribeCallCount.ShouldBe(2);
}
[Fact]
public async Task ValidateAndWriteAsync_SuccessReturnsTrue()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteResult = Opc.Ua.StatusCodes.Good;
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "99");
success.ShouldBeTrue();
message.ShouldContain("Good");
_service.WriteCallCount.ShouldBe(1);
}
[Fact]
public async Task ValidateAndWriteAsync_ParseFailureReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "not-a-number");
success.ShouldBeFalse();
message.ShouldContain("Cannot parse");
message.ShouldContain("Int32");
_service.WriteCallCount.ShouldBe(0);
}
[Fact]
public async Task ValidateAndWriteAsync_WriteFailureReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteException = new Exception("Access denied");
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
success.ShouldBeFalse();
message.ShouldContain("Access denied");
}
[Fact]
public async Task ValidateAndWriteAsync_BadStatusReturnsFalse()
{
_vm.IsConnected = true;
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
_service.WriteResult = Opc.Ua.StatusCodes.BadNotWritable;
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
success.ShouldBeFalse();
message.ShouldContain("Write failed");
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_SubscribesVariableDirectly()
{
_vm.IsConnected = true;
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Var1", "Variable");
_vm.ActiveSubscriptions.Count.ShouldBe(1);
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=Var1");
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_BrowsesObjectAndSubscribesVariableChildren()
{
_vm.IsConnected = true;
_service.BrowseResultsByParent["ns=2;s=Folder"] =
[
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false),
new BrowseResult("ns=2;s=Child2", "Child2", "Variable", false)
];
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Folder", "Object");
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_service.SubscribeCallCount.ShouldBe(2);
}
[Fact]
public async Task AddSubscriptionRecursiveAsync_RecursesNestedObjects()
{
_vm.IsConnected = true;
_service.BrowseResultsByParent["ns=2;s=Root"] =
[
new BrowseResult("ns=2;s=SubFolder", "SubFolder", "Object", true),
new BrowseResult("ns=2;s=RootVar", "RootVar", "Variable", false)
];
_service.BrowseResultsByParent["ns=2;s=SubFolder"] =
[
new BrowseResult("ns=2;s=DeepVar", "DeepVar", "Variable", false)
];
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Root", "Object");
_vm.ActiveSubscriptions.Count.ShouldBe(2);
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=RootVar");
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=DeepVar");
}
}