dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(scripting): clarify sandbox-pin invariant + add RootNamespace (A0 review)

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-07 15:16:14 -04:00
parent 56cac39216
commit 1827c51c42
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Core/ZB.MOM.WW.OtOpcUa.Core.Scripting.Abstractions/ZB.MOM.WW.OtOpcUa.Core.Scripting.Abstractions.csproj
+1
View File
@@ -8,6 +8,7 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors> <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);CS1591</NoWarn> <NoWarn>$(NoWarn);CS1591</NoWarn>
<RootNamespace>ZB.MOM.WW.OtOpcUa.Core.Scripting</RootNamespace>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
src/Core/ZB.MOM.WW.OtOpcUa.Core.Scripting/ScriptSandbox.cs
+3 -1
View File
@@ -56,7 +56,9 @@ public static class ScriptSandbox
// Core.Abstractions — DataValueSnapshot + DriverDataType so scripts can name // Core.Abstractions — DataValueSnapshot + DriverDataType so scripts can name
// the types they receive from ctx.GetTag. // the types they receive from ctx.GetTag.
typeof(DataValueSnapshot).Assembly, typeof(DataValueSnapshot).Assembly,
// Core.Scripting itself — ScriptContext base class + Deadband static. // Core.Scripting.Abstractions — ScriptContext base class + Deadband static.
// Intentionally NOT Core.Scripting (which holds ScriptEvaluator/ScriptSandbox + Roslyn):
// keeping it out of the sandbox pin keeps Roslyn out of the globalsType assembly closure.
typeof(ScriptContext).Assembly, typeof(ScriptContext).Assembly,
// Serilog.ILogger — script-side logger type. // Serilog.ILogger — script-side logger type.
typeof(Serilog.ILogger).Assembly, typeof(Serilog.ILogger).Assembly,