Merge branch 'fix/r3-02-stale-good-family' — R3-02: one quality contract at four seams — comms loss marks raw+UNS value variables BadNoCommunication (WriteStatuses sink member, recovery audit), Calculation + VT hold on Bad / worst-of sub-code / (value,status) dedup, MQTT initial push + ConnectionLost stale, Sparkplug birth replay (archreview 03/S15, 05/STAB-19, 05/STAB-18, 02/S14)

2026-08-20 11:49:06 -04:00
parent f1b976f5e2 886082fec7
commit 157d01c2c2
46 changed files with 4340 additions and 129 deletions
@@ -1423,6 +1423,21 @@ public sealed class DriverInstanceActor : ReceiveActor, IWithTimers
    /// <inheritdoc />
    protected override void PostStop()
    {
+        // Archreview 03/S15 — announce comms loss on the way out. Every OTHER route into Reconnecting
+        // (watchdog trip, failed initial connect, Force Reconnect) announces it from the Reconnecting
+        // entry; stopping did not, so an operator's Restart and a supervision respawn tore this child down
+        // silently and its value nodes went on serving their last value at Good across the gap. The fresh
+        // child's re-subscribe + initial push (03/S16) is what clears them again; on a deploy that REMOVES
+        // the driver the host has already rebuilt its ref index without it, so the Tell finds nothing.
+        //
+        // Gated on having actually reached Connected: a child that never connected leaves its nodes at
+        // BadWaitingForInitialData, which says something more precise than "communication lost", and
+        // overwriting it would claim an outage that never happened.
+        if (_connectedSinceUtc != default)
+        {
+            Context.Parent.Tell(new ConnectivityChanged(_driverInstanceId, Connected: false));
+        }
+
        DetachSubscription();
        // MUST happen: the IDriver instance can outlive this actor (the host respawns a child around the
        // same driver object), so a missing unsubscribe accumulates a handler per respawn holding a dead Self.