fix(opcuaclient): review fixes - drop driver-side OperationLimits chunking (SDK batches), diagnostics as OTel counter, safe discovery selection, options validation at load (#273 #275 #276 #277 #278)

Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
2026-10-08 14:55:53 -04:00
parent 935ba8d1d4
commit 1219b7b13e
13 changed files with 406 additions and 652 deletions
@@ -86,8 +86,18 @@ public static class OpcUaClientDriverFactoryExtensions
        ArgumentException.ThrowIfNullOrWhiteSpace(driverInstanceId);
        ArgumentException.ThrowIfNullOrWhiteSpace(driverConfigJson);

-        return JsonSerializer.Deserialize<OpcUaClientDriverOptions>(driverConfigJson, JsonOptions)
+        var options = JsonSerializer.Deserialize<OpcUaClientDriverOptions>(driverConfigJson, JsonOptions)
            ?? throw new InvalidOperationException(
                $"OpcUaClient driver config for '{driverInstanceId}' deserialised to null");
+
+        // #273/#278: nothing runs DataAnnotations on driver options, so range-check here — at options load —
+        // and fail with a clear message instead of a driver that faults and retries forever.
+        try { OpcUaClientDriver.ValidateTuning(options); }
+        catch (InvalidOperationException ex)
+        {
+            throw new InvalidOperationException(
+                $"OpcUaClient driver config for '{driverInstanceId}' is invalid: {ex.Message}", ex);
+        }
+        return options;
    }
 }