review(Driver.Cli.Common): drop dead FormatStatus branch + timestamp-kind test

Re-review at 7286d320. -009: remove unreachable name-is-null branch in FormatStatus +
invariant test. -010: pin DateTimeKind.Unspecified FormatTimestamp behavior.
This commit is contained in:
Joseph Doherty
2026-06-19 11:21:36 -04:00
parent 13c1215811
commit 1180b017f5
3 changed files with 139 additions and 5 deletions
@@ -156,9 +156,9 @@ public static class SnapshotFormatter
};
}
return name is null
? $"0x{statusCode:X8}"
: $"0x{statusCode:X8} ({name})";
// name is always non-null here: the named shortlist assigns it directly, and
// the severity-class fallback above assigns one of "Good" / "Uncertain" / "Bad".
return $"0x{statusCode:X8} ({name})";
}
/// <summary>Formats a UTC timestamp as an ISO 8601 string, or "-" if null.</summary>