fix(historian): defensive over-fetch cap + Validate gating comment (review)

2026-06-17 20:22:07 -04:00
parent 4e1414026e
commit 0f929ae668
2 changed files with 6 additions and 1 deletions
@@ -63,6 +63,9 @@ public sealed class ServerHistorianOptions
            warnings.Add("ServerHistorian:SharedSecret is empty while the historian is enabled — the Wonderware sidecar Hello frame will carry an empty secret.");
        if (Port <= 0)
            warnings.Add($"ServerHistorian:Port is {Port} — must be > 0; the read client cannot dial the sidecar.");
+        // MaxTieClusterOverfetch is intentionally checked AFTER the Enabled early-return above:
+        // the over-fetch code path only runs when a real IHistorianDataSource is wired in,
+        // so a zero/negative value is harmless (and noise-free) when the historian is disabled.
        if (MaxTieClusterOverfetch <= 0)
            warnings.Add($"ServerHistorian:MaxTieClusterOverfetch is {MaxTieClusterOverfetch} — must be > 0; HistoryRead-Raw cannot page within an oversized tie cluster and will surface BadHistoryOperationUnsupported for those reads.");
        return warnings;