dohertj2/lmxopcua
1
0
Fork 0
Code Issues 5 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(telemetry): export the Galaxy driver's spans and galaxy.events.* counters (#892)

Browse Source 
ZbTelemetryOptions.Meters/ActivitySources are strict allowlists. The host named only
ZB.MOM.WW.OtOpcUa and the LocalDb meter, so the in-process Galaxy driver's galaxy.* spans
and its event pump's galaxy.events.* counters (both on "ZB.MOM.WW.OtOpcUa.Driver.Galaxy")
were silently dropped from /metrics and OTLP. Found exercising OTLP end to end against a
collector (scadaproj#13).

- Galaxy driver: public GalaxyDriverTelemetryNames (MeterName / ActivitySourceName);
  GalaxyTelemetry and EventPump reference it.
- Host: ObservabilityExtensions.ObservedMeters / ObservedActivitySources include it.
- Host.IntegrationTests: ObservabilityAllowlistTests assert on the listener side (span
  sampled, instrument enabled) with an unregistered-name negative control; dropping the
  Galaxy entries fails 3 of 8.

Claude-Session: https://claude.ai/code/session_01GT67ACmpMR7b9LGRPLijMi
This commit is contained in:
Joseph Doherty
2026-11-12 20:31:14 -05:00
parent aaaa55e211
commit 0b90379f70
5 changed files with 135 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Galaxy/GalaxyDriverTelemetryNames.cs
+17
View File
@@ -0,0 +1,17 @@
namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy;
/// <summary>
/// The Galaxy driver's OpenTelemetry instrument names, public so the host can hand them to
/// <c>AddZbTelemetry</c>. <c>ZbTelemetryOptions.Meters</c> and <c>.ActivitySources</c> are
/// STRICT allow-lists: a name missing there is silently never exported — the driver's
/// <c>galaxy.*</c> spans and <c>galaxy.events.*</c> counters were dropped this way until
/// scadaproj#13 exercised the OTLP path end to end.
/// </summary>
public static class GalaxyDriverTelemetryNames
{
/// <summary>The meter the event pump's <c>galaxy.events.*</c> counters are created on.</summary>
public const string MeterName = "ZB.MOM.WW.OtOpcUa.Driver.Galaxy";
/// <summary>The activity source the traced gateway decorators open <c>galaxy.*</c> spans on.</summary>
public const string ActivitySourceName = "ZB.MOM.WW.OtOpcUa.Driver.Galaxy";
}
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Galaxy/Runtime/EventPump.cs
+1 -1
View File
@@ -34,7 +34,7 @@ namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Runtime;
/// </remarks>
internal sealed class EventPump : IAsyncDisposable
{
public const string MeterName = "ZB.MOM.WW.OtOpcUa.Driver.Galaxy";
public const string MeterName = GalaxyDriverTelemetryNames.MeterName;
private const int DefaultChannelCapacity = 50_000;
// Single static meter so a host-level MeterListener catches all pump instances.
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Galaxy/Runtime/GalaxyTelemetry.cs
+1 -1
View File
@@ -17,7 +17,7 @@ namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Runtime;
/// </summary>
internal static class GalaxyTelemetry
{
public const string ActivitySourceName = "ZB.MOM.WW.OtOpcUa.Driver.Galaxy";
public const string ActivitySourceName = GalaxyDriverTelemetryNames.ActivitySourceName;
public static readonly ActivitySource ActivitySource = new(ActivitySourceName);