feat(security): LDAP auth timeout/concurrency/outage-circuit options; project ConnectionTimeoutMs into the shared library (03/S2)

2026-07-13 11:38:37 -04:00
parent ce6d9e21d3
commit 09faa05f06
5 changed files with 197 additions and 1 deletions
@@ -203,6 +203,95 @@ public sealed class LdapOptionsValidatorTests
        result.Failures.ShouldContain("Ldap:SearchBase is required when LDAP login is enabled.");
    }

+    /// <summary>Enabled with a non-positive <c>ConnectionTimeoutMs</c> fails validation (03/S2).</summary>
+    [Fact]
+    public void Enabled_with_nonpositive_ConnectionTimeoutMs_fails()
+    {
+        var options = new LdapOptions
+        {
+            Enabled = true,
+            Server = "ldap",
+            SearchBase = "dc=x",
+            Port = 389,
+            Transport = LdapTransport.Ldaps,
+            ConnectionTimeoutMs = 0,
+        };
+
+        Sut.Validate(null, options).Failed.ShouldBeTrue();
+    }
+
+    /// <summary>Enabled with a non-positive <c>AuthTimeoutMs</c> fails validation (03/S2).</summary>
+    [Fact]
+    public void Enabled_with_nonpositive_AuthTimeoutMs_fails()
+    {
+        var options = new LdapOptions
+        {
+            Enabled = true,
+            Server = "ldap",
+            SearchBase = "dc=x",
+            Port = 389,
+            Transport = LdapTransport.Ldaps,
+            AuthTimeoutMs = 0,
+        };
+
+        Sut.Validate(null, options).Failed.ShouldBeTrue();
+    }
+
+    /// <summary>Enabled with a non-positive <c>MaxConcurrentAuthentications</c> fails validation (03/S2).</summary>
+    [Fact]
+    public void Enabled_with_nonpositive_MaxConcurrentAuthentications_fails()
+    {
+        var options = new LdapOptions
+        {
+            Enabled = true,
+            Server = "ldap",
+            SearchBase = "dc=x",
+            Port = 389,
+            Transport = LdapTransport.Ldaps,
+            MaxConcurrentAuthentications = 0,
+        };
+
+        Sut.Validate(null, options).Failed.ShouldBeTrue();
+    }
+
+    /// <summary>A positive <c>OutageFailureThreshold</c> with a zero <c>OutageCooldownSeconds</c> fails —
+    /// an open circuit with no cooldown would probe on every call (03/S2).</summary>
+    [Fact]
+    public void OutageFailureThreshold_positive_with_zero_cooldown_fails()
+    {
+        var options = new LdapOptions
+        {
+            Enabled = true,
+            Server = "ldap",
+            SearchBase = "dc=x",
+            Port = 389,
+            Transport = LdapTransport.Ldaps,
+            OutageFailureThreshold = 3,
+            OutageCooldownSeconds = 0,
+        };
+
+        Sut.Validate(null, options).Failed.ShouldBeTrue();
+    }
+
+    /// <summary>A zero <c>OutageFailureThreshold</c> (circuit disabled) passes regardless of the
+    /// cooldown value (03/S2).</summary>
+    [Fact]
+    public void OutageFailureThreshold_zero_disables_circuit_and_passes()
+    {
+        var options = new LdapOptions
+        {
+            Enabled = true,
+            Server = "ldap",
+            SearchBase = "dc=x",
+            Port = 389,
+            Transport = LdapTransport.Ldaps,
+            OutageFailureThreshold = 0,
+            OutageCooldownSeconds = 0,
+        };
+
+        Sut.Validate(null, options).Succeeded.ShouldBeTrue();
+    }
+
    /// <summary>Enabled with port 0 reports the port-range failure using the shared primitive wording.</summary>
    [Fact]
    public void Enabled_with_zero_port_fails()