From 066514fed321801c9235500070a9c69134475816 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Mon, 13 Jul 2026 09:55:39 -0400 Subject: [PATCH] =?UTF-8?q?docs(r2-01):=20Finding-1=20close=20gate=20?= =?UTF-8?q?=E2=80=94=20S7=20unit=20238/238=20green;=20record=20pre-existin?= =?UTF-8?q?g=20out-of-scope=20CLI=20comment-test=20failure=20(task=205)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- archreview/plans/R2-01-s7-fault-hardening-plan.md | 4 ++++ archreview/plans/R2-01-s7-fault-hardening-plan.md.tasks.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/archreview/plans/R2-01-s7-fault-hardening-plan.md b/archreview/plans/R2-01-s7-fault-hardening-plan.md index c77dd0fa..f47bc8cd 100644 --- a/archreview/plans/R2-01-s7-fault-hardening-plan.md +++ b/archreview/plans/R2-01-s7-fault-hardening-plan.md @@ -730,3 +730,7 @@ Steps: | STAB-8 note (Task 10) | **S** (trivial) | None — doc only | | Live gate + close-out (Tasks 11-12) | **S** | None locally (env-gated skip); live run is operator-driven | | **Overall** | **S-M** (~2-3 h implementer wall-time) | Single-file production change (`S7Driver.cs`); no contract/DI/schema changes | + +## Execution deviations (R2-01) + +- **Pre-existing, out-of-scope CLI test failure (Task 5/12 gate).** `SubscribeCommandConsoleHandlerCommentTests.SubscribeCommand_explains_why_OnDataChange_uses_console_Output_synchronously` in `tests/Drivers/Cli/ZB.MOM.WW.OtOpcUa.Driver.S7.Cli.Tests` FAILS at the branch base (`1676c8f4`) — the source-scanning assertion expects the literal phrase `"CliFx console"` in `SubscribeCommand.cs`, which commit `9cad9ed0` (docs: strip tracking-ID comments) removed. R2-01 never touches the CLI project (`git diff --stat 1676c8f4 HEAD -- src/Drivers/Cli tests/Drivers/Cli` is empty). Left as-is: not caused by, nor in scope for, S7 fault-path hardening. The rest of the S7 CLI suite is green (48/49). The S7 unit suite (`Driver.S7.Tests`) is fully green (238/238). diff --git a/archreview/plans/R2-01-s7-fault-hardening-plan.md.tasks.json b/archreview/plans/R2-01-s7-fault-hardening-plan.md.tasks.json index c6b2dd2e..536f17d4 100644 --- a/archreview/plans/R2-01-s7-fault-hardening-plan.md.tasks.json +++ b/archreview/plans/R2-01-s7-fault-hardening-plan.md.tasks.json @@ -34,7 +34,7 @@ { "id": 5, "subject": "Finding-1 close gate: full S7 unit + CLI test-project sweep green", - "status": "pending", + "status": "completed", "blockedBy": [4] }, {