From e5b9c18352f6c878af2c9a38739f945bdce30658 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Tue, 6 Jan 2026 15:50:21 -0500 Subject: [PATCH] feat(data-access): add SqlObjects constants and update references Add centralized SqlObjects class with constants for stored procedure and function names using usp_/fn_ prefixes. Update LotFinderRepository and MisQueryBuilder to use the new naming convention. --- .../QueryBuilders/MisQueryBuilder.cs | 2 +- .../LotFinderRepository.SearchManagement.cs | 4 ++-- NEW/src/JdeScoping.DataAccess/SqlObjects.cs | 17 +++++++++++++++++ 3 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 NEW/src/JdeScoping.DataAccess/SqlObjects.cs diff --git a/NEW/src/JdeScoping.DataAccess/QueryBuilders/MisQueryBuilder.cs b/NEW/src/JdeScoping.DataAccess/QueryBuilders/MisQueryBuilder.cs index 147c8e5..94c7199 100644 --- a/NEW/src/JdeScoping.DataAccess/QueryBuilders/MisQueryBuilder.cs +++ b/NEW/src/JdeScoping.DataAccess/QueryBuilders/MisQueryBuilder.cs @@ -159,7 +159,7 @@ public sealed class MisQueryBuilder mm.Status, mm.ReleaseDate FROM MIS_CTE c CROSS APPLY - dbo.MatchMIS(c.WorkOrderNumber, c.ItemNumber, c.BranchCode, c.RoutingType, + dbo.fn_MatchMIS(c.WorkOrderNumber, c.ItemNumber, c.BranchCode, c.RoutingType, c.IssueDate, c.WorkCenterCode, c.StepNumber, c.EndDT, c.FunctionCode, c.FunctionOperationDescription) AS mm; """; diff --git a/NEW/src/JdeScoping.DataAccess/Repositories/LotFinderRepository.SearchManagement.cs b/NEW/src/JdeScoping.DataAccess/Repositories/LotFinderRepository.SearchManagement.cs index d4f02f8..87b62ef 100644 --- a/NEW/src/JdeScoping.DataAccess/Repositories/LotFinderRepository.SearchManagement.cs +++ b/NEW/src/JdeScoping.DataAccess/Repositories/LotFinderRepository.SearchManagement.cs @@ -122,7 +122,7 @@ public partial class LotFinderRepository search.SubmitDt = DateTime.UtcNow; await using var connection = await _connectionFactory.CreateLotFinderConnectionAsync(ct); - await using var command = new SqlCommand("SubmitSearch", connection) + await using var command = new SqlCommand(SqlObjects.SubmitSearch, connection) { CommandType = CommandType.StoredProcedure, CommandTimeout = _options.Value.DefaultTimeoutSeconds @@ -147,7 +147,7 @@ public partial class LotFinderRepository } catch (Exception ex) { - LogAndThrow(ex, operation, "SubmitSearch"); + LogAndThrow(ex, operation, SqlObjects.SubmitSearch); throw; } } diff --git a/NEW/src/JdeScoping.DataAccess/SqlObjects.cs b/NEW/src/JdeScoping.DataAccess/SqlObjects.cs new file mode 100644 index 0000000..41d809f --- /dev/null +++ b/NEW/src/JdeScoping.DataAccess/SqlObjects.cs @@ -0,0 +1,17 @@ +namespace JdeScoping.DataAccess; + +/// +/// Constants for SQL stored procedure and function names. +/// +public static class SqlObjects +{ + // Stored Procedures + public const string SubmitSearch = "usp_SubmitSearch"; + public const string StartSearch = "usp_StartSearch"; + public const string CompleteSearch = "usp_CompleteSearch"; + public const string ResetPartialSearches = "usp_ResetPartialSearches"; + public const string ValidateSearchCriteria = "usp_ValidateSearchCriteria"; + + // Functions + public const string MatchMis = "fn_MatchMIS"; +}