refactor: address code review findings across all projects
Apply comprehensive fixes from code reviews including: - Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase) - Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder) - Implement SecureStore for encrypted secrets storage - Fix error handling with proper HTTP status codes and logging - Optimize double enumeration in DevEtlRegistry - Add DataSync.Dev README for developer onboarding - Extract filter panel base classes to reduce duplication - Update code review docs to mark all issues as fixed
This commit is contained in:
@@ -74,16 +74,6 @@ public class LdapAuthServiceTests
|
||||
result.ErrorMessage.ShouldBe("Unable to connect to directory server");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void GetUserInfoAsync_ThrowsNotSupportedException()
|
||||
{
|
||||
// Arrange
|
||||
var service = new LdapAuthService(_ldapOptions, _logger);
|
||||
|
||||
// Act & Assert
|
||||
Should.Throw<NotSupportedException>(() => service.GetUserInfoAsync("user").GetAwaiter().GetResult());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AuthenticateAsync_AdminBypassUser_ConfigurationIsRecognized()
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user