refactor: address code review findings across all projects
Apply comprehensive fixes from code reviews including: - Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase) - Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder) - Implement SecureStore for encrypted secrets storage - Fix error handling with proper HTTP status codes and logging - Optimize double enumeration in DevEtlRegistry - Add DataSync.Dev README for developer onboarding - Extract filter panel base classes to reduce duplication - Update code review docs to mark all issues as fixed
This commit is contained in:
@@ -37,26 +37,4 @@ public class FakeAuthServiceTests
|
||||
result.ErrorMessage.ShouldBeNull();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetUserInfoAsync_ReturnsUserInfo()
|
||||
{
|
||||
// Act
|
||||
var result = await _sut.GetUserInfoAsync("testuser");
|
||||
|
||||
// Assert
|
||||
result.ShouldNotBeNull();
|
||||
result.Username.ShouldBe("testuser");
|
||||
result.FirstName.ShouldBe("Dev");
|
||||
result.LastName.ShouldBe("User");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task IsInGroupAsync_AlwaysReturnsTrue()
|
||||
{
|
||||
// Act
|
||||
var result = await _sut.IsInGroupAsync("testuser", "AnyGroup");
|
||||
|
||||
// Assert
|
||||
result.ShouldBeTrue();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user