dohertj2/jdescopingtool
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: address code review findings across all projects

Browse Source 
Apply comprehensive fixes from code reviews including:
- Extract shared utilities (SqlFormatHelper, CellValueConverter, DbDestinationBase)
- Add interface abstractions (IAuthenticationService, IDatabaseMigrator, IMisQueryBuilder)
- Implement SecureStore for encrypted secrets storage
- Fix error handling with proper HTTP status codes and logging
- Optimize double enumeration in DevEtlRegistry
- Add DataSync.Dev README for developer onboarding
- Extract filter panel base classes to reduce duplication
- Update code review docs to mark all issues as fixed
This commit is contained in:
Joseph Doherty
2026-01-19 11:05:36 -05:00
parent 08f5aa1447
commit 604bfe919c
148 changed files with 8696 additions and 1538 deletions
Download Patch File Download Diff File Expand all files Collapse all files
NEW/tests/JdeScoping.Api.Tests/Configuration/ServiceRegistrationTests.cs
+4 -4
View File
@@ -25,7 +25,7 @@ public class ServiceRegistrationTests
// Act
services.AddInfrastructure(configuration);
var provider = services.BuildServiceProvider();
var authService = provider.GetRequiredService<IAuthService>();
var authService = provider.GetRequiredService<IAuthenticationService>();
// Assert
authService.ShouldBeOfType<FakeAuthService>();
@@ -41,7 +41,7 @@ public class ServiceRegistrationTests
var configuration = new ConfigurationBuilder()
.AddInMemoryCollection(new Dictionary<string, string?>
{
["Auth:UseFakeAuth"] = "false",
["Ldap:UseFakeAuth"] = "false",
["Ldap:ServerUrls:0"] = "ldap://localhost:389",
["Ldap:SearchBase"] = "DC=example,DC=com"
})
@@ -50,7 +50,7 @@ public class ServiceRegistrationTests
// Act
services.AddInfrastructure(configuration);
var provider = services.BuildServiceProvider();
var authService = provider.GetRequiredService<IAuthService>();
var authService = provider.GetRequiredService<IAuthenticationService>();
// Assert
authService.ShouldBeOfType<LdapAuthService>();
@@ -74,7 +74,7 @@ public class ServiceRegistrationTests
// Act
services.AddInfrastructure(configuration);
var provider = services.BuildServiceProvider();
var authService = provider.GetRequiredService<IAuthService>();
var authService = provider.GetRequiredService<IAuthenticationService>();
// Assert
authService.ShouldBeOfType<LdapAuthService>();